Skip to contentSkip to conversation

perf list: Fix title message

PATCH Applied Andi Kleen 2 participants 2 messages Oct 4, 2022 – Oct 14, 2022 perf events

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 perf list: Fix title message

perf list metricgroups

gives

List of pre-defined events (to be used in -e):

Metric Groups:

Backend
Bad
BadSpec

But that's incorrect of course because metric groups or metrics can only be specified with -M. So fix the message to say -e or -M

---
 tools/perf/builtin-list.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-list.c +1 -1
index 744dd3520584..58e1ec1654ef 100644
@@ -60,7 +60,7 @@ int cmd_list(int argc, const char **argv)
 	setup_pager();
 
 	if (!raw_dump && pager_in_use())
-		printf("\nList of pre-defined events (to be used in -e):\n\n");
+		printf("\nList of pre-defined events (to be used in -e or -M):\n\n");
 
 	if (hybrid_type) {
 		pmu_name = perf_pmu__hybrid_type_to_pmu(hybrid_type);
Signature · 1 line
2.37.2
maintainer Applied
#1 lore raw

Em Tue, Oct 04, 2022 at 12:26:34PM -0700, Andi Kleen escreveu:

Quoted 6 lines

perf list metricgroups

gives

List of pre-defined events (to be used in -e):

Quoted 8 lines

Metric Groups:

Backend
Bad
BadSpec

But that's incorrect of course because metric groups or metrics can only be specified with -M. So fix the message to say -e or -M

Thanks, applied.

- Arnaldo

Quoted 20 lines
---
 tools/perf/builtin-list.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-list.c +1 -1
index 744dd3520584..58e1ec1654ef 100644
@@ -60,7 +60,7 @@ int cmd_list(int argc, const char **argv)
 	setup_pager();
 
 	if (!raw_dump && pager_in_use())
-		printf("\nList of pre-defined events (to be used in -e):\n\n");
+		printf("\nList of pre-defined events (to be used in -e or -M):\n\n");
 
 	if (hybrid_type) {
 		pmu_name = perf_pmu__hybrid_type_to_pmu(hybrid_type);
Signature · 1 line
2.37.2
Signature · 1 line
- Arnaldo