Skip to contentSkip to conversation

syscalls/creat09: Add reference to CVE 2021-4037

PATCH In review Martin Doucha 2 participants 4 messages Oct 5, 2022 – Oct 7, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 syscalls/creat09: Add reference to CVE 2021-4037

---
 testcases/kernel/syscalls/creat/creat09.c | 1 +
 1 file changed, 1 insertion(+)
testcases/kernel/syscalls/creat/creat09.c +1 -0
index 620408920..a5d3740ac 100644
@@ -155,6 +155,7 @@ static struct tst_test test = {
 	.tags = (const struct tst_tag[]) {
 		{"linux-git", "0fa3ecd87848"},
 		{"CVE", "2018-13405"},
+		{"CVE", "2021-4037"},
 		{"linux-git", "01ea173e103e"},
 		{"linux-git", "1639a49ccdce"},
 		{"linux-git", "426b4ca2d6a5"},
Signature · 5 lines
2.37.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi Martin,

thx, merged!

Review static struct tst_test test = { · line 158

Quoted 6 lines

+++ b/testcases/kernel/syscalls/creat/creat09.c

(quoted diff) +1 -0
@@ -155,6 +155,7 @@ static struct tst_test test = {
 	.tags = (const struct tst_tag[]) {
 		{"linux-git", "0fa3ecd87848"},
 		{"CVE", "2018-13405"},
+		{"CVE", "2021-4037"},

How about this change:

cve +1 -1
index 9ab6dc282..6ad3f51fb 100644
@@ -55,7 +55,7 @@ cve-2018-1000001 realpath01
 cve-2018-1000199 ptrace08
 cve-2018-1000204 ioctl_sg01
 cve-2018-12896 timer_settime03
-cve-2018-13405 creat09
+cve-2018-13405-cve-2021-4037 creat09
 cve-2018-18445 bpf_prog04
 cve-2018-18559 bind06
 cve-2018-18955 userns08

Kind regards,
Petr

Quoted 3 lines
(quoted diff) +0 -0
 		{"linux-git", "01ea173e103e"},
 		{"linux-git", "1639a49ccdce"},
 		{"linux-git", "426b4ca2d6a5"},
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw
Quoted 7 lines · Petr Vorel

How about this change:

cve +0 -0
index 9ab6dc282..6ad3f51fb 100644

cve cve-2018-1000001 realpath01 · line 61

Quoted 8 lines
cve +1 -1
@@ -55,7 +55,7 @@ cve-2018-1000001 realpath01
  cve-2018-1000199 ptrace08
  cve-2018-1000204 ioctl_sg01
  cve-2018-12896 timer_settime03
-cve-2018-13405 creat09
+cve-2018-13405-cve-2021-4037 creat09
  cve-2018-18445 bpf_prog04
  cve-2018-18559 bind06
  cve-2018-18955 userns08

I don't think we need to complicate the runfile name like this. As long as the CVE reference gets printed on failure and can be found via grepping the sources, it's good enough.

Signature · 11 lines
Martin Doucha   [email protected]
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw
Quoted 12 lines · Petr Vorel
Quoted 11 lines

How about this change:

cve +0 -1
index 9ab6dc282..6ad3f51fb 100644
@@ -55,7 +55,7 @@ cve-2018-1000001 realpath01
  cve-2018-1000199 ptrace08
  cve-2018-1000204 ioctl_sg01
  cve-2018-12896 timer_settime03
-cve-2018-13405 creat09
Quoted 8 lines

cve cve-2018-1000001 realpath01 · line 61

Quoted 4 lines
cve +1 -0
+cve-2018-13405-cve-2021-4037 creat09
  cve-2018-18445 bpf_prog04
  cve-2018-18559 bind06
  cve-2018-18955 userns08

I don't think we need to complicate the runfile name like this. As long as the CVE reference gets printed on failure and can be found via grepping the sources, it's good enough.

You're right, the original CVE is probably enough.

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp