Skip to contentSkip to conversation

bluez5: change configuration directory mode

PATCH Superseded [email protected] 2 participants 3 messages Oct 5, 2022

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 bluez5: change configuration directory mode

From: Ming Liu <[email protected]>

Change configuration directory mode from 0755 to 0555, this fixes a following warning when bluetoothd starts:
| ConfigurationDirectory 'bluetooth' already exists but the mode is different. | (File system: 755 ConfigurationDirectoryMode: 555)

---
 meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-connectivity/bluez5/bluez5.inc +1 -1
index 79d4645ca8..48b8bcbe75 100644
@@ -82,7 +82,7 @@ do_install:append() {
 	install -d ${D}${INIT_D_DIR}
 	install -m 0755 ${WORKDIR}/init ${D}${INIT_D_DIR}/bluetooth
 
-	install -d ${D}${sysconfdir}/bluetooth/
+	install -m 0755 -d ${D}${sysconfdir}/bluetooth/
 	if [ -f ${S}/profiles/network/network.conf ]; then
 		install -m 0644 ${S}/profiles/network/network.conf ${D}/${sysconfdir}/bluetooth/
 	fi
Signature · 1 line
2.25.1
#1 lore raw
Quoted 24 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Ming Liu
Sent: den 5 oktober 2022 15:59
To: [email protected]
Cc: Ming Liu <[email protected]>
Subject: [OE-core] [PATCH V2] bluez5: change configuration directory mode

From: Ming Liu <[email protected]>

Change configuration directory mode from 0755 to 0555, this fixes a following warning when bluetoothd starts:
| ConfigurationDirectory 'bluetooth' already exists but the mode is different. | (File system: 755 ConfigurationDirectoryMode: 555)

---
 meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-connectivity/bluez5/bluez5.inc +0 -0
index 79d4645ca8..48b8bcbe75 100644

meta/recipes-connectivity/bluez5/bluez5.inc do_install:append() { · line 85

Quoted 5 lines
meta/recipes-connectivity/bluez5/bluez5.inc +1 -1
@@ -82,7 +82,7 @@ do_install:append() {
 	install -d ${D}${INIT_D_DIR}
 	install -m 0755 ${WORKDIR}/init ${D}${INIT_D_DIR}/bluetooth
 
-	install -d ${D}${sysconfdir}/bluetooth/
+	install -m 0755 -d ${D}${sysconfdir}/bluetooth/

The default mode used by install if not specified is 0755. The above change should not make any difference...

Quoted 5 lines
meta/recipes-connectivity/bluez5/bluez5.inc +0 -1
 	if [ -f ${S}/profiles/network/network.conf ]; then
 		install -m 0644 ${S}/profiles/network/network.conf ${D}/${sysconfdir}/bluetooth/
 	fi
--

2.25.1

//Peter

author
#2 lore raw

Hi, Peter:

You are absolutely right, I also noticed that, it’s a typo, it should be 0555, will send a V3 soon.

//Ming Liu

Quoted 46 lines

-----Original Message-----

Quoted 1 line

From: [email protected] <

[email protected]> On Behalf Of Ming Liu

Quoted 10 lines

Sent: den 5 oktober 2022 15:59
To: [email protected]
Cc: Ming Liu <[email protected]>
Subject: [OE-core] [PATCH V2] bluez5: change configuration directory mode

From: Ming Liu <[email protected]>

Change configuration directory mode from 0755 to 0555, this fixes a following warning when bluetoothd starts:
| ConfigurationDirectory 'bluetooth' already exists but the mode is

different.

Review

Quoted 8 lines

| (File system: 755 ConfigurationDirectoryMode: 555)

---
 meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta/recipes-connectivity/bluez5/bluez5.inc

meta/recipes-connectivity/bluez5/bluez5.inc do_install:append() { · line 85

Quoted 9 lines

index 79d4645ca8..48b8bcbe75 100644

meta/recipes-connectivity/bluez5/bluez5.inc +1 -1
@@ -82,7 +82,7 @@ do_install:append() {
      install -d ${D}${INIT_D_DIR}
      install -m 0755 ${WORKDIR}/init ${D}${INIT_D_DIR}/bluetooth
 
-     install -d ${D}${sysconfdir}/bluetooth/
+     install -m 0755 -d ${D}${sysconfdir}/bluetooth/

The default mode used by install if not specified is 0755. The above change should not make any difference...

meta/recipes-connectivity/bluez5/bluez5.inc do_install:append() { · line 87

Quoted 2 lines
meta/recipes-connectivity/bluez5/bluez5.inc +0 -0
      if [ -f ${S}/profiles/network/network.conf ]; then
              install -m 0644 ${S}/profiles/network/network.conf

${D}/${sysconfdir}/bluetooth/

Quoted 3 lines
meta/recipes-connectivity/bluez5/bluez5.inc +0 -1
      fi
--

2.25.1

//Peter