Skip to contentSkip to conversation

core-image-sato: install virtio input for Qemu targets

PATCH In review Thomas Perrot 4 participants 10 messages Oct 5, 2022 – Oct 6, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 core-image-sato: install virtio input for Qemu targets

Otherwise, it isn't possible to interact with the UI.

---
 meta/recipes-sato/images/core-image-sato.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-sato/images/core-image-sato.bb +2 -0
index e63a229d1257..0e37c15097b3 100644
@@ -12,6 +12,8 @@ inherit core-image
 TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib-2.0"
 TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-intltool nativesdk-glib-2.0"
 
+IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
+
 QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}'
 QB_MEM:qemuarmv5 = "-m 256"
 QB_MEM:qemumips = "-m 256"
Signature · 1 line
2.37.3
#1 lore raw

Has this regressed at some point? Why was it not needed before?

Alex

Quoted 38 lines · Thomas Perrot via lists.openembedded.org

Otherwise, it isn't possible to interact with the UI.

---
 meta/recipes-sato/images/core-image-sato.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-sato/images/core-image-sato.bb +0 -0
index e63a229d1257..0e37c15097b3 100644
@@ -12,6 +12,8 @@ inherit core-image
 TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib-2.0"
 TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-intltool

nativesdk-glib-2.0"

meta/recipes-sato/images/core-image-sato.bb +2 -0
+IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
+
 QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m

256", d)}'
QB_MEM:qemuarmv5 = "-m 256"
QB_MEM:qemumips = "-m 256"
--
2.37.3

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#171461):
https://lists.openembedded.org/g/openembedded-core/message/171461
Mute This Topic: https://lists.openembedded.org/mt/94137249/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw

Hello Alex,

Quoted 1 line · Alexander Kanavin

Has this regressed at some point? Why was it not needed before?

This issue occurs when the rrecommends are not installed.

Kind regards,
Thomas

Quoted 41 lines

Alex

Quoted 36 lines · Thomas Perrot via lists.openembedded.org

Otherwise, it isn't possible to interact with the UI.

---
 meta/recipes-sato/images/core-image-sato.bb | 2 ++

 1 file changed, 2 insertions(+)
meta/recipes-sato/images/core-image-sato.bb +0 -0
index e63a229d1257..0e37c15097b3 100644
@@ -12,6 +12,8 @@ inherit core-image

 TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib- 2.0"
 TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk- intltool nativesdk-glib-2.0"

meta/recipes-sato/images/core-image-sato.bb +2 -0
+IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
+

 QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}'
 QB_MEM:qemuarmv5 = "-m 256"
 QB_MEM:qemumips = "-m 256"

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#171465):
https://lists.openembedded.org/g/openembedded-core/message/171465
Mute This Topic: https://lists.openembedded.org/mt/94137249/5443093
Group Owner: [email protected] Unsubscribe:
https://lists.openembedded.org/g/openembedded-core/unsub [
[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
#3 lore raw

Then please add this to the commit message.

Alex

Quoted 54 lines · Thomas Perrot

Hello Alex,

On Wed, 2022-10-05 at 17:31 +0200, Alexander Kanavin wrote:

Has this regressed at some point? Why was it not needed before?

This issue occurs when the rrecommends are not installed.

Kind regards,
Thomas

Alex

On Wed 5. Oct 2022 at 17.01, Thomas Perrot via lists.openembedded.org <[email protected]> wrote:

Otherwise, it isn't possible to interact with the UI.

---
 meta/recipes-sato/images/core-image-sato.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-sato/images/core-image-sato.bb +2 -1
index e63a229d1257..0e37c15097b3 100644
@@ -12,6 +12,8 @@ inherit core-image
 TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib-2.0"
 TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-intltool nativesdk-glib-2.0"
 
+IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
+
 QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}'
 QB_MEM:qemuarmv5 = "-m 256"
 QB_MEM:qemumips = "-m 256"
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#171465): https://lists.openembedded.org/g/openembedded-core/message/171465
Mute This Topic: https://lists.openembedded.org/mt/94137249/5443093
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

--

Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

#4 lore raw
In reply to Thomas Perrot
Quoted 2 lines · Thomas Perrot via lists.openembedded.org

Otherwise, it isn't possible to interact with the UI.

I wonder if it should be in the MACHINE_EXTRA_RRECOMMENDS in machine configs, it will help a wide range of users who may be using graphical images.

Quoted 31 lines
---
 meta/recipes-sato/images/core-image-sato.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-sato/images/core-image-sato.bb +2 -1
index e63a229d1257..0e37c15097b3 100644
@@ -12,6 +12,8 @@ inherit core-image
 TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib-2.0"
 TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-intltool nativesdk-glib-2.0"
 
+IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
+
 QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}'
 QB_MEM:qemuarmv5 = "-m 256"
 QB_MEM:qemumips = "-m 256"
--

2.37.3

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#171461): https://lists.openembedded.org/g/openembedded-core/message/171461
Mute This Topic: https://lists.openembedded.org/mt/94137249/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#5 lore raw

Hello Khem,

Quoted 9 lines · Khem Raj
Quoted 2 lines · Thomas Perrot via lists.openembedded.org

Otherwise, it isn't possible to interact with the UI.

I wonder if it should be in the MACHINE_EXTRA_RRECOMMENDS in machine configs, it will help a wide range of users who may be using graphical images.

I hesitated to put it in MACHINE_EXTRA_RDEPENDS for Qemu targets.

Currently, kernel-modules are in MACHINE_EXTRA_RRECOMMENDS of Qemu RISC-V and PPC64, which are not installed when NO_RECOMMENDATIONS="1"

Kind regards,
Thomas

Quoted 39 lines
Quoted 39 lines

---
 meta/recipes-sato/images/core-image-sato.bb | 2 ++

 1 file changed, 2 insertions(+)
meta/recipes-sato/images/core-image-sato.bb +0 -0
index e63a229d1257..0e37c15097b3 100644
@@ -12,6 +12,8 @@ inherit core-image

 TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib- 2.0"
 TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk- intltool nativesdk-glib-2.0"

meta/recipes-sato/images/core-image-sato.bb +2 -0
+IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
+

 QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}'
 QB_MEM:qemuarmv5 = "-m 256"
 QB_MEM:qemumips = "-m 256"
--
2.37.3

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#171461):
https://lists.openembedded.org/g/openembedded-core/message/171461
Mute This Topic: https://lists.openembedded.org/mt/94137249/1997914
Group Owner: [email protected] Unsubscribe:
https://lists.openembedded.org/g/openembedded-core/unsub [
[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
#6 lore raw

Does core-image-weston have the same problem? If it does, then this certainly needs to go to qemu include in conf/machine/

Alex

Quoted 67 lines · Thomas Perrot via lists.openembedded.org

Hello Khem,

Quoted 9 lines · Khem Raj
Quoted 2 lines · Thomas Perrot via lists.openembedded.org

Otherwise, it isn't possible to interact with the UI.

I wonder if it should be in the MACHINE_EXTRA_RRECOMMENDS in machine configs, it will help a wide range of users who may be using graphical images.

I hesitated to put it in MACHINE_EXTRA_RDEPENDS for Qemu targets.

Currently, kernel-modules are in MACHINE_EXTRA_RRECOMMENDS of Qemu RISC-V and PPC64, which are not installed when NO_RECOMMENDATIONS="1"

Kind regards,
Thomas

Quoted 18 lines
Quoted 18 lines
---
 meta/recipes-sato/images/core-image-sato.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-sato/images/core-image-sato.bb +0 -0
index e63a229d1257..0e37c15097b3 100644
@@ -12,6 +12,8 @@ inherit core-image
 TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib-

2.0"
TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-
intltool nativesdk-glib-2.0"

Quoted 12 lines
Quoted 12 lines
meta/recipes-sato/images/core-image-sato.bb +2 -0
+IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
+
 QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m

512", "-m 256", d)}'
QB_MEM:qemuarmv5 = "-m 256"
QB_MEM:qemumips = "-m 256"
--
2.37.3

--
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#171468): https://lists.openembedded.org/g/openembedded-core/message/171468
Mute This Topic: https://lists.openembedded.org/mt/94137249/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#7 lore raw

Hello Alex,

Quoted 3 lines · Alexander Kanavin
Quoted 3 lines

Does core-image-weston have the same problem? If it does, then this certainly needs to go to qemu include in conf/machine/

Yes, the same issue occurs on core-image-weston, when NO_RECOMMENDATIONS = "1".

So, instead of adding this rdepends in the sato image, I can add kernel-module-virtio-input in MACHINE_EXTRA_RDEPENDS in conf/machine/include/qemu.inc.

In addition, I'm looking to use a built-in virtio-input, as proposed by
Bruce Ashfield.

Kind regards,
Thomas

Quoted 89 lines
Quoted 89 lines

Alex

Quoted 64 lines · Thomas Perrot via lists.openembedded.org
Quoted 64 lines

Hello Khem,

Quoted 11 lines · Khem Raj
Quoted 11 lines
Quoted 2 lines · Thomas Perrot via lists.openembedded.org
Quoted 2 lines

Otherwise, it isn't possible to interact with the UI.

I wonder if it should be in the MACHINE_EXTRA_RRECOMMENDS in > > > machine
configs, it will help a wide range of users who may be using
graphical images.

I hesitated to put it in MACHINE_EXTRA_RDEPENDS for Qemu targets.

Currently, kernel-modules are in MACHINE_EXTRA_RRECOMMENDS of Qemu
RISC-V and PPC64, which are not installed when > > NO_RECOMMENDATIONS="1"

Kind regards,
Thomas

Quoted 36 lines
Quoted 36 lines
Quoted 36 lines
Quoted 36 lines

Signed-off-by: Thomas Perrot <[email protected]>
---
 meta/recipes-sato/images/core-image-sato.bb | 2 ++

 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

sato.bb
b/meta/recipes-sato/images/core-image-sato.bb
index e63a229d1257..0e37c15097b3 100644

meta/recipes-sato/images/core-image-sato.bb +0 -0
@@ -12,6 +12,8 @@ inherit core-image

 TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool > >

Quoted 1 line
Quoted 1 line

nativesdk-glib-

2.0" TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " >

Quoted 1 line
Quoted 1 line
Quoted 1 line

nativesdk-

intltool nativesdk-glib-2.0"

+IMAGE_INSTALL:append:qemuall = " kernel-module-virtio- input"
+
 QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", > > > > "-m
512", "-m 256", d)}'
 QB_MEM:qemuarmv5 = "-m 256"
 QB_MEM:qemumips = "-m 256"
--
2.37.3

Quoted 8 lines
Quoted 8 lines

--
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#171469): >
https://lists.openembedded.org/g/openembedded-core/message/171469
Mute This Topic: https://lists.openembedded.org/mt/94137249/5443093
Group Owner: [email protected] Unsubscribe:
https://lists.openembedded.org/g/openembedded-core/unsub>
 [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
#8 lore raw
In reply to Thomas Perrot
Quoted 10 lines · Thomas Perrot via lists.openembedded.org

Hello Khem,

Quoted 6 lines · Khem Raj
Quoted 2 lines · Thomas Perrot via lists.openembedded.org

Otherwise, it isn't possible to interact with the UI.

Quoted 9 lines
Quoted 3 lines

I wonder if it should be in the MACHINE_EXTRA_RRECOMMENDS in machine configs, it will help a wide range of users who may be using graphical images.

I hesitated to put it in MACHINE_EXTRA_RDEPENDS for Qemu targets.

Currently, kernel-modules are in MACHINE_EXTRA_RRECOMMENDS of Qemu RISC-V and PPC64, which are not installed when NO_RECOMMENDATIONS="1"

We don't control the kernel configuration to the point where we can guarantee that something is built as a module or not.

Have you tried assembling the image with that option built-in, versus a module ? Last I checked, a kernel-module* dependency won't be provided by the built-ins, and this will trigger an error.

With that option appended, it isn't something that can be overridden easily, and the qemu* + core images are used as a starting point for demos, etc (whether or not that is a good idea is also debatable). If a non-core kernel provider and qemu are used in a scenario like that .. they can trigger the error.

Bruce

Quoted 48 lines

Kind regards,
Thomas

Quoted 18 lines
Quoted 18 lines
---
 meta/recipes-sato/images/core-image-sato.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-sato/images/core-image-sato.bb +0 -0
index e63a229d1257..0e37c15097b3 100644
@@ -12,6 +12,8 @@ inherit core-image
 TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib-

2.0"
TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-
intltool nativesdk-glib-2.0"

Quoted 12 lines
Quoted 12 lines
meta/recipes-sato/images/core-image-sato.bb +2 -0
+IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
+
 QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m

512", "-m 256", d)}'
QB_MEM:qemuarmv5 = "-m 256"
QB_MEM:qemumips = "-m 256"
--
2.37.3

--
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#171468): https://lists.openembedded.org/g/openembedded-core/message/171468
Mute This Topic: https://lists.openembedded.org/mt/94137249/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
#9 lore raw

Hello Bruce,

Quoted 25 lines · Bruce Ashfield
Quoted 15 lines · Thomas Perrot via lists.openembedded.org

Hello Khem,

Quoted 10 lines · Khem Raj
Quoted 2 lines · Thomas Perrot via lists.openembedded.org

Otherwise, it isn't possible to interact with the UI.

I wonder if it should be in the MACHINE_EXTRA_RRECOMMENDS in machine
configs, it will help a wide range of users who may be using graphical images.

Quoted 6 lines

I hesitated to put it in MACHINE_EXTRA_RDEPENDS for Qemu targets.

Currently, kernel-modules are in MACHINE_EXTRA_RRECOMMENDS of Qemu RISC-V and PPC64, which are not installed when NO_RECOMMENDATIONS="1"

Quoted 5 lines

We don't control the kernel configuration to the point where we can guarantee that something is built as a module or not.

Have you tried assembling the image with that option built-in, versus a module ?

I tried to use a built-in virtio-input on Qemu targets, so the boot process stalled with the following message: "please wait: booting..." Then it seems necessary to use this driver as a kernel module on Qemu targets.

Kind regards,
Thomas

Quoted 70 lines

Last I checked, a kernel-module* dependency won't be provided by the built-ins, and this will trigger an error.

With that option appended, it isn't something that can be overridden easily, and the qemu* + core images are used as a starting point for demos, etc (whether or not that is a good idea is also debatable). If a non-core kernel provider and qemu are used in a scenario like that .. they can trigger the error.

Bruce

Quoted 33 lines

Kind regards,
Thomas

Quoted 30 lines
Quoted 30 lines

---
 meta/recipes-sato/images/core-image-sato.bb | 2 ++

 1 file changed, 2 insertions(+)
meta/recipes-sato/images/core-image-sato.bb +0 -0
index e63a229d1257..0e37c15097b3 100644
@@ -12,6 +12,8 @@ inherit core-image

 TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk- glib-
2.0" TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-
intltool nativesdk-glib-2.0"

meta/recipes-sato/images/core-image-sato.bb +2 -0
+IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
+

 QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "- m
512", "-m 256", d)}'
 QB_MEM:qemuarmv5 = "-m 256"
 QB_MEM:qemumips = "-m 256"
--
2.37.3

Quoted 12 lines
Quoted 3 lines
Quoted 3 lines

--
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#171473):
https://lists.openembedded.org/g/openembedded-core/message/171473
Mute This Topic: https://lists.openembedded.org/mt/94137249/5443093
Group Owner: [email protected] Unsubscribe:
https://lists.openembedded.org/g/openembedded-core/unsub [
[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com