Skip to contentSkip to conversation

genirq: Remove unused parameter force of irq_set_affinity_deactivated()

PATCH Applied Angus Chen 3 participants 4 messages Oct 7, 2022 – Nov 17, 2022 IRQ

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore

Angus Chen

author
#0 lore raw

PATCH 1/1 genirq: Remove unused parameter force of irq_set_affinity_deactivated()

The force parameter in irq_set_affinity_deactivated() is not used, get rid of it.

Fixes baedb87d1b53 ("genirq/affinity: Handle affinity setting on inactive interrupts correctly")
---
 kernel/irq/manage.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/irq/manage.c +2 -2
index 40fe7806cc8c..5b7cf28df290 100644
@@ -321,7 +321,7 @@ static int irq_try_set_affinity(struct irq_data *data,
 }
 
 static bool irq_set_affinity_deactivated(struct irq_data *data,
-					 const struct cpumask *mask, bool force)
+					 const struct cpumask *mask)
 {
 	struct irq_desc *desc = irq_data_to_desc(data);
 
@@ -354,7 +354,7 @@ int irq_set_affinity_locked(struct irq_data *data, const struct cpumask *mask,
 	if (!chip || !chip->irq_set_affinity)
 		return -EINVAL;
 
-	if (irq_set_affinity_deactivated(data, mask, force))
+	if (irq_set_affinity_deactivated(data, mask))
 		return 0;
 
 	if (irq_can_move_pcntxt(data) && !irqd_is_setaffinity_pending(data)) {
Signature · 1 line
2.25.1
#1 lore raw
Quoted 2 lines · Angus Chen

The force parameter in irq_set_affinity_deactivated() is not used, get rid of it.

Correct.

Quoted 2 lines
Fixes baedb87d1b53 ("genirq/affinity: Handle affinity setting on

inactive interrupts correctly")

What does this fix? An unused argument is neither a bug nor a problem. Removing it is a cleanup nothing else.

Thanks,

tglx

author
#2 lore raw

Hi tglx.

Quoted 12 lines

-----Original Message-----
From: Thomas Gleixner <[email protected]>
Sent: Saturday, November 12, 2022 2:11 AM
To: Angus Chen <[email protected]>
Cc: [email protected]; Angus Chen <[email protected]>
Subject: Re: [PATCH] genirq: Remove unused parameter force of irq_set_affinity_deactivated()

Quoted 2 lines · Angus Chen

The force parameter in irq_set_affinity_deactivated() is not used, get rid of it.

Quoted 8 lines

Correct.

Quoted 2 lines
Fixes baedb87d1b53 ("genirq/affinity: Handle affinity setting on

inactive interrupts correctly")

What does this fix? An unused argument is neither a bug nor a problem. Removing it is a cleanup nothing else.

Thank you for your reply.
I almost forget this patch because it just a cleanup. I thought maybe it is too simple to submit, so it be ignored by maintainer.
Can I send a v2 to modify the git log ? Thanks.

Quoted 3 lines

Thanks,

tglx

merge bot Applied
#3 lore raw

[tip: irq/core] genirq: Remove unused argument force of irq_set_affinity_deactivated()

In reply to Angus Chen
The following commit has been merged into the irq/core branch of tip:

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     fd19ce77993a49f3afc56bb4cae7eafb1ec69e0c
Gitweb:        https://git.kernel.org/tip/fd19ce77993a49f3afc56bb4cae7eafb1ec69e0c
Author:        Angus Chen <[email protected]>
AuthorDate:    Fri, 07 Oct 2022 18:32:36 +08:00
Committer:     Thomas Gleixner <[email protected]>
CommitterDate: Thu, 17 Nov 2022 14:00:55 +01:00

genirq: Remove unused argument force of irq_set_affinity_deactivated()

The force parameter in irq_set_affinity_deactivated() is not used, get rid of it.

---
 kernel/irq/manage.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/irq/manage.c +2 -2
index 40fe780..5b7cf28 100644
@@ -321,7 +321,7 @@ static int irq_try_set_affinity(struct irq_data *data,
 }
 
 static bool irq_set_affinity_deactivated(struct irq_data *data,
-					 const struct cpumask *mask, bool force)
+					 const struct cpumask *mask)
 {
 	struct irq_desc *desc = irq_data_to_desc(data);
 
@@ -354,7 +354,7 @@ int irq_set_affinity_locked(struct irq_data *data, const struct cpumask *mask,
 	if (!chip || !chip->irq_set_affinity)
 		return -EINVAL;
 
-	if (irq_set_affinity_deactivated(data, mask, force))
+	if (irq_set_affinity_deactivated(data, mask))
 		return 0;
 
 	if (irq_can_move_pcntxt(data) && !irqd_is_setaffinity_pending(data)) {