scsi: pm80xx: Remove unused reset_in_progress flag logic
Subsystems (2)
PATCH 1/1 scsi: pm80xx: Remove unused reset_in_progress flag logic
The reset_in_progress flag was never set.
Signed-off-by Igor Pylypiv <[email protected]>
Reviewed-by Andrew Konecki <[email protected]>
--- drivers/scsi/pm8001/pm8001_sas.h | 1 - drivers/scsi/pm8001/pm80xx_hwi.c | 4 ---- 2 files changed, 5 deletions(-)
drivers/scsi/pm8001/pm8001_sas.h +0 -1
@@ -535,7 +535,6 @@ struct pm8001_hba_info {bool controller_fatal_error;const struct firmware *fw_image;struct isr_param irq_vector[PM8001_MAX_MSIX_VEC ]; -u32 reset_in_progress;u32 non_fatal_count;u32 non_fatal_read_length;u32 max_q_num;
drivers/scsi/pm8001/pm80xx_hwi.c +0 -4
@@ -3550,10 +3550,6 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb)case HW_EVENT_PHY_DOWN :pm8001_dbg (pm8001_ha,MSG ,"HW_EVENT_PHY_DOWN\n" );hw_event_phy_down (pm8001_ha, piomb); -if (pm8001_ha->reset_in_progress) { -pm8001_dbg (pm8001_ha,MSG ,"Reset in progress\n" ); -return 0 ; - } phy->phy_attached =0 ; phy->phy_state =PHY_LINK_DISABLE ;break ;
Signature · 1 line
2.38.0.rc1.362.ged0d419d3c-goog
Quoted 5 lines · Igor Pylypiv
The
reset_in_progressflag was never set.Signed-off-by Igor Pylypiv <[email protected]>Reviewed-by Andrew Konecki <[email protected]>
Acked-by Jack Wang <[email protected]>
Quoted 35 lines
--- drivers/scsi/pm8001/pm8001_sas.h | 1 - drivers/scsi/pm8001/pm80xx_hwi.c | 4 ---- 2 files changed, 5 deletions(-)drivers/scsi/pm8001/pm8001_sas.h +0
-1@@ -535,7 +535,6 @@ struct pm8001_hba_info {bool controller_fatal_error;const struct firmware *fw_image;struct isr_param irq_vector[PM8001_MAX_MSIX_VEC ]; -u32 reset_in_progress;u32 non_fatal_count;u32 non_fatal_read_length;u32 max_q_num;drivers/scsi/pm8001/pm80xx_hwi.c +0
-5@@ -3550,10 +3550,6 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb)case HW_EVENT_PHY_DOWN :pm8001_dbg (pm8001_ha,MSG ,"HW_EVENT_PHY_DOWN\n" );hw_event_phy_down (pm8001_ha, piomb); -if (pm8001_ha->reset_in_progress) { -pm8001_dbg (pm8001_ha,MSG ,"Reset in progress\n" ); -return 0 ; - } phy->phy_attached =0 ; phy->phy_state =PHY_LINK_DISABLE ;break ; --2.38.0.rc1.362.ged0d419d3c-goog
Martin K. Petersen
AppliedIgor,
Quoted 1 line
The
reset_in_progressflag was never set.
Applied to 6.2/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 3 lines · Igor Pylypiv
The
reset_in_progressflag was never set.
Applied to 6.2/scsi-queue, thanks!
[1/1] scsi: pm80xx: Remove unused reset_in_progress flag logic
https://git.kernel.org/mkp/scsi/c/5f62639dc2b6
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering