Skip to contentSkip to conversation

scsi: pm80xx: Remove unused reset_in_progress flag logic

PATCH Applied Igor Pylypiv 3 participants 4 messages Oct 7, 2022 – Oct 27, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: pm80xx: Remove unused reset_in_progress flag logic

The reset_in_progress flag was never set.

---
 drivers/scsi/pm8001/pm8001_sas.h | 1 -
 drivers/scsi/pm8001/pm80xx_hwi.c | 4 ----
 2 files changed, 5 deletions(-)
drivers/scsi/pm8001/pm8001_sas.h +0 -1
index b08f52673889..2bbec5083106 100644
@@ -535,7 +535,6 @@ struct pm8001_hba_info {
 	bool			controller_fatal_error;
 	const struct firmware 	*fw_image;
 	struct isr_param irq_vector[PM8001_MAX_MSIX_VEC];
-	u32			reset_in_progress;
 	u32			non_fatal_count;
 	u32			non_fatal_read_length;
 	u32 max_q_num;
drivers/scsi/pm8001/pm80xx_hwi.c +0 -4
index f8b8624458f7..51c9541f6f4d 100644
@@ -3550,10 +3550,6 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb)
 	case HW_EVENT_PHY_DOWN:
 		pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_PHY_DOWN\n");
 		hw_event_phy_down(pm8001_ha, piomb);
-		if (pm8001_ha->reset_in_progress) {
-			pm8001_dbg(pm8001_ha, MSG, "Reset in progress\n");
-			return 0;
-		}
 		phy->phy_attached = 0;
 		phy->phy_state = PHY_LINK_DISABLE;
 		break;
Signature · 1 line
2.38.0.rc1.362.ged0d419d3c-goog
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Igor Pylypiv

The reset_in_progress flag was never set.

Quoted 35 lines
---
 drivers/scsi/pm8001/pm8001_sas.h | 1 -
 drivers/scsi/pm8001/pm80xx_hwi.c | 4 ----
 2 files changed, 5 deletions(-)
drivers/scsi/pm8001/pm8001_sas.h +0 -1
index b08f52673889..2bbec5083106 100644
@@ -535,7 +535,6 @@ struct pm8001_hba_info {
        bool                    controller_fatal_error;
        const struct firmware   *fw_image;
        struct isr_param irq_vector[PM8001_MAX_MSIX_VEC];
-       u32                     reset_in_progress;
        u32                     non_fatal_count;
        u32                     non_fatal_read_length;
        u32 max_q_num;
drivers/scsi/pm8001/pm80xx_hwi.c +0 -5
index f8b8624458f7..51c9541f6f4d 100644
@@ -3550,10 +3550,6 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb)
        case HW_EVENT_PHY_DOWN:
                pm8001_dbg(pm8001_ha, MSG, "HW_EVENT_PHY_DOWN\n");
                hw_event_phy_down(pm8001_ha, piomb);
-               if (pm8001_ha->reset_in_progress) {
-                       pm8001_dbg(pm8001_ha, MSG, "Reset in progress\n");
-                       return 0;
-               }
                phy->phy_attached = 0;
                phy->phy_state = PHY_LINK_DISABLE;
                break;
--

2.38.0.rc1.362.ged0d419d3c-goog