Skip to contentSkip to conversation

gui: Fix export file chooser dialog

PATCH In review Petr Lautrbach 2 participants 3 messages Oct 11, 2022 – Oct 24, 2022 SELinux security module

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gui: Fix export file chooser dialog

It wasn't possible to choose a directory in filechooser dialog using double-click - the dialog returned the directory name instead of listing the directory.

Fixes:
Traceback (most recent call last):
File "/usr/lib/python3.10/site-packages/sepolicy/gui.py", line 2593, in on_browse_select
self.export_config(filename)
File "/usr/lib/python3.10/site-packages/sepolicy/gui.py", line 2668, in export_config
fd = open(filename, 'w')
IsADirectoryError: [Errno 21] Is a directory: '/root/Downloads'

---
 python/sepolicy/sepolicy/sepolicy.glade | 1 -
 1 file changed, 1 deletion(-)
python/sepolicy/sepolicy/sepolicy.glade +0 -1
index 52407887fcfc..0724d6c8caa4 100644
@@ -168,7 +168,6 @@
       <object class="GtkBox" id="filechooserdialog-vbox1">
         <property name="can_focus">False</property>
         <property name="orientation">vertical</property>
-        <signal name="button-press-event" handler="on_choose_file" swapped="no"/>
         <child internal-child="action_area">
           <object class="GtkButtonBox" id="filechooserdialog-action_area1">
             <property name="can_focus">False</property>
Signature · 1 line
2.37.3
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Petr Lautrbach

It wasn't possible to choose a directory in filechooser dialog using double-click - the dialog returned the directory name instead of listing the directory.

Fixes:
Traceback (most recent call last):
File "/usr/lib/python3.10/site-packages/sepolicy/gui.py", line 2593, in on_browse_select
self.export_config(filename)
File "/usr/lib/python3.10/site-packages/sepolicy/gui.py", line 2668, in export_config
fd = open(filename, 'w')
IsADirectoryError: [Errno 21] Is a directory: '/root/Downloads'

Quoted 1 line
Quoted 19 lines
---
 python/sepolicy/sepolicy/sepolicy.glade | 1 -
 1 file changed, 1 deletion(-)
python/sepolicy/sepolicy/sepolicy.glade +0 -2
index 52407887fcfc..0724d6c8caa4 100644
@@ -168,7 +168,6 @@
       <object class="GtkBox" id="filechooserdialog-vbox1">
         <property name="can_focus">False</property>
         <property name="orientation">vertical</property>
-        <signal name="button-press-event" handler="on_choose_file" swapped="no"/>
         <child internal-child="action_area">
           <object class="GtkButtonBox" id="filechooserdialog-action_area1">
             <property name="can_focus">False</property>
--

2.37.3

#2 lore raw
Quoted 15 lines · James Carter
Quoted 13 lines · Petr Lautrbach

It wasn't possible to choose a directory in filechooser dialog using double-click - the dialog returned the directory name instead of listing the directory.

Fixes:
Traceback (most recent call last):
File "/usr/lib/python3.10/site-packages/sepolicy/gui.py", line 2593, in on_browse_select
self.export_config(filename)
File "/usr/lib/python3.10/site-packages/sepolicy/gui.py", line 2668, in export_config
fd = open(filename, 'w')
IsADirectoryError: [Errno 21] Is a directory: '/root/Downloads'

Quoted 4 lines
Quoted 1 line

Merged.
Thanks,
Jim

Quoted 19 lines
Quoted 19 lines
---
 python/sepolicy/sepolicy/sepolicy.glade | 1 -
 1 file changed, 1 deletion(-)
python/sepolicy/sepolicy/sepolicy.glade +0 -2
index 52407887fcfc..0724d6c8caa4 100644
@@ -168,7 +168,6 @@
       <object class="GtkBox" id="filechooserdialog-vbox1">
         <property name="can_focus">False</property>
         <property name="orientation">vertical</property>
-        <signal name="button-press-event" handler="on_choose_file" swapped="no"/>
         <child internal-child="action_area">
           <object class="GtkButtonBox" id="filechooserdialog-action_area1">
             <property name="can_focus">False</property>
--

2.37.3