Skip to contentSkip to conversation

tests/qtest/cxl-test: Remove temporary directories after testing

PATCH In review Thomas Huth 3 participants 3 messages Oct 12, 2022 – Oct 17, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/qtest/cxl-test: Remove temporary directories after testing

The cxl-test leaves some temporary directories behind. Let's clean them up now!

---
 tests/qtest/cxl-test.c | 3 +++
 1 file changed, 3 insertions(+)
tests/qtest/cxl-test.c +3 -0
index cbe0fb549b..61f25a72b6 100644
@@ -101,6 +101,7 @@ static void cxl_t3d(void)
 
     qtest_start(cmdline->str);
     qtest_end();
+    rmdir(tmpfs);
 }
 
 static void cxl_1pxb_2rp_2t3d(void)
@@ -115,6 +116,7 @@ static void cxl_1pxb_2rp_2t3d(void)
 
     qtest_start(cmdline->str);
     qtest_end();
+    rmdir(tmpfs);
 }
 
 static void cxl_2pxb_4rp_4t3d(void)
@@ -130,6 +132,7 @@ static void cxl_2pxb_4rp_4t3d(void)
 
     qtest_start(cmdline->str);
     qtest_end();
+    rmdir(tmpfs);
 }
 #endif /* CONFIG_POSIX */
 
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 12 lines

-----Original Message-----
From: Qemu-devel <[email protected]> On Behalf Of Thomas Huth
Sent: Wednesday, October 12, 2022 5:15 PM
To: [email protected]; Jonathan Cameron <[email protected]>
Cc: Laurent Vivier <[email protected]>; Michael S . Tsirkin <[email protected]>
Subject: [PATCH] tests/qtest/cxl-test: Remove temporary directories after testing

Quoted 4 lines

The cxl-test leaves some temporary directories behind. Let's clean them up now!

LGTM.

Thanks
Chen

Quoted 35 lines
---
 tests/qtest/cxl-test.c | 3 +++
 1 file changed, 3 insertions(+)
tests/qtest/cxl-test.c index renamed from tests/qtest/cxl-test.c +0 -0

cbe0fb549b..61f25a72b6 100644

tests/qtest/cxl-test.c +3 -1
@@ -101,6 +101,7 @@ static void cxl_t3d(void)
 
     qtest_start(cmdline->str);
     qtest_end();
+    rmdir(tmpfs);
 }
 
 static void cxl_1pxb_2rp_2t3d(void)
@@ -115,6 +116,7 @@ static void cxl_1pxb_2rp_2t3d(void)
 
     qtest_start(cmdline->str);
     qtest_end();
+    rmdir(tmpfs);
 }
 
 static void cxl_2pxb_4rp_4t3d(void)
@@ -130,6 +132,7 @@ static void cxl_2pxb_4rp_4t3d(void)
 
     qtest_start(cmdline->str);
     qtest_end();
+    rmdir(tmpfs);
 }
 #endif /* CONFIG_POSIX */
 
--

2.31.1

Acked-by Jonathan Cameron
#2 lore raw
Quoted 13 lines · Chen
Quoted 13 lines

-----Original Message-----
From: Qemu-devel <[email protected]> On Behalf Of Thomas Huth
Sent: Wednesday, October 12, 2022 5:15 PM
To: [email protected]; Jonathan Cameron <[email protected]>
Cc: Laurent Vivier <[email protected]>; Michael S . Tsirkin <[email protected]>
Subject: [PATCH] tests/qtest/cxl-test: Remove temporary directories after testing

The cxl-test leaves some temporary directories behind. Let's clean them up now!

Quoted 7 lines
Quoted 1 line

LGTM.

Thanks
Chen

Oops.

Quoted 37 lines
Quoted 36 lines
---
 tests/qtest/cxl-test.c | 3 +++
 1 file changed, 3 insertions(+)
tests/qtest/cxl-test.c index renamed from tests/qtest/cxl-test.c +0 -0

cbe0fb549b..61f25a72b6 100644

tests/qtest/cxl-test.c +3 -1
@@ -101,6 +101,7 @@ static void cxl_t3d(void)
 
     qtest_start(cmdline->str);
     qtest_end();
+    rmdir(tmpfs);
 }
 
 static void cxl_1pxb_2rp_2t3d(void)
@@ -115,6 +116,7 @@ static void cxl_1pxb_2rp_2t3d(void)
 
     qtest_start(cmdline->str);
     qtest_end();
+    rmdir(tmpfs);
 }
 
 static void cxl_2pxb_4rp_4t3d(void)
@@ -130,6 +132,7 @@ static void cxl_2pxb_4rp_4t3d(void)
 
     qtest_start(cmdline->str);
     qtest_end();
+    rmdir(tmpfs);
 }
 #endif /* CONFIG_POSIX */
 
--

2.31.1