Skip to contentSkip to conversation

fbdev: MIPS supports iomem addresses

PATCH Applied Kees Cook 2 participants 2 messages Oct 12, 2022 – Oct 13, 2022 Framebuffer layer

lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 fbdev: MIPS supports iomem addresses

Add MIPS to fb_* helpers list for iomem addresses. This silences Sparse warnings about lacking __iomem address space casts:

drivers/video/fbdev/pvr2fb.c:800:9: sparse: sparse: incorrect type in argument 1 (different address spaces)
drivers/video/fbdev/pvr2fb.c:800:9: sparse: expected void const *
drivers/video/fbdev/pvr2fb.c:800:9: sparse: got char [noderef] __iomem *screen_base

---
 include/linux/fb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/fb.h +1 -1
index 07fcd0e56682..3822734a38c7 100644
@@ -555,7 +555,7 @@ static inline struct apertures_struct *alloc_apertures(unsigned int max_num) {
 
 #elif defined(__i386__) || defined(__alpha__) || defined(__x86_64__) ||	\
 	defined(__hppa__) || defined(__sh__) || defined(__powerpc__) ||	\
-	defined(__arm__) || defined(__aarch64__)
+	defined(__arm__) || defined(__aarch64__) || defined(__mips__)
 
 #define fb_readb __raw_readb
 #define fb_readw __raw_readw
Signature · 1 line
2.34.1
maintainer Applied
#1 lore raw
Quoted 7 lines · Kees Cook

Add MIPS to fb_* helpers list for iomem addresses. This silences Sparse warnings about lacking __iomem address space casts:

drivers/video/fbdev/pvr2fb.c:800:9: sparse: sparse: incorrect type in argument 1 (different address spaces)
drivers/video/fbdev/pvr2fb.c:800:9: sparse: expected void const *
drivers/video/fbdev/pvr2fb.c:800:9: sparse: got char [noderef] __iomem *screen_base

Quoted 6 lines

applied to fbdev git tree.

Thanks!
Helge

Quoted 17 lines
---
  include/linux/fb.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/fb.h +1 -1
index 07fcd0e56682..3822734a38c7 100644
@@ -555,7 +555,7 @@ static inline struct apertures_struct *alloc_apertures(unsigned int max_num) {
 
  #elif defined(__i386__) || defined(__alpha__) || defined(__x86_64__) ||	\
  	defined(__hppa__) || defined(__sh__) || defined(__powerpc__) ||	\
-	defined(__arm__) || defined(__aarch64__)
+	defined(__arm__) || defined(__aarch64__) || defined(__mips__)
 
  #define fb_readb __raw_readb
  #define fb_readw __raw_readw