Skip to contentSkip to conversation

drm/panel/panel-sitronix-st7701: Remove panel on DSI attach failure

PATCH In review Marek Vasut 2 participants 2 messages Oct 14, 2022 – Nov 1, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/panel/panel-sitronix-st7701: Remove panel on DSI attach failure

In case mipi_dsi_attach() fails, call drm_panel_remove() to avoid memory leak.

Fixes 849b2e3ff9698 ("drm/panel: Add Sitronix ST7701 panel driver")

---
Cc: Guido Günther <[email protected]>
Cc: Jagan Teki <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: Thierry Reding <[email protected]>

---
 drivers/gpu/drm/panel/panel-sitronix-st7701.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/gpu/drm/panel/panel-sitronix-st7701.c +9 -1
index baeb952b6e244..0b8cf65172ff7 100644
@@ -754,7 +754,15 @@ static int st7701_dsi_probe(struct mipi_dsi_device *dsi)
 	st7701->dsi = dsi;
 	st7701->desc = desc;
 
-	return mipi_dsi_attach(dsi);
+	ret = mipi_dsi_attach(dsi);
+	if (ret)
+		goto err_attach;
+
+	return 0;
+
+err_attach:
+	drm_panel_remove(&st7701->panel);
+	return ret;
 }
 
 static void st7701_dsi_remove(struct mipi_dsi_device *dsi)
Signature · 1 line
2.35.1
#1 lore raw
Quoted 4 lines · Marek Vasut

In case mipi_dsi_attach() fails, call drm_panel_remove() to avoid memory leak.

Fixes 849b2e3ff9698 ("drm/panel: Add Sitronix ST7701 panel driver")

Patch applied, fixed up some complaints from checkpatch.

Yours,
Linus Walleij