Skip to contentSkip to conversation

drm/i915: Replace kmap() with kmap_local_page()

PATCH RESEND Superseded Fabio M. De Francesco 2 participants 10 messages Oct 16, 2022 – Nov 1, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover drm/i915: Replace kmap() with kmap_local_page()

kmap() is being deprecated in favor of kmap_local_page().

There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it might block when the mapping space is fully utilized until a slot becomes available.

With kmap_local_page() the mappings are per thread, CPU local, can take page faults, and can be called from any context (including interrupts). It is faster than kmap() in kernels with HIGHMEM enabled. Furthermore, the tasks can be preempted and, when they are scheduled to run again, the kernel virtual addresses are restored and still valid.

Since its use in drm/i915 is safe everywhere, it should be preferred.

Therefore, replace kmap() with kmap_local_page() in drm/i915.

These changes should be tested in an 32 bits system, booting a kernel with HIGHMEM enabled. Unfortunately I have no i915 based hardware, therefore any help with testing would be greatly appreciated.

I'm resending this little series because I suspect that it has been lost, since it was submitted on Aug 11, 2022. In the meantime I'm adding one more recipient (Anirudh) who is helping, along with others, Ira and me with these conversions / removals of kmap() and kmap_atomic()

Fabio M. De Francesco (3):
drm/i915: Replace kmap() with kmap_local_page() drm/i915/gt: Replace kmap() with kmap_local_page() drm/i915/gem: Replace kmap() with kmap_local_page()

 drivers/gpu/drm/i915/gem/i915_gem_shmem.c          |  6 ++----
 drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c |  8 ++++----
 drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c       |  4 ++--
 drivers/gpu/drm/i915/gt/shmem_utils.c              | 11 ++++-------
 drivers/gpu/drm/i915/i915_gem.c                    |  8 ++++----
 5 files changed, 16 insertions(+), 21 deletions(-)
Signature · 1 line
2.37.1
#1 lore raw

PATCH RESEND 1/3 drm/i915: Replace kmap() with kmap_local_page()

kmap() is being deprecated in favor of kmap_local_page().

There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it might block when the mapping space is fully utilized until a slot becomes available.

With kmap_local_page() the mappings are per thread, CPU local, can take page faults, and can be called from any context (including interrupts). It is faster than kmap() in kernels with HIGHMEM enabled. Furthermore, the tasks can be preempted and, when they are scheduled to run again, the kernel virtual addresses are restored and are still valid.

Since its use in i915_gem.c is safe everywhere, it should be preferred.

Therefore, replace kmap() with kmap_local_page() in i915_gem.c

---
 drivers/gpu/drm/i915/i915_gem.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +4 -4
index 702e5b89be22..43effce60e1b 100644
@@ -212,14 +212,14 @@ shmem_pread(struct page *page, int offset, int len, char __user *user_data,
 	char *vaddr;
 	int ret;
 
-	vaddr = kmap(page);
+	vaddr = kmap_local_page(page);
 
 	if (needs_clflush)
 		drm_clflush_virt_range(vaddr + offset, len);
 
 	ret = __copy_to_user(user_data, vaddr + offset, len);
 
-	kunmap(page);
+	kunmap_local(vaddr);
 
 	return ret ? -EFAULT : 0;
 }
@@ -634,7 +634,7 @@ shmem_pwrite(struct page *page, int offset, int len, char __user *user_data,
 	char *vaddr;
 	int ret;
 
-	vaddr = kmap(page);
+	vaddr = kmap_local_page(page);
 
 	if (needs_clflush_before)
 		drm_clflush_virt_range(vaddr + offset, len);
@@ -643,7 +643,7 @@ shmem_pwrite(struct page *page, int offset, int len, char __user *user_data,
 	if (!ret && needs_clflush_after)
 		drm_clflush_virt_range(vaddr + offset, len);
 
-	kunmap(page);
+	kunmap_local(vaddr);
 
 	return ret ? -EFAULT : 0;
 }
Signature · 1 line
2.37.1
#2 lore raw

PATCH RESEND 2/3 drm/i915/gt: Replace kmap() with kmap_local_page()

In reply to Fabio M. De Francesco

kmap() is being deprecated in favor of kmap_local_page().

There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it might block when the mapping space is fully utilized until a slot becomes available.

With kmap_local_page() the mappings are per thread, CPU local, can take page faults, and can be called from any context (including interrupts). It is faster than kmap() in kernels with HIGHMEM enabled. Furthermore, the tasks can be preempted and, when they are scheduled to run again, the kernel virtual addresses are restored and are still valid.

Since its use in i915/gt is safe everywhere, it should be preferred.

Therefore, replace kmap() with kmap_local_page() in i915/gt. Instead of open-coding local mappings + memcpy() + local unmappings, use the memcpy_{from,to}_page() helpers where these are better suited.

---
 drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c |  4 ++--
 drivers/gpu/drm/i915/gt/shmem_utils.c        | 11 ++++-------
 2 files changed, 6 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +2 -2
index 6ebda3d65086..21d8ce40b897 100644
@@ -747,7 +747,7 @@ static void swizzle_page(struct page *page)
 	char *vaddr;
 	int i;
 
-	vaddr = kmap(page);
+	vaddr = kmap_local_page(page);
 
 	for (i = 0; i < PAGE_SIZE; i += 128) {
 		memcpy(temp, &vaddr[i], 64);
@@ -755,7 +755,7 @@ static void swizzle_page(struct page *page)
 		memcpy(&vaddr[i + 64], temp, 64);
 	}
 
-	kunmap(page);
+	kunmap_local(vaddr);
 }
 
 /**
drivers/gpu/drm/i915/gt/shmem_utils.c +4 -7
index 402f085f3a02..48edbb8a33e5 100644
@@ -98,22 +98,19 @@ static int __shmem_rw(struct file *file, loff_t off,
 		unsigned int this =
 			min_t(size_t, PAGE_SIZE - offset_in_page(off), len);
 		struct page *page;
-		void *vaddr;
 
 		page = shmem_read_mapping_page_gfp(file->f_mapping, pfn,
 						   GFP_KERNEL);
 		if (IS_ERR(page))
 			return PTR_ERR(page);
 
-		vaddr = kmap(page);
 		if (write) {
-			memcpy(vaddr + offset_in_page(off), ptr, this);
+			memcpy_to_page(page, offset_in_page(off), ptr, this);
 			set_page_dirty(page);
 		} else {
-			memcpy(ptr, vaddr + offset_in_page(off), this);
+			memcpy_from_page(ptr, page, offset_in_page(off), this);
 		}
 		mark_page_accessed(page);
-		kunmap(page);
 		put_page(page);
 
 		len -= this;
@@ -140,11 +137,11 @@ int shmem_read_to_iosys_map(struct file *file, loff_t off,
 		if (IS_ERR(page))
 			return PTR_ERR(page);
 
-		vaddr = kmap(page);
+		vaddr = kmap_local_page(page);
 		iosys_map_memcpy_to(map, map_off, vaddr + offset_in_page(off),
 				    this);
 		mark_page_accessed(page);
-		kunmap(page);
+		kunmap_local(vaddr);
 		put_page(page);
 
 		len -= this;
Signature · 1 line
2.37.1
#3 lore raw

PATCH RESEND 3/3 drm/i915/gem: Replace kmap() with kmap_local_page()

In reply to Fabio M. De Francesco

kmap() is being deprecated in favor of kmap_local_page().

There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it might block when the mapping space is fully utilized until a slot becomes available.

With kmap_local_page() the mappings are per thread, CPU local, can take page faults, and can be called from any context (including interrupts). It is faster than kmap() in kernels with HIGHMEM enabled. Furthermore, the tasks can be preempted and, when they are scheduled to run again, the kernel virtual addresses are restored and are still valid.

Since its use in i915/gem is safe everywhere, it should be preferred.

Therefore, replace kmap() with kmap_local_page() in i915/gem. Instead of open-coding local map + memcpy + local unmap, use memcpy_to_page() in a suited call site.

---
 drivers/gpu/drm/i915/gem/i915_gem_shmem.c          | 6 ++----
 drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 ++++----
 2 files changed, 6 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_shmem.c +2 -4
index 4eed3dd90ba8..2bc6ab9964ff 100644
@@ -640,16 +640,14 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_private *dev_priv,
 	do {
 		unsigned int len = min_t(typeof(size), size, PAGE_SIZE);
 		struct page *page;
-		void *pgdata, *vaddr;
+		void *pgdata;
 
 		err = aops->write_begin(file, file->f_mapping, offset, len,
 					&page, &pgdata);
 		if (err < 0)
 			goto fail;
 
-		vaddr = kmap(page);
-		memcpy(vaddr, data, len);
-		kunmap(page);
+		memcpy_to_page(page, 0, data, len);
 
 		err = aops->write_end(file, file->f_mapping, offset, len, len,
 				      page, pgdata);
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +4 -4
index 3ced9948a331..bb25b50b5688 100644
@@ -153,7 +153,7 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj,
 	intel_gt_flush_ggtt_writes(to_gt(i915));
 
 	p = i915_gem_object_get_page(obj, offset >> PAGE_SHIFT);
-	cpu = kmap(p) + offset_in_page(offset);
+	cpu = kmap_local_page(p) + offset_in_page(offset);
 	drm_clflush_virt_range(cpu, sizeof(*cpu));
 	if (*cpu != (u32)page) {
 		pr_err("Partial view for %lu [%u] (offset=%llu, size=%u [%llu, row size %u], fence=%d, tiling=%d, stride=%d) misalignment, expected write to page (%llu + %u [0x%llx]) of 0x%x, found 0x%x\n",
@@ -171,7 +171,7 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj,
 	}
 	*cpu = 0;
 	drm_clflush_virt_range(cpu, sizeof(*cpu));
-	kunmap(p);
+	kunmap_local(cpu);
 
 out:
 	i915_gem_object_lock(obj, NULL);
@@ -249,7 +249,7 @@ static int check_partial_mappings(struct drm_i915_gem_object *obj,
 		intel_gt_flush_ggtt_writes(to_gt(i915));
 
 		p = i915_gem_object_get_page(obj, offset >> PAGE_SHIFT);
-		cpu = kmap(p) + offset_in_page(offset);
+		cpu = kmap_local_page(p) + offset_in_page(offset);
 		drm_clflush_virt_range(cpu, sizeof(*cpu));
 		if (*cpu != (u32)page) {
 			pr_err("Partial view for %lu [%u] (offset=%llu, size=%u [%llu, row size %u], fence=%d, tiling=%d, stride=%d) misalignment, expected write to page (%llu + %u [0x%llx]) of 0x%x, found 0x%x\n",
@@ -267,7 +267,7 @@ static int check_partial_mappings(struct drm_i915_gem_object *obj,
 		}
 		*cpu = 0;
 		drm_clflush_virt_range(cpu, sizeof(*cpu));
-		kunmap(p);
+		kunmap_local(cpu);
 		if (err)
 			return err;
 
Signature · 1 line
2.37.1
#5 lore raw

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Replace kmap() with kmap_local_page() (rev2)

Quoted 11 lines · On lunedì 17 ottobre 2022 22:23:30 CET Patchwork wrote:

== Series Details ==

Series: drm/i915: Replace kmap() with kmap_local_page() (rev2)
URL : https://patchwork.freedesktop.org/series/107277/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.

I received this and other messages with regards to the same series, however, after due inspection of my patches, I haven't yet been able to understand what these reports may mean or even if they are reporting bugs.

Can anyone please provide any help?

Thanks,

Fabio

P.S.: Similar requests for the other messages will follow ASAP.

#6 lore raw

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Replace kmap() with kmap_local_page() (rev2)

In reply to Patchwork
Quoted 11 lines · On lunedì 17 ottobre 2022 22:23:30 CET Patchwork wrote:

== Series Details ==

Series: drm/i915: Replace kmap() with kmap_local_page() (rev2)
URL : https://patchwork.freedesktop.org/series/107277/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.

I received this and other messages with regards to the same series, however, after due inspection of my patches, I haven't yet been able to understand what these reports may mean or even if they are reporting bugs.

Can anyone please provide any help?

Thanks,

Fabio

P.S.: Similar requests for the other messages will follow ASAP.

#7 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Replace kmap() with kmap_local_page() (rev2)

In reply to Fabio M. De Francesco
== Series Details ==

== Series Details ==

Series: drm/i915: Replace kmap() with kmap_local_page() (rev2)
URL : https://patchwork.freedesktop.org/series/107277/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12252 -> Patchwork_107277v2
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/index.html

Participating hosts (46 -> 43)
------------------------------

Additional (1): fi-icl-u2
Missing (4): fi-bxt-dsi fi-cfl-8700k bat-atsm-1 fi-bdw-samus

Known issues
------------

Here are the changes found in Patchwork_107277v2 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][1] -> [FAIL][2] ([i915#7229])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/fi-pnv-d510/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/fi-pnv-d510/igt@[email protected]

* igt@gem_linear_blits@basic:
- fi-pnv-d510: [PASS][3] -> [SKIP][4] ([fdo#109271])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/fi-pnv-d510/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/fi-pnv-d510/igt@[email protected]

* igt@runner@aborted:
- fi-icl-u2: NOTRUN -> [FAIL][5] ([i915#7220])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/fi-icl-u2/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#7220]: https://gitlab.freedesktop.org/drm/intel/issues/7220
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229

Build changes
-------------

* Linux: CI_DRM_12252 -> Patchwork_107277v2

CI-20190529: 20190529
CI_DRM_12252: 14867082ef288af10c90732e31b633af30e304c0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7017: 193c8bdd7df32556129482c52011e1b7a233b699 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107277v2: 14867082ef288af10c90732e31b633af30e304c0 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

83c34dd3b2a2 drm/i915/gem: Replace kmap() with kmap_local_page() ade39e0c9963 drm/i915/gt: Replace kmap() with kmap_local_page() cd89efceb13c drm/i915: Replace kmap() with kmap_local_page()

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/index.html

#8 lore raw

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Replace kmap() with kmap_local_page() (rev2)

Quoted 11 lines · On lunedì 17 ottobre 2022 22:34:44 CET Patchwork wrote:

== Series Details ==

Series: drm/i915: Replace kmap() with kmap_local_page() (rev2)
URL : https://patchwork.freedesktop.org/series/107277/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12252 -> Patchwork_107277v2
====================================================

Quoted 8 lines

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/

index.html

Quoted 11 lines

Participating hosts (46 -> 43)
------------------------------

Additional (1): fi-icl-u2
Missing (4): fi-bxt-dsi fi-cfl-8700k bat-atsm-1 fi-bdw-samus

Known issues
------------

Here are the changes found in Patchwork_107277v2 that come from known

issues:

Quoted 9 lines

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][1] -> [FAIL][2] ([i915#7229])
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/fi-pnv-d510/

igt@gem_exec_gttfill@

Quoted 2 lines

basic.html [2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/fi-pnv-d510/

igt@gem_exec_gt

Quoted 6 lines

[email protected]

* igt@gem_linear_blits@basic:
- fi-pnv-d510: [PASS][3] -> [SKIP][4] ([fdo#109271])
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/fi-pnv-d510/

igt@gem_linear_blits@

Quoted 2 lines

basic.html [4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/fi-pnv-d510/

igt@gem_linear_

Quoted 6 lines

[email protected]

* igt@runner@aborted:
- fi-icl-u2: NOTRUN -> [FAIL][5] ([i915#7220])
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/fi-icl-u2/

igt@runner@aborte

Quoted 11 lines

d.html

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#7220]: https://gitlab.freedesktop.org/drm/intel/issues/7220
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229

Build changes
-------------

Quoted 8 lines

* Linux: CI_DRM_12252 -> Patchwork_107277v2

CI-20190529: 20190529
CI_DRM_12252: 14867082ef288af10c90732e31b633af30e304c0 @
git://anongit.freedesktop.org/gfx-ci/linux IGT_7017:
193c8bdd7df32556129482c52011e1b7a233b699 @
https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_107277v2:
14867082ef288af10c90732e31b633af30e304c0 @ git://anongit.freedesktop.org/

gfx-ci/linux

Quoted 4 lines

### Linux commits

Quoted 8 lines

83c34dd3b2a2 drm/i915/gem: Replace kmap() with kmap_local_page() ade39e0c9963 drm/i915/gt: Replace kmap() with kmap_local_page() cd89efceb13c drm/i915: Replace kmap() with kmap_local_page()

== Logs ==

For more details see:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/index.html

This is the second of the three messages with regards to the same series. My kind request is the same of the previous...

Can anyone please provide any help?

Thanks,

Fabio

#9 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Replace kmap() with kmap_local_page() (rev2)

In reply to Fabio M. De Francesco
== Series Details ==

== Series Details ==

Series: drm/i915: Replace kmap() with kmap_local_page() (rev2)
URL : https://patchwork.freedesktop.org/series/107277/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12252_full -> Patchwork_107277v2_full
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with Patchwork_107277v2_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_107277v2_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (12 -> 11)
------------------------------

Missing (1): shard-tglu

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_107277v2_full:

### IGT changes ###

#### Warnings ####

* igt@gem_eio@in-flight-suspend:
- shard-apl: [INCOMPLETE][1] ([i915#7112]) -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/shard-apl6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/shard-apl8/igt@[email protected]

* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [INCOMPLETE][3] ([i915#7231]) -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/shard-apl1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/shard-apl6/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_107277v2_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_endless@dispatch@vecs0:
- shard-tglb: NOTRUN -> [INCOMPLETE][5] ([i915#3778])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/shard-tglb2/igt@gem_exec_endless@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/shard-tglb1/igt@gem_exec_fair@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/shard-tglb1/igt@gem_exec_fair@[email protected]

* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-apl: NOTRUN -> [INCOMPLETE][8] ([i915#7241])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/shard-apl1/igt@[email protected]

* igt@i915_selftest@mock@requests:
- shard-tglb: [PASS][9] -> [INCOMPLETE][10] ([i915#7226])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/shard-tglb1/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/shard-tglb1/igt@i915_selftest@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@b-edp1:
- shard-tglb: [PASS][11] -> [DMESG-WARN][12] ([i915#2867])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/shard-tglb7/igt@kms_flip@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/shard-tglb2/igt@kms_flip@[email protected]

* igt@kms_force_connector_basic@force-edid:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/shard-apl1/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_endless@dispatch@bcs0:
- shard-tglb: [INCOMPLETE][14] ([i915#3778]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/shard-tglb7/igt@gem_exec_endless@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/shard-tglb2/igt@gem_exec_endless@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][16] ([i915#2842]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/shard-tglb1/igt@gem_exec_fair@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/shard-tglb7/igt@gem_exec_fair@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-tglb: [FAIL][18] ([i915#3743]) -> [PASS][19] +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/shard-tglb2/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/shard-tglb1/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html

#### Warnings ####

* igt@gem_pwrite@basic-exhaustion:
- shard-apl: [INCOMPLETE][20] -> [WARN][21] ([i915#2658])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/shard-apl6/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/shard-apl6/igt@[email protected]

* igt@gem_softpin@noreloc-s3:
- shard-apl: [INCOMPLETE][22] -> [INCOMPLETE][23] ([i915#7236])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/shard-apl2/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/shard-apl1/igt@[email protected]

* igt@i915_suspend@forcewake:
- shard-apl: [INCOMPLETE][24] ([i915#7228]) -> [INCOMPLETE][25] ([i915#4817] / [i915#7228])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/shard-apl1/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/shard-apl6/igt@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-apl: [INCOMPLETE][26] ([i915#7233]) -> [INCOMPLETE][27] ([i915#4817] / [i915#7233])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12252/shard-apl7/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/shard-apl3/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#7112]: https://gitlab.freedesktop.org/drm/intel/issues/7112
[i915#7226]: https://gitlab.freedesktop.org/drm/intel/issues/7226
[i915#7228]: https://gitlab.freedesktop.org/drm/intel/issues/7228
[i915#7231]: https://gitlab.freedesktop.org/drm/intel/issues/7231
[i915#7233]: https://gitlab.freedesktop.org/drm/intel/issues/7233
[i915#7236]: https://gitlab.freedesktop.org/drm/intel/issues/7236
[i915#7241]: https://gitlab.freedesktop.org/drm/intel/issues/7241

Build changes
-------------

* Linux: CI_DRM_12252 -> Patchwork_107277v2

CI-20190529: 20190529
CI_DRM_12252: 14867082ef288af10c90732e31b633af30e304c0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7017: 193c8bdd7df32556129482c52011e1b7a233b699 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107277v2: 14867082ef288af10c90732e31b633af30e304c0 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107277v2/index.html