drm/i915: fix clear mask in GEN7_MISCCPCTL update
Subsystems (2)
PATCH 1/1 drm/i915: fix clear mask in GEN7_MISCCPCTL update
GEN7_DOP_CLOCK_GATE_ENABLE bit should be cleared, not inverse. The bug was introduced during conversion to intel_uncore_rmw helper.
--- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_irq.c +2 -2
@@ -1052,8 +1052,8 @@ static void ivb_parity_work(struct work_struct *work)if (drm_WARN_ON (&dev_priv->drm, !dev_priv->l3_parity.which_slice)) goto out; - misccpctl =intel_uncore_rmw (&dev_priv->uncore,GEN7_MISCCPCTL , ~GEN7_DOP_CLOCK_GATE_ENABLE , -0 ); + misccpctl =intel_uncore_rmw (&dev_priv->uncore,GEN7_MISCCPCTL , +GEN7_DOP_CLOCK_GATE_ENABLE ,0 );intel_uncore_posting_read (&dev_priv->uncore,GEN7_MISCCPCTL );while ((slice =ffs (dev_priv->l3_parity.which_slice)) !=0 ) {
drivers/gpu/drm/i915/intel_pm.c +2 -2
@@ -4321,8 +4321,8 @@ static void gen8_set_l3sqc_credits(struct drm_i915_private *dev_priv,u32 val;/* WaTempDisableDOPClkGating:bdw */ - misccpctl =intel_uncore_rmw (&dev_priv->uncore,GEN7_MISCCPCTL , ~GEN7_DOP_CLOCK_GATE_ENABLE , -0 ); + misccpctl =intel_uncore_rmw (&dev_priv->uncore,GEN7_MISCCPCTL , +GEN7_DOP_CLOCK_GATE_ENABLE ,0 ); val =intel_uncore_read (&dev_priv->uncore,GEN8_L3SQCREG1 ); val &= ~L3_PRIO_CREDITS_MASK ;
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: fix clear mask in GEN7_MISCCPCTL update
== Series Details ==
== Series Details ==
Series: drm/i915: fix clear mask in GEN7_MISCCPCTL update
URL : https://patchwork.freedesktop.org/series/109757/
State : warning
== Summary ==
Error: dim checkpatch failed106f0266654c drm/i915: fix clear mask in GEN7_MISCCPCTL update
-:10: WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 8cee664d3eb6 ("drm/i915: use proper helper for register updates")' #10:
total: 0 errors, 1 warnings, 0 checks, 20 lines checked
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix clear mask in GEN7_MISCCPCTL update
In reply to Andrzej Hajda== Series Details ==
== Series Details ==
Series: drm/i915: fix clear mask in GEN7_MISCCPCTL update
URL : https://patchwork.freedesktop.org/series/109757/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12251 -> Patchwork_109757v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/index.html
Participating hosts (44 -> 44)
------------------------------
Additional (2): fi-hsw-4770 fi-rkl-11600
Missing (2): fi-bdw-samus fi-elk-e7500
Known issues
------------
Here are the changes found in Patchwork_109757v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_tiled_blits@basic:
- fi-pnv-d510: [PASS][1] -> [SKIP][2] ([fdo#109271]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/fi-pnv-d510/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/fi-pnv-d510/igt@[email protected]
* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#3012])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/fi-hsw-4770/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-hsw-4770: NOTRUN -> [INCOMPLETE][4] ([i915#7221])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/fi-hsw-4770/igt@[email protected]
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- fi-hsw-4770: NOTRUN -> [SKIP][5] ([fdo#109271]) +9 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/fi-hsw-4770/igt@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- fi-hsw-4770: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827]) +7 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/fi-hsw-4770/igt@[email protected]
* igt@kms_psr@sprite_plane_onoff:
- fi-hsw-4770: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1072]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/fi-hsw-4770/igt@kms_psr@sprite_plane_onoff.html
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][8] ([fdo#109271] / [i915#4312] / [i915#5594])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/fi-hsw-4770/igt@[email protected]
- fi-rkl-11600: NOTRUN -> [FAIL][9] ([i915#7220])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/fi-rkl-11600/igt@[email protected]
#### Possible fixes ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [FAIL][10] ([i915#6298]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
#### Warnings ####
* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-gvtdvm: [FAIL][12] ([fdo#103375]) -> [INCOMPLETE][13] ([i915#146])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/fi-bdw-gvtdvm/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/fi-bdw-gvtdvm/igt@[email protected]
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#7220]: https://gitlab.freedesktop.org/drm/intel/issues/7220
[i915#7221]: https://gitlab.freedesktop.org/drm/intel/issues/7221
Build changes
-------------
* Linux: CI_DRM_12251 -> Patchwork_109757v1
CI-20190529: 20190529
CI_DRM_12251: ff61e79b01712f5d31a4c4f23c6971bbaa71cecb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7016: 642f4bf44e2b42791b4d1684936a1bfbe2d099ee @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109757v1: ff61e79b01712f5d31a4c4f23c6971bbaa71cecb @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
5d11dffb7f68 drm/i915: fix clear mask in GEN7_MISCCPCTL update
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: fix clear mask in GEN7_MISCCPCTL update
In reply to Andrzej Hajda== Series Details ==
== Series Details ==
Series: drm/i915: fix clear mask in GEN7_MISCCPCTL update
URL : https://patchwork.freedesktop.org/series/109757/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12251_full -> Patchwork_109757v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_109757v1_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_109757v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (12 -> 12)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_109757v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@reload-with-fault-injection:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-tglb7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-tglb2/igt@[email protected]
* igt@i915_suspend@debugfs-reader:
- shard-apl: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-apl7/igt@[email protected]
#### Warnings ####
* igt@gem_eio@in-flight-suspend:
- shard-apl: [INCOMPLETE][4] ([i915#7112]) -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-apl2/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-apl3/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_109757v1_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-snb: ([PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [FAIL][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30]) ([i915#4338]) -> ([PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb7/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb7/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb6/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb6/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb6/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb5/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb5/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb5/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb5/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb5/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb5/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb4/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb4/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb4/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb4/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb4/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb2/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb2/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb2/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb2/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb2/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb7/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb7/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb7/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb7/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb7/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb6/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb6/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb6/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb6/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb6/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb5/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb5/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb5/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb5/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb5/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb4/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb4/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb4/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb4/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb2/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb2/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb2/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb2/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb2/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_sseu@mmap-args:
- shard-tglb: NOTRUN -> [SKIP][56] ([i915#280])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-tglb1/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-tglb: [PASS][57] -> [FAIL][58] ([i915#2846])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-tglb5/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-tglb1/igt@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][59] -> [FAIL][60] ([i915#2842])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-tglb1/igt@gem_exec_fair@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-tglb1/igt@gem_exec_fair@[email protected]
* igt@kms_big_fb@4-tiled-8bpp-rotate-180:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271]) +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-apl7/igt@[email protected]
* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-snb: NOTRUN -> [SKIP][62] ([fdo#109271] / [fdo#111827]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-cpu:
- shard-tglb: NOTRUN -> [SKIP][63] ([fdo#109280] / [fdo#111825])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_rotation_crc@bad-pixel-format:
- shard-snb: NOTRUN -> [SKIP][64] ([fdo#109271]) +79 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb7/igt@[email protected]
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-snb: NOTRUN -> [FAIL][65] ([fdo#103375]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb7/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@mock@requests:
- shard-snb: [DMESG-FAIL][66] -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb4/igt@i915_selftest@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb7/igt@i915_selftest@[email protected]
- shard-tglb: [INCOMPLETE][68] ([i915#7226]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-tglb5/igt@i915_selftest@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-tglb1/igt@i915_selftest@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-tglb: [FAIL][70] ([i915#3743]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-tglb1/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-tglb5/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-pwrite:
- shard-snb: [SKIP][72] ([fdo#109271]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-snb2/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-snb4/igt@[email protected]
#### Warnings ####
* igt@gem_pwrite@basic-exhaustion:
- shard-tglb: [INCOMPLETE][74] -> [WARN][75] ([i915#2658])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12251/shard-tglb7/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/shard-tglb2/igt@[email protected]
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#4338]: https://gitlab.freedesktop.org/drm/intel/issues/4338
[i915#7112]: https://gitlab.freedesktop.org/drm/intel/issues/7112
[i915#7226]: https://gitlab.freedesktop.org/drm/intel/issues/7226
Build changes
-------------
* Linux: CI_DRM_12251 -> Patchwork_109757v1
CI-20190529: 20190529
CI_DRM_12251: ff61e79b01712f5d31a4c4f23c6971bbaa71cecb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7016: 642f4bf44e2b42791b4d1684936a1bfbe2d099ee @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109757v1: ff61e79b01712f5d31a4c4f23c6971bbaa71cecb @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109757v1/index.html
Quoted 6 lines · Andrzej Hajda
GEN7_DOP_CLOCK_GATE_ENABLEbit should be cleared, not inverse. The bug was introduced during conversion tointel_uncore_rmwhelper.Suggested-by Matt Roper <[email protected]>Fixes 8cee664d3eb6f8 ("drm/i915: use proper helper for register updates")Signed-off-by Andrzej Hajda <[email protected]>
Lucas De Marchi
Quoted 10 lines · Lucas De Marchi
Quoted 6 lines · Andrzej Hajda
GEN7_DOP_CLOCK_GATE_ENABLEbit should be cleared, not inverse. The bug was introduced during conversion tointel_uncore_rmwhelper.Suggested-by Matt Roper <[email protected]>Fixes 8cee664d3eb6f8 ("drm/i915: use proper helper for register updates")Signed-off-by Andrzej Hajda <[email protected]>Reviewed-by Lucas De Marchi <[email protected]>
and pushed
thanks
Lucas De Marchi
Quoted 6 lines · Andrzej Hajda
GEN7_DOP_CLOCK_GATE_ENABLEbit should be cleared, not inverse. The bug was introduced during conversion tointel_uncore_rmwhelper.Suggested-by Matt Roper <[email protected]>Fixes 8cee664d3eb6f8 ("drm/i915: use proper helper for register updates")Signed-off-by Andrzej Hajda <[email protected]>
Quoted 38 lines
--- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/i915_irq.c +2
-2@@ -1052,8 +1052,8 @@ static void ivb_parity_work(struct work_struct *work)if (drm_WARN_ON (&dev_priv->drm, !dev_priv->l3_parity.which_slice)) goto out; - misccpctl =intel_uncore_rmw (&dev_priv->uncore,GEN7_MISCCPCTL , ~GEN7_DOP_CLOCK_GATE_ENABLE , -0 ); + misccpctl =intel_uncore_rmw (&dev_priv->uncore,GEN7_MISCCPCTL , +GEN7_DOP_CLOCK_GATE_ENABLE ,0 );intel_uncore_posting_read (&dev_priv->uncore,GEN7_MISCCPCTL );while ((slice =ffs (dev_priv->l3_parity.which_slice)) !=0 ) {drivers/gpu/drm/i915/intel_pm.c +2
-2@@ -4321,8 +4321,8 @@ static void gen8_set_l3sqc_credits(struct drm_i915_private *dev_priv,u32 val;/* WaTempDisableDOPClkGating:bdw */ - misccpctl =intel_uncore_rmw (&dev_priv->uncore,GEN7_MISCCPCTL , ~GEN7_DOP_CLOCK_GATE_ENABLE , -0 ); + misccpctl =intel_uncore_rmw (&dev_priv->uncore,GEN7_MISCCPCTL , +GEN7_DOP_CLOCK_GATE_ENABLE ,0 ); val =intel_uncore_read (&dev_priv->uncore,GEN8_L3SQCREG1 ); val &= ~L3_PRIO_CREDITS_MASK ;Signature · 1 line
2.34.1
Signature · 4 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation