tests/i915/query: sanity check reported GTT alignment
PATCH 1/2 tests/i915/query: sanity check reported GTT alignment
Ensure the kernel is reporting "normal" values here, based on our current expectations.
--- tests/i915/i915_query.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
tests/i915/i915_query.c +10 -0
@@ -638,6 +638,8 @@ static void upload(int fd, struct igt_list_head *handles, uint32_t num_handles)free (exec); } +/** XXX: remove once we sync the uapi header */ +#define gtt_alignment rsvd0static void test_query_regions_sanity_check (int fd) {struct drm_i915_query_memory_regions *regions;
@@ -664,6 +666,11 @@ static void test_query_regions_sanity_check(int fd)struct drm_i915_gem_memory_class_instance r1 = info.region;int j; +if (info.gtt_alignment) { +igt_assert_lte_u64 (4096 , info.gtt_alignment); +igt_assert (is_power_of_two (info.gtt_alignment)); + } +if (r1.memory_class ==I915_MEMORY_CLASS_SYSTEM ) {igt_assert_eq (r1.memory_instance,0 ); found_system = true;
@@ -674,6 +681,9 @@ static void test_query_regions_sanity_check(int fd)igt_assert (info.unallocated_cpu_visible_size ==0 || info.unallocated_cpu_visible_size == info.unallocated_size); + +igt_assert (info.gtt_alignment ==0 || + info.gtt_alignment ==4096 ); }else {igt_assert (info.probed_cpu_visible_size <= info.probed_size);igt_assert (info.unallocated_size <= info.probed_size);
Signature · 1 line
2.37.3
PATCH 2/2 tests/i915/gem_create: add some basic testing for GTT alignment
Make sure we can always place an object at some GTT address, so long as we adhere to the min GTT alignment for the given region.
--- tests/i915/gem_create.c | 117 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 117 insertions(+)
tests/i915/gem_create.c +117 -0
@@ -822,6 +822,115 @@ static void create_ext_cpu_access_big(int fd)free (regions); } +/** XXX: remove once we sync the uapi header */ +#define gtt_alignment rsvd0 +static bool supports_gtt_alignment (int fd) +{ +struct drm_i915_query_memory_regions *regions; +uint32_t gtt_alignment; + + regions =gem_get_query_memory_regions (fd); +igt_assert (regions); +igt_assert (regions->num_regions); + + gtt_alignment = regions->regions[0 ].gtt_alignment; +free (regions); + +return gtt_alignment; +} + +static void create_ext_placement_alignment (int fd) +{ +struct drm_i915_gem_create_ext_memory_regions setparam_region = { + .base = { .name =I915_GEM_CREATE_EXT_MEMORY_REGIONS }, + }; +struct drm_i915_gem_memory_class_instance *uregions; +struct drm_i915_query_memory_regions *regions; +const uint32_t bbe =MI_BATCH_BUFFER_END ; +struct drm_i915_gem_execbuffer2 execbuf = {}; +struct drm_i915_gem_exec_object2 obj = {}; +uint32_t max_gtt_alignment; +uint32_t handle; +uint32_t ctx; +uint64_t ahnd; +uint64_t size; +int i; + + regions =gem_get_query_memory_regions (fd); +igt_assert (regions); +igt_assert (regions->num_regions); + + uregions =calloc (regions->num_regions,sizeof (*uregions)); + + ctx =gem_context_create (fd); + + max_gtt_alignment =0 ; +for (i =0 ; i < regions->num_regions; i++) { +struct drm_i915_memory_region_info qmr = regions->regions[i]; +struct drm_i915_gem_memory_class_instance ci = qmr.region; +uint32_t gtt_alignment; + + gtt_alignment = qmr.gtt_alignment; + + setparam_region.regions =to_user_pointer (&ci); + setparam_region.num_regions =1 ; + + size =PAGE_SIZE ; +igt_assert_eq (__gem_create_ext (fd, &size,0 , &handle, + &setparam_region.base),0 ); +gem_write (fd, handle,0 , &bbe,sizeof (bbe)); + + ahnd =intel_allocator_open_full (fd, ctx,0 ,0 , +INTEL_ALLOCATOR_RANDOM , +ALLOC_STRATEGY_HIGH_TO_LOW , + gtt_alignment); + + obj.handle = handle; + obj.offset =CANONICAL (get_offset (ahnd, handle, size,0 )); + obj.flags =EXEC_OBJECT_SUPPORTS_48B_ADDRESS |EXEC_OBJECT_PINNED ; + + execbuf.buffers_ptr =to_user_pointer (&obj); + execbuf.buffer_count =1 ; + +gem_execbuf (fd, &execbuf); + +put_ahnd (ahnd); + + max_gtt_alignment =max (max_gtt_alignment, gtt_alignment); + uregions[i] = regions->regions[i].region; + } + + setparam_region.regions =to_user_pointer (uregions); + setparam_region.num_regions = regions->num_regions; + + size =PAGE_SIZE ; +igt_assert_eq (__gem_create_ext (fd, &size,0 , &handle, + &setparam_region.base),0 ); +gem_write (fd, handle,0 , &bbe,sizeof (bbe)); + + ahnd =intel_allocator_open_full (fd, ctx,0 ,0 , +INTEL_ALLOCATOR_RANDOM , +ALLOC_STRATEGY_HIGH_TO_LOW , + max_gtt_alignment); + + obj.handle = handle; + obj.offset =CANONICAL (get_offset (ahnd, handle, size,0 )); + obj.flags =EXEC_OBJECT_SUPPORTS_48B_ADDRESS |EXEC_OBJECT_PINNED ; + + execbuf.buffers_ptr =to_user_pointer (&obj); + execbuf.buffer_count =1 ; + +gem_execbuf (fd, &execbuf); + +put_ahnd (ahnd); + +gem_context_destroy (fd, ctx); + +gem_close (fd, handle); +free (uregions); +free (regions); +} + igt_main {igt_fd_t (fd);
@@ -907,4 +1016,12 @@ igt_mainigt_require (supports_needs_cpu_access (fd));create_ext_cpu_access_big (fd); } + +igt_describe ("Check reported GTT alignment gives usable GTT address, for each region." ); + igt_subtest("create-ext-placement-alignment") { +igt_require (supports_gtt_alignment (fd)); +igt_require (gem_uses_full_ppgtt (fd)); +create_ext_placement_alignment (fd); + } + }
Signature · 1 line
2.37.3
Patchwork
CI[igt-dev] ✗ GitLab.Pipeline: warning for series starting with [CI,1/2] tests/i915/query: sanity check reported GTT alignment
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [CI,1/2] tests/i915/query: sanity check reported GTT alignment
URL : https://patchwork.freedesktop.org/series/109758/
State : warning
== Summary ==
Pipeline status: FAILED.
see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/713098 for the overview.
test:ninja-test-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/29846071):
Ok: 23
Expected Fail: 4
Fail: 293
Unexpected Pass: 0 Skipped: 0 Timeout: 0
Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt section_end:1665999968:step_script
section_start:1665999968:upload_artifacts_on_failure
Uploading artifacts for failed job
Uploading artifacts...
build: found 1786 matching files and directories
Uploading artifacts as "archive" to coordinator... 201 Created id=29846071 responseStatus=201 Created token=qoMjnczh section_end:1665999979:upload_artifacts_on_failure
section_start:1665999979:cleanup_file_variables
Cleaning up project directory and file based variables section_end:1665999979:cleanup_file_variables
ERROR: Job failed: exit code 1
== Logs ==
For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/713098
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] tests/i915/query: sanity check reported GTT alignment
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [CI,1/2] tests/i915/query: sanity check reported GTT alignment
URL : https://patchwork.freedesktop.org/series/109758/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12250 -> IGTPW_7971
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_7971 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_7971, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7971/index.html
Participating hosts (45 -> 46)
------------------------------
Additional (3): fi-rkl-guc bat-jsl-1 bat-dg1-5
Missing (2): fi-bdw-samus fi-skl-6700k2
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_7971:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/fi-pnv-d510/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7971/fi-pnv-d510/igt@[email protected]
* igt@runner@aborted:
- bat-dg1-5: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7971/bat-dg1-5/igt@[email protected]
Known issues
------------
Here are the changes found in IGTPW_7971 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@runner@aborted:
- fi-rkl-guc: NOTRUN -> [FAIL][4] ([i915#7220])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7971/fi-rkl-guc/igt@[email protected]
#### Warnings ####
* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-gvtdvm: [FAIL][5] ([fdo#103375]) -> [INCOMPLETE][6] ([i915#146])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/fi-bdw-gvtdvm/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7971/fi-bdw-gvtdvm/igt@[email protected]
* igt@runner@aborted:
- fi-kbl-soraka: [FAIL][7] ([i915#4991]) -> [FAIL][8] ([i915#4991] / [i915#7220])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/fi-kbl-soraka/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7971/fi-kbl-soraka/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#7190]: https://gitlab.freedesktop.org/drm/intel/issues/7190
[i915#7220]: https://gitlab.freedesktop.org/drm/intel/issues/7220
[i915#7221]: https://gitlab.freedesktop.org/drm/intel/issues/7221
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7016 -> IGTPW_7971
CI-20190529: 20190529
CI_DRM_12250: 9b84132c9b266a89e2865cbe8b586dd0b14cc2a4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7971: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7971/index.html
IGT_7016: 642f4bf44e2b42791b4d1684936a1bfbe2d099ee @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@gem_create@create-ext-placement-alignment
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7971/index.html
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] tests/i915/query: sanity check reported GTT alignment (rev2)
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [CI,1/2] tests/i915/query: sanity check reported GTT alignment (rev2)
URL : https://patchwork.freedesktop.org/series/109758/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12259 -> IGTPW_7981
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_7981 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_7981, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/index.html
Participating hosts (41 -> 43)
------------------------------
Additional (2): bat-adlm-1 fi-icl-u2
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_7981:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gem_contexts:
- fi-adl-ddr5: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/fi-adl-ddr5/igt@i915_selftest@live@gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-adl-ddr5/igt@i915_selftest@live@gem_contexts.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_selftest@live@gem_contexts:
- {fi-ehl-2}: [PASS][3] -> [DMESG-FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/fi-ehl-2/igt@i915_selftest@live@gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-ehl-2/igt@i915_selftest@live@gem_contexts.html
Known issues
------------
Here are the changes found in IGTPW_7981 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][5] ([i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-icl-u2/igt@[email protected]
* igt@gem_lmem_swapping@random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-icl-u2/igt@[email protected]
* igt@gem_lmem_swapping@verify-random:
- fi-bdw-5557u: NOTRUN -> [SKIP][7] ([fdo#109271]) +13 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-bdw-5557u/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- fi-glk-j4005: [PASS][8] -> [DMESG-FAIL][9] ([i915#5334])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][10] -> [INCOMPLETE][11] ([i915#4785])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/fi-hsw-4770/igt@i915_selftest@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-hsw-4770/igt@i915_selftest@[email protected]
- fi-hsw-g3258: [PASS][12] -> [INCOMPLETE][13] ([i915#3303] / [i915#4785])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/fi-hsw-g3258/igt@i915_selftest@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-hsw-g3258/igt@i915_selftest@[email protected]
- fi-icl-u2: NOTRUN -> [INCOMPLETE][14] ([i915#4890])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-icl-u2/igt@i915_selftest@[email protected]
* igt@kms_chamelium@dp-edid-read:
- fi-bdw-5557u: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827]) +8 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-bdw-5557u/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][16] ([fdo#111827]) +7 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-icl-u2/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-icl-u2: NOTRUN -> [SKIP][17] ([i915#4103])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-icl-u2/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][18] ([fdo#109285])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-icl-u2/igt@[email protected]
* igt@kms_setmode@basic-clone-single-crtc:
- fi-icl-u2: NOTRUN -> [SKIP][19] ([i915#3555])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-icl-u2/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][20] ([fdo#109295] / [i915#3301])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-icl-u2/igt@[email protected]
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][21] ([fdo#109271] / [i915#4312] / [i915#5594])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-hsw-4770/igt@[email protected]
- fi-icl-u2: NOTRUN -> [FAIL][22] ([i915#4312])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-icl-u2/igt@[email protected]
- fi-hsw-g3258: NOTRUN -> [FAIL][23] ([fdo#109271] / [i915#4312] / [i915#4991])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-hsw-g3258/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rpls-1}: [DMESG-WARN][24] ([i915#7271]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/bat-rpls-1/igt@gem_exec_suspend@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/bat-rpls-1/igt@gem_exec_suspend@[email protected]
* igt@gem_huc_copy@huc-copy:
- {bat-dg2-8}: [FAIL][26] ([i915#7029]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/bat-dg2-8/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/bat-dg2-8/igt@[email protected]
* igt@i915_selftest@live@gem_contexts:
- {fi-tgl-mst}: [DMESG-FAIL][28] ([i915#7270]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/fi-tgl-mst/igt@i915_selftest@live@gem_contexts.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/fi-tgl-mst/igt@i915_selftest@live@gem_contexts.html
- {bat-dg2-11}: [DMESG-FAIL][30] ([i915#7270]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/bat-dg2-11/igt@i915_selftest@live@gem_contexts.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/bat-dg2-11/igt@i915_selftest@live@gem_contexts.html
- {bat-jsl-1}: [DMESG-FAIL][32] ([i915#7270]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/bat-jsl-1/igt@i915_selftest@live@gem_contexts.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/bat-jsl-1/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@requests:
- {bat-adln-1}: [DMESG-FAIL][34] ([i915#7269]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/bat-adln-1/igt@i915_selftest@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/bat-adln-1/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4890]: https://gitlab.freedesktop.org/drm/intel/issues/4890
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#5828]: https://gitlab.freedesktop.org/drm/intel/issues/5828
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#7029]: https://gitlab.freedesktop.org/drm/intel/issues/7029
[i915#7269]: https://gitlab.freedesktop.org/drm/intel/issues/7269
[i915#7270]: https://gitlab.freedesktop.org/drm/intel/issues/7270
[i915#7271]: https://gitlab.freedesktop.org/drm/intel/issues/7271
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7019 -> IGTPW_7981
CI-20190529: 20190529
CI_DRM_12259: af4d5174f9efe29241ffa082a7417fde95ca2f28 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7981: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/index.html
IGT_7019: fdbafce2b74e84739bb1d81223ae6f01fb442980 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@gem_create@create-ext-placement-alignment
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7981/index.html
Hi Matthew,
Quoted 7 lines · Matthew Auld
Ensure the kernel is reporting "normal" values here, based on our current expectations.
Signed-off-by Matthew Auld <[email protected]>Cc Andrzej Hajda <[email protected]>Cc Nirmoy Das <[email protected]>Reviewed-by Nirmoy Das <[email protected]>
- ^
imho you should remove this when sending patch. Please also use [PATCH i-g-t] or [PATCH i-g-t vN] in Subject: line (with N=version > 1) instead of [CI 1/2]. It would also help if you could send series bigger than one patch with cover letter (well, now it can stay as is).
Quoted 30 lines
--- tests/i915/i915_query.c | 10 ++++++++++ 1 file changed, 10 insertions(+)tests/i915/i915_query.c +7
-0@@ -638,6 +638,8 @@ static void upload(int fd, struct igt_list_head *handles, uint32_t num_handles)free (exec); } +/** XXX: remove once we sync the uapi header */ +#define gtt_alignment rsvd0static void test_query_regions_sanity_check (int fd) {struct drm_i915_query_memory_regions *regions;@@ -664,6 +666,11 @@ static void test_query_regions_sanity_check(int fd)struct drm_i915_gem_memory_class_instance r1 = info.region;int j; +if (info.gtt_alignment) { +igt_assert_lte_u64 (4096 , info.gtt_alignment); +igt_assert (is_power_of_two (info.gtt_alignment)); + } +if (r1.memory_class ==I915_MEMORY_CLASS_SYSTEM ) {igt_assert_eq (r1.memory_instance,0 ); found_system = true;
tests/i915/i915_query.c static void test_query_regions_sanity_check(int fd) · line 686
Quoted 6 lines
tests/i915/i915_query.c +3
-0@@ -674,6 +681,9 @@ static void test_query_regions_sanity_check(int fd)igt_assert (info.unallocated_cpu_visible_size ==0 || info.unallocated_cpu_visible_size == info.unallocated_size); + +igt_assert (info.gtt_alignment ==0 || + info.gtt_alignment ==4096 );
-------------------------------------------------------- ^ Why not copy your check from above ? This is restricting to only 4KB or 0 and can break for bigger values.
Regards,
Kamil
Quoted 6 lines
tests/i915/i915_query.c +0
-0}else {igt_assert (info.probed_cpu_visible_size <= info.probed_size);igt_assert (info.unallocated_size <= info.probed_size);Signature · 1 line
2.37.3
Hi,
Quoted 6 lines · Kamil Konieczny
Hi Matthew,
Quoted 3 lines · Matthew Auld
Ensure the kernel is reporting "normal" values here, based on our current expectations.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Matthew Auld <[email protected]>Cc Andrzej Hajda <[email protected]>Cc Nirmoy Das <[email protected]>Reviewed-by Nirmoy Das <[email protected]>- ^
imho you should remove this when sending patch.
Hmm, what should be removed here? Do you mean the r-b tag?
Quoted 5 lines
Please also use
[PATCH i-g-t] or [PATCH i-g-t vN] in Subject: line (with N=version > 1) instead of [CI 1/2]. It would also help if you could send series bigger than one patch with cover letter (well, now it can stay as is).
The patch should be unchanged, I'm just re-sending with [CI] and --suppress-cc=all since I just want to get some CI results before merging (i.e not requesting review from the mailing list), now that the corresponding kernel patches are merged. The patch has already been reviewed.
Quoted 32 lines
Quoted 32 lines
--- tests/i915/i915_query.c | 10 ++++++++++ 1 file changed, 10 insertions(+)tests/i915/i915_query.c +7
-0@@ -638,6 +638,8 @@ static void upload(int fd, struct igt_list_head *handles, uint32_t num_handles)free (exec); } +/** XXX: remove once we sync the uapi header */ +#define gtt_alignment rsvd0static void test_query_regions_sanity_check (int fd) {struct drm_i915_query_memory_regions *regions;@@ -664,6 +666,11 @@ static void test_query_regions_sanity_check(int fd)struct drm_i915_gem_memory_class_instance r1 = info.region;int j; +if (info.gtt_alignment) { +igt_assert_lte_u64 (4096 , info.gtt_alignment); +igt_assert (is_power_of_two (info.gtt_alignment)); + } +if (r1.memory_class ==I915_MEMORY_CLASS_SYSTEM ) {igt_assert_eq (r1.memory_instance,0 ); found_system = true;@@ -674,6 +681,9 @@ static void test_query_regions_sanity_check(int fd) igt_assert(info.unallocated_cpu_visible_size == 0 ||
Quoted 8 lines
tests/i915/i915_query.c static void test_query_regions_sanity_check(int fd) · line 686
Quoted 5 lines
tests/i915/i915_query.c +3
-0info.unallocated_cpu_visible_size == info.unallocated_size); + +igt_assert (info.gtt_alignment ==0 || + info.gtt_alignment ==4096 );-------------------------------------------------------- ^ Why not copy your check from above ? This is restricting to only 4KB or 0 and can break for bigger values.
We want it to break for bigger values. This check is for system memory, and likely means we have a silly bug since we should not expect anything other than 4K (or zero if the kernel doesn't support the field).
Quoted 10 lines
Regards,
KamilQuoted 6 lines
tests/i915/i915_query.c +0
-0}else {igt_assert (info.probed_cpu_visible_size <= info.probed_size);igt_assert (info.unallocated_size <= info.probed_size);Signature · 1 line
2.37.3
Hi,
Quoted 69 lines · Matthew Auld
Hi,
Quoted 6 lines · Kamil Konieczny
Hi Matthew,
Quoted 3 lines · Matthew Auld
Ensure the kernel is reporting "normal" values here, based on our current expectations.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Matthew Auld <[email protected]>Cc Andrzej Hajda <[email protected]>Cc Nirmoy Das <[email protected]>Reviewed-by Nirmoy Das <[email protected]>- ^
imho you should remove this when sending patch.Hmm, what should be removed here? Do you mean the r-b tag?
Quoted 5 lines
Please also use
[PATCH i-g-t] or [PATCH i-g-t vN] in Subject: line (with N=version > 1) instead of [CI 1/2]. It would also help if you could send series bigger than one patch with cover letter (well, now it can stay as is).The patch should be unchanged, I'm just re-sending with [CI] and --suppress-cc=all since I just want to get some CI results before merging (i.e not requesting review from the mailing list), now that the corresponding kernel patches are merged. The patch has already been reviewed.
Quoted 30 lines
Quoted 30 lines
--- tests/i915/i915_query.c | 10 ++++++++++ 1 file changed, 10 insertions(+)tests/i915/i915_query.c +7
-0@@ -638,6 +638,8 @@ static void upload(int fd, struct igt_list_head *handles, uint32_t num_handles)free (exec); } +/** XXX: remove once we sync the uapi header */ +#define gtt_alignment rsvd0static void test_query_regions_sanity_check (int fd) {struct drm_i915_query_memory_regions *regions;@@ -664,6 +666,11 @@ static void test_query_regions_sanity_check(int fd)struct drm_i915_gem_memory_class_instance r1 = info.region;int j; +if (info.gtt_alignment) { +igt_assert_lte_u64 (4096 , info.gtt_alignment); +igt_assert (is_power_of_two (info.gtt_alignment)); + } +if (r1.memory_class ==I915_MEMORY_CLASS_SYSTEM ) {igt_assert_eq (r1.memory_instance,0 ); found_system = true;@@ -674,6 +681,9 @@ static void test_query_regions_sanity_check(int fd) igt_assert(info.unallocated_cpu_visible_size == 0 ||Quoted 8 lines
tests/i915/i915_query.c static void test_query_regions_sanity_check(int fd) · line 686
Quoted 5 lines
tests/i915/i915_query.c +3
-0info.unallocated_cpu_visible_size == info.unallocated_size); + +igt_assert (info.gtt_alignment ==0 || + info.gtt_alignment ==4096 );-------------------------------------------------------- ^ Why not copy your check from above ? This is restricting to only 4KB or 0 and can break for bigger values.
Quoted 3 lines
We want it to break for bigger values. This check is for system memory, and likely means we have a silly bug since we should not expect anything other than 4K (or zero if the kernel doesn't support the field).
This should be PAGE_SIZE instead of 4096, also you can consider checking for HUGE_PAGE_SIZE but that depends on userspace and kernel options:
grep -i hugepagesize /proc/meminfo
Hugepagesize: 2048 kB
So imho at least change 4096 into PAGE_SIZE (in few places where it is used).
Regards,
Kamil
Quoted 11 lines
Quoted 11 lines
Regards,
KamilQuoted 6 lines
tests/i915/i915_query.c +0
-0}else {igt_assert (info.probed_cpu_visible_size <= info.probed_size);igt_assert (info.unallocated_size <= info.probed_size);Signature · 1 line
2.37.3
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] tests/i915/query: sanity check reported GTT alignment (rev3)
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [CI,1/2] tests/i915/query: sanity check reported GTT alignment (rev3)
URL : https://patchwork.freedesktop.org/series/109758/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12272 -> IGTPW_7995
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_7995 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_7995, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/index.html
Participating hosts (45 -> 42)
------------------------------
Additional (1): bat-dg1-5
Missing (4): fi-ctg-p8600 fi-icl-u2 fi-bdw-samus fi-hsw-4200u
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_7995:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@migrate:
- bat-adlp-4: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12272/bat-adlp-4/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-adlp-4/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in IGTPW_7995 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][3] ([i915#4083])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg1-5/igt@[email protected]
* igt@gem_tiled_blits@basic:
- fi-pnv-d510: [PASS][4] -> [SKIP][5] ([fdo#109271]) +2 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12272/fi-pnv-d510/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/fi-pnv-d510/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][6] ([i915#4077]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg1-5/igt@[email protected]
* igt@gem_tiled_pread_basic:
- bat-dg1-5: NOTRUN -> [SKIP][7] ([i915#4079]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg1-5/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-5: NOTRUN -> [SKIP][8] ([i915#1155])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg1-5/igt@[email protected]
* igt@i915_pm_rps@basic-api:
- bat-dg1-5: NOTRUN -> [SKIP][9] ([i915#6621])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg1-5/igt@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [PASS][10] -> [INCOMPLETE][11] ([i915#4817] / [i915#5982])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12272/fi-rkl-11600/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/fi-rkl-11600/igt@[email protected]
- fi-bdw-5557u: [PASS][12] -> [INCOMPLETE][13] ([i915#146] / [i915#6712])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12272/fi-bdw-5557u/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/fi-bdw-5557u/igt@[email protected]
* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][14] ([i915#4212]) +7 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg1-5/igt@[email protected]
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][15] ([i915#4215])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg1-5/igt@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- bat-dg1-5: NOTRUN -> [SKIP][16] ([fdo#111827]) +8 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg1-5/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- bat-dg1-5: NOTRUN -> [SKIP][17] ([i915#4103] / [i915#4213])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg1-5/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg1-5: NOTRUN -> [SKIP][18] ([fdo#109285])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg1-5/igt@[email protected]
* igt@kms_psr@primary_page_flip:
- bat-dg1-5: NOTRUN -> [SKIP][19] ([i915#1072] / [i915#4078]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg1-5/igt@kms_psr@primary_page_flip.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg1-5: NOTRUN -> [SKIP][20] ([i915#3555])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg1-5/igt@[email protected]
* igt@prime_vgem@basic-fence-read:
- bat-dg1-5: NOTRUN -> [SKIP][21] ([i915#3708]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg1-5/igt@[email protected]
* igt@prime_vgem@basic-gtt:
- bat-dg1-5: NOTRUN -> [SKIP][22] ([i915#3708] / [i915#4077]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg1-5/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- bat-dg1-5: NOTRUN -> [SKIP][23] ([i915#3708] / [i915#4873])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg1-5/igt@[email protected]
* igt@runner@aborted:
- bat-adlp-4: NOTRUN -> [FAIL][24] ([i915#4312])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-adlp-4/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rplp-1}: [DMESG-WARN][25] ([i915#2867]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12272/bat-rplp-1/igt@gem_exec_suspend@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-rplp-1/igt@gem_exec_suspend@[email protected]
* igt@gem_exec_suspend@basic-s3@smem:
- {bat-adlm-1}: [DMESG-WARN][27] ([i915#2867]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12272/bat-adlm-1/igt@gem_exec_suspend@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-adlm-1/igt@gem_exec_suspend@[email protected]
- {bat-rpls-1}: [DMESG-WARN][29] ([i915#6687]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12272/bat-rpls-1/igt@gem_exec_suspend@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-rpls-1/igt@gem_exec_suspend@[email protected]
* igt@gem_huc_copy@huc-copy:
- {bat-dg2-8}: [FAIL][31] ([i915#7029]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12272/bat-dg2-8/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-dg2-8/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- fi-bdw-5557u: [DMESG-FAIL][33] ([i915#5334]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12272/fi-bdw-5557u/igt@i915_selftest@live@gt_heartbeat.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/fi-bdw-5557u/igt@i915_selftest@live@gt_heartbeat.html
- fi-bxt-dsi: [DMESG-FAIL][35] ([i915#5334]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12272/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@slpc:
- {bat-rpls-1}: [DMESG-FAIL][37] ([i915#6367]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12272/bat-rpls-1/igt@i915_selftest@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/bat-rpls-1/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#5278]: https://gitlab.freedesktop.org/drm/intel/issues/5278
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6712]: https://gitlab.freedesktop.org/drm/intel/issues/6712
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7029]: https://gitlab.freedesktop.org/drm/intel/issues/7029
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7021 -> IGTPW_7995
CI-20190529: 20190529
CI_DRM_12272: 168aff13f677d0e72ad071851f2305a836696ae3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7995: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/index.html
IGT_7021: b99f94fc3652f6838b8803032373a419372b17b1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@gem_create@create-ext-placement-alignment
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7995/index.html