Skip to contentSkip to conversation

scsi: mpi3mr: add explicit dependency on CONFIG_SCSI_SAS_ATTRS

PATCH In review Michal Kubecek 2 participants 3 messages Oct 17, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: mpi3mr: add explicit dependency on CONFIG_SCSI_SAS_ATTRS

Starting with commit 42fc9fee116f ("scsi: mpi3mr: Add helper functions to manage device's port"), kernel configured with CONFIG_SCSI_MPI3MR=m and CONFIG_SCSI_SAS_ATTRS=n fails to build because modpost cannot find symbols used in mpi3mr_transport.c:

ERROR: modpost: "sas_port_alloc_num" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
ERROR: modpost: "sas_remove_host" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
ERROR: modpost: "sas_phy_alloc" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
ERROR: modpost: "sas_phy_free" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
...

Add an explicit dependency of CONFIG_SCSI_MPI3MR on CONFIG_SCSI_SAS_ATTRS to prevent inconsistent configs.

Fixes 42fc9fee116f ("scsi: mpi3mr: Add helper functions to manage device's port")
---
 drivers/scsi/mpi3mr/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/mpi3mr/Kconfig +1 -1
index 8997531940c2..8ada8e8d25ac 100644
@@ -2,7 +2,7 @@
 
 config SCSI_MPI3MR
 	tristate "Broadcom MPI3 Storage Controller Device Driver"
-	depends on PCI && SCSI
+	depends on PCI && SCSI && SCSI_SAS_ATTRS
 	select BLK_DEV_BSGLIB
 	help
 	MPI3 based Storage & RAID Controllers Driver.
Signature · 1 line
2.38.0
maintainer
#1 lore raw
Quoted 35 lines · Michal Kubecek

Starting with commit 42fc9fee116f ("scsi: mpi3mr: Add helper functions to
manage device's port"), kernel configured with CONFIG_SCSI_MPI3MR=m and
CONFIG_SCSI_SAS_ATTRS=n fails to build because modpost cannot find symbols
used in mpi3mr_transport.c:

ERROR: modpost: "sas_port_alloc_num"
[drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
ERROR: modpost: "sas_remove_host" [drivers/scsi/mpi3mr/mpi3mr.ko]
undefined!
ERROR: modpost: "sas_phy_alloc" [drivers/scsi/mpi3mr/mpi3mr.ko]
undefined!
ERROR: modpost: "sas_phy_free" [drivers/scsi/mpi3mr/mpi3mr.ko]
undefined!
...

Add an explicit dependency of CONFIG_SCSI_MPI3MR on CONFIG_SCSI_SAS_ATTRS
to prevent inconsistent configs.

Fixes 42fc9fee116f ("scsi: mpi3mr: Add helper functions to manage

device's port")

---
 drivers/scsi/mpi3mr/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/mpi3mr/Kconfig +0 -0
index 8997531940c2..8ada8e8d25ac 100644

drivers/scsi/mpi3mr/Kconfig line 5

Quoted 5 lines
drivers/scsi/mpi3mr/Kconfig +1 -1
@@ -2,7 +2,7 @@
 
 config SCSI_MPI3MR
 	tristate "Broadcom MPI3 Storage Controller Device Driver"
-	depends on PCI && SCSI
+	depends on PCI && SCSI && SCSI_SAS_ATTRS

This should probably be select not depends.

All transport attributes are designed to be selected. The reason is to avoid people having to figure out what attributes they have to set in Kconfig before they see the HBAs they're interested in.

James

#2 lore raw
Quoted 44 lines · James Bottomley
Quoted 35 lines · Michal Kubecek

Starting with commit 42fc9fee116f ("scsi: mpi3mr: Add helper functions to
manage device's port"), kernel configured with CONFIG_SCSI_MPI3MR=m and
CONFIG_SCSI_SAS_ATTRS=n fails to build because modpost cannot find symbols
used in mpi3mr_transport.c:

ERROR: modpost: "sas_port_alloc_num"
[drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
ERROR: modpost: "sas_remove_host" [drivers/scsi/mpi3mr/mpi3mr.ko]
undefined!
ERROR: modpost: "sas_phy_alloc" [drivers/scsi/mpi3mr/mpi3mr.ko]
undefined!
ERROR: modpost: "sas_phy_free" [drivers/scsi/mpi3mr/mpi3mr.ko]
undefined!
...

Add an explicit dependency of CONFIG_SCSI_MPI3MR on CONFIG_SCSI_SAS_ATTRS
to prevent inconsistent configs.

Fixes 42fc9fee116f ("scsi: mpi3mr: Add helper functions to manage

device's port")

---
 drivers/scsi/mpi3mr/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/mpi3mr/Kconfig +0 -0
index 8997531940c2..8ada8e8d25ac 100644

drivers/scsi/mpi3mr/Kconfig line 5

Quoted 5 lines
drivers/scsi/mpi3mr/Kconfig +1 -1
@@ -2,7 +2,7 @@
 
 config SCSI_MPI3MR
 	tristate "Broadcom MPI3 Storage Controller Device Driver"
-	depends on PCI && SCSI
+	depends on PCI && SCSI && SCSI_SAS_ATTRS

This should probably be select not depends.

Quoted 3 lines

All transport attributes are designed to be selected. The reason is to avoid people having to figure out what attributes they have to set in Kconfig before they see the HBAs they're interested in.

OK, I'll send v2 with select in a moment.

Michal