Skip to contentSkip to conversation

ucount: Fix and improve atomic_long_inc_below

PATCH RESEND In review Uros Bizjak 2 participants 4 messages Oct 17, 2022 – Oct 31, 2022

lore
Share & tools
lore
#0 lore raw

cover ucount: Fix and improve atomic_long_inc_below

The series fixes wrong argument type and improves atomic_long_inc_below by using atomic_long_try_cmpxchg instead of atomic_long_cmpxchg.

Cc "Eric W. Biederman" <[email protected]>

Uros Bizjak (2):
ucount: Fix atomic_long_inc_below argument type
ucount: Use atomic_long_try_cmpxchg in atomic_long_inc_below

 kernel/ucount.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)
Signature · 1 line
2.37.3
#1 lore raw

PATCH RESEND 1/2 ucount: Fix atomic_long_inc_below argument type

The type of u argument of atomic_long_inc_below should be long to avoid unwanted truncation to int.

Fixes f9c82a4ea89c ("Increase size of ucounts to atomic_long_t")
Cc "Eric W. Biederman" <[email protected]>
---
 kernel/ucount.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/ucount.c +1 -1
index ee8e57fd6f90..74f5b4959feb 100644
@@ -212,7 +212,7 @@ void put_ucounts(struct ucounts *ucounts)
 	}
 }
 
-static inline bool atomic_long_inc_below(atomic_long_t *v, int u)
+static inline bool atomic_long_inc_below(atomic_long_t *v, long u)
 {
 	long c, old;
 	c = atomic_long_read(v);
Signature · 1 line
2.37.3
#2 lore raw

PATCH RESEND 2/2 ucount: Use atomic_long_try_cmpxchg in atomic_long_inc_below

In reply to Uros Bizjak

Use atomic_long_try_cmpxchg instead of
atomic_long_cmpxchg (*ptr, old, new) == old in atomic_long_inc_below. x86 CMPXCHG instruction returns success in ZF flag, so this change saves a compare after cmpxchg (and related move instruction in front of cmpxchg).

Also, atomic_long_try_cmpxchg implicitly assigns old *ptr value to "old" when cmpxchg fails, enabling further code simplifications.

No functional change intended.

Cc "Eric W. Biederman" <[email protected]>
---
 kernel/ucount.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)
kernel/ucount.c +6 -8
index 74f5b4959feb..2c04589a61ff 100644
@@ -214,16 +214,14 @@ void put_ucounts(struct ucounts *ucounts)
 
 static inline bool atomic_long_inc_below(atomic_long_t *v, long u)
 {
-	long c, old;
-	c = atomic_long_read(v);
-	for (;;) {
+	long c = atomic_long_read(v);
+
+	do {
 		if (unlikely(c >= u))
 			return false;
-		old = atomic_long_cmpxchg(v, c, c+1);
-		if (likely(old == c))
-			return true;
-		c = old;
-	}
+	} while (!atomic_long_try_cmpxchg(v, &c, c+1));
+
+	return true;
 }
 
 struct ucounts *inc_ucount(struct user_namespace *ns, kuid_t uid,
Signature · 1 line
2.37.3
Reviewed-by on v1 2/2
#3 lore raw

Re: [PATCH RESEND 2/2] ucount: Use atomic_long_try_cmpxchg in atomic_long_inc_below

Quoted 5 lines · Uros Bizjak

Use atomic_long_try_cmpxchg instead of
atomic_long_cmpxchg (*ptr, old, new) == old in atomic_long_inc_below. x86 CMPXCHG instruction returns success in ZF flag, so this change saves a compare after cmpxchg (and related move instruction in front of cmpxchg).

Quoted 7 lines

Also, atomic_long_try_cmpxchg implicitly assigns old *ptr value to "old" when cmpxchg fails, enabling further code simplifications.

No functional change intended.

Cc "Eric W. Biederman" <[email protected]>

Eric, I think the patch looks good. You already reviewed the previous version [1]. What do you think about this version?

[1] https://lore.kernel.org/lkml/[email protected]/

Quoted 34 lines
---
 kernel/ucount.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)
kernel/ucount.c +6 -8
index 74f5b4959feb..2c04589a61ff 100644
@@ -214,16 +214,14 @@ void put_ucounts(struct ucounts *ucounts)
 
 static inline bool atomic_long_inc_below(atomic_long_t *v, long u)
 {
-	long c, old;
-	c = atomic_long_read(v);
-	for (;;) {
+	long c = atomic_long_read(v);
+
+	do {
 		if (unlikely(c >= u))
 			return false;
-		old = atomic_long_cmpxchg(v, c, c+1);
-		if (likely(old == c))
-			return true;
-		c = old;
-	}
+	} while (!atomic_long_try_cmpxchg(v, &c, c+1));
+
+	return true;
 }
 
 struct ucounts *inc_ucount(struct user_namespace *ns, kuid_t uid,
Signature · 1 line
2.37.3
Signature · 1 line
Rgrds, legion