Skip to contentSkip to conversation

kbuild: use POSIX-compatible grep option

PATCH In review Stefan Hansson 2 participants 4 messages Oct 17, 2022 – Oct 18, 2022 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: use POSIX-compatible grep option

--file is a GNU extension to grep which is not available in all implementations (such as BusyBox). Use the -f option instead which is eqvuialent according to the GNU grep manpage[1] and is present in POSIX[2].

[1] https://www.gnu.org/software/grep/manual/grep.html
[2] https://pubs.opengroup.org/onlinepubs/9699919799/

---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index c690361b393f..3513a6db66a2 100644
@@ -1218,7 +1218,7 @@ quiet_cmd_ar_vmlinux.a = AR      $@
       cmd_ar_vmlinux.a = \
 	rm -f $@; \
 	$(AR) cDPrST $@ $(KBUILD_VMLINUX_OBJS); \
-	$(AR) mPiT $$($(AR) t $@ | head -n1) $@ $$($(AR) t $@ | grep -F --file=$(srctree)/scripts/head-object-list.txt)
+	$(AR) mPiT $$($(AR) t $@ | head -n1) $@ $$($(AR) t $@ | grep -Ff $(srctree)/scripts/head-object-list.txt)
 
 targets += vmlinux.a
 vmlinux.a: $(KBUILD_VMLINUX_OBJS) scripts/head-object-list.txt autoksyms_recursive FORCE
Signature · 1 line
2.37.3
#1 lore raw
Quoted 8 lines · Stefan Hansson

--file is a GNU extension to grep which is not available in all implementations (such as BusyBox). Use the -f option instead which is eqvuialent according to the GNU grep manpage[1] and is present in POSIX[2].

[1] https://www.gnu.org/software/grep/manual/grep.html
[2] https://pubs.opengroup.org/onlinepubs/9699919799/

This link does not show the spec of grep.

Did you mean this?

https://pubs.opengroup.org/onlinepubs/9699919799/utilities/grep.html

Thanks.

Quoted 22 lines
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -2
index c690361b393f..3513a6db66a2 100644
@@ -1218,7 +1218,7 @@ quiet_cmd_ar_vmlinux.a = AR      $@
       cmd_ar_vmlinux.a = \
        rm -f $@; \
        $(AR) cDPrST $@ $(KBUILD_VMLINUX_OBJS); \
-       $(AR) mPiT $$($(AR) t $@ | head -n1) $@ $$($(AR) t $@ | grep -F --file=$(srctree)/scripts/head-object-list.txt)
+       $(AR) mPiT $$($(AR) t $@ | head -n1) $@ $$($(AR) t $@ | grep -Ff $(srctree)/scripts/head-object-list.txt)
 
 targets += vmlinux.a
 vmlinux.a: $(KBUILD_VMLINUX_OBJS) scripts/head-object-list.txt autoksyms_recursive FORCE
--

2.37.3

Signature · 2 lines
Best Regards
Masahiro Yamada
#2 lore raw

Hi Masahiro,

Quoted 11 lines · Masahiro Yamada
Quoted 8 lines · Stefan Hansson

--file is a GNU extension to grep which is not available in all implementations (such as BusyBox). Use the -f option instead which is eqvuialent according to the GNU grep manpage[1] and is present in POSIX[2].

[1] https://www.gnu.org/software/grep/manual/grep.html
[2] https://pubs.opengroup.org/onlinepubs/9699919799/

Quoted 8 lines

This link does not show the spec of grep.

Did you mean this?

https://pubs.opengroup.org/onlinepubs/9699919799/utilities/grep.html

Yes, sorry, that's a better link. I'm new to this. Do you want me to send a v2 with the commit message updated?

Quoted 32 lines

Thanks.

Quoted 22 lines
---
  Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -2
index c690361b393f..3513a6db66a2 100644
@@ -1218,7 +1218,7 @@ quiet_cmd_ar_vmlinux.a = AR      $@
        cmd_ar_vmlinux.a = \
         rm -f $@; \
         $(AR) cDPrST $@ $(KBUILD_VMLINUX_OBJS); \
-       $(AR) mPiT $$($(AR) t $@ | head -n1) $@ $$($(AR) t $@ | grep -F --file=$(srctree)/scripts/head-object-list.txt)
+       $(AR) mPiT $$($(AR) t $@ | head -n1) $@ $$($(AR) t $@ | grep -Ff $(srctree)/scripts/head-object-list.txt)
 
  targets += vmlinux.a
  vmlinux.a: $(KBUILD_VMLINUX_OBJS) scripts/head-object-list.txt autoksyms_recursive FORCE
--

2.37.3

#3 lore raw
Quoted 18 lines · Stefan Hansson

Hi Masahiro,

Quoted 14 lines · Masahiro Yamada
Quoted 8 lines · Stefan Hansson

--file is a GNU extension to grep which is not available in all implementations (such as BusyBox). Use the -f option instead which is eqvuialent according to the GNU grep manpage[1] and is present in POSIX[2].

[1] https://www.gnu.org/software/grep/manual/grep.html
[2] https://pubs.opengroup.org/onlinepubs/9699919799/

This link does not show the spec of grep.

Quoted 8 lines
Quoted 5 lines

Did you mean this?

https://pubs.opengroup.org/onlinepubs/9699919799/utilities/grep.html

Yes, sorry, that's a better link. I'm new to this. Do you want me to send a v2 with the commit message updated?

No worries.
I applied the patch with the link replaced.

Thanks.

Quoted 32 lines
Quoted 32 lines

Thanks.

Quoted 22 lines
---
  Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -2
index c690361b393f..3513a6db66a2 100644
@@ -1218,7 +1218,7 @@ quiet_cmd_ar_vmlinux.a = AR      $@
        cmd_ar_vmlinux.a = \
         rm -f $@; \
         $(AR) cDPrST $@ $(KBUILD_VMLINUX_OBJS); \
-       $(AR) mPiT $$($(AR) t $@ | head -n1) $@ $$($(AR) t $@ | grep -F --file=$(srctree)/scripts/head-object-list.txt)
+       $(AR) mPiT $$($(AR) t $@ | head -n1) $@ $$($(AR) t $@ | grep -Ff $(srctree)/scripts/head-object-list.txt)
 
  targets += vmlinux.a
  vmlinux.a: $(KBUILD_VMLINUX_OBJS) scripts/head-object-list.txt autoksyms_recursive FORCE
--

2.37.3

Signature · 2 lines
Best Regards
Masahiro Yamada