Skip to contentSkip to conversation

atmel: Fix atmel_private_handler array size

PATCH In review Kees Cook 2 participants 2 messages Oct 18, 2022 – Nov 1, 2022

Subsystems (4)
Networking Network drivers Networking drivers (wireless) Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 atmel: Fix atmel_private_handler array size

Fix the atmel_private_handler to correctly sized (1 element) again. (I should have checked the data segment for differences.) This had no behavioral impact (no private callbacks), but it made a very large zero-filled array.

Cc Simon Kelley <[email protected]>
Cc Kalle Valo <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Eric Dumazet <[email protected]>
Cc Jakub Kicinski <[email protected]>
Cc Paolo Abeni <[email protected]>
Cc [email protected]
Cc [email protected]
Fixes 8af9d4068e86 ("wifi: atmel: Avoid clashing function prototypes")
Signed-off-by Kees Cook <[email protected]>
---
 drivers/net/wireless/atmel/atmel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/atmel/atmel.c +1 -1
index ed430b91e2aa..7c2d1c588156 100644
@@ -2570,7 +2570,7 @@ static const iw_handler atmel_handler[] =
 
 static const iw_handler atmel_private_handler[] =
 {
-	IW_HANDLER(SIOCIWFIRSTPRIV,	NULL),
+	NULL,				/* SIOCIWFIRSTPRIV */
 };
 
 struct atmel_priv_ioctl {
Signature · 1 line
2.34.1
#1 lore raw

Re: [next] wifi: atmel: Fix atmel_private_handler array size

Quoted 5 lines · Kees Cook

Fix the atmel_private_handler to correctly sized (1 element) again. (I should have checked the data segment for differences.) This had no behavioral impact (no private callbacks), but it made a very large zero-filled array.

Quoted 10 lines
Cc Simon Kelley <[email protected]>
Cc Kalle Valo <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Eric Dumazet <[email protected]>
Cc Jakub Kicinski <[email protected]>
Cc Paolo Abeni <[email protected]>
Cc [email protected]
Cc [email protected]
Fixes 8af9d4068e86 ("wifi: atmel: Avoid clashing function prototypes")
Signed-off-by Kees Cook <[email protected]>

Patch applied to wireless-next.git, thanks.

8b860466b137 wifi: atmel: Fix atmel_private_handler array size

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches