memory tier, sysfs: rename attribute "nodes" to "nodes_list"
Subsystems (3)
RFC 1/1 memory tier, sysfs: rename attribute "nodes" to "nodes_list"
In sysfs, we use attribute name "cpus" for cpu mask and "cpus_list" for cpu list. For example, in my system,
$ cat /sys/devices/system/cpu/cpu2/topology/core_cpus 0,00100004 $ cat /sys/devices/system/cpu/cpu2/topology/core_cpus_list 2,20
It looks reasonable to use "nodes" for node mask and "nodes_list" for node list. So, rename the attribute to follow the naming convention.
--- Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers | 4 ++-- mm/memory-tiers.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-)
Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers +2 -2
@@ -10,7 +10,7 @@ Description: A collection of all the memory tiers allocated. What: /sys/devices/virtual/memory_tiering/memory_tierN/ - /sys/devices/virtual/memory_tiering/memory_tierN/nodes + /sys/devices/virtual/memory_tiering/memory_tierN/nodes_list Date: August 2022 Contact: Linux memory management mailing list <[email protected]> Description: Directory with details of a specific memory tier
@@ -21,5 +21,5 @@ Description: Directory with details of a specific memory tier A smaller value of N implies a higher (faster) memory tier in the hierarchy. - nodes: NUMA nodes that are part of this memory tier. + nodes_list: NUMA nodes that are part of this memory tier.
mm/memory-tiers.c +4 -4
@@ -131,8 +131,8 @@ static void memory_tier_device_release(struct device *dev)kfree (tier); } -static ssize_t nodes_show (struct device *dev, -struct device_attribute *attr,char *buf) +static ssize_t nodes_list_show (struct device *dev, +struct device_attribute *attr,char *buf) {int ret;nodemask_t nmask;
@@ -143,10 +143,10 @@ static ssize_t nodes_show(struct device *dev,mutex_unlock (&memory_tier_lock);return ret; } -static DEVICE_ATTR_RO (nodes); +static DEVICE_ATTR_RO (nodes_list);static struct attribute *memtier_dev_attrs[] = { - &dev_attr_nodes.attr, + &dev_attr_nodes_list.attr,NULL };
Signature · 1 line
2.35.1
How about "nodelist", instead of "nodes_list"? It is more concise and follows the convention of:
/sys/devices/system/nodes/node0/cpulist
Wei
Quoted 83 lines · Huang Ying
In sysfs, we use attribute name "cpus" for cpu mask and "
cpus_list" for cpu list. For example, in my system,$ cat /sys/devices/system/cpu/cpu2/topology/core_cpus 0,00100004 $ cat /sys/devices/system/cpu/cpu2/topology/core_cpus_list 2,20It looks reasonable to use "nodes" for node mask and "
nodes_list" for node list. So, rename the attribute to follow the naming convention.Signed-off-by "Huang, Ying" <[email protected]>Cc Aneesh Kumar K.V <[email protected]>Cc Alistair Popple <[email protected]>Cc Bharata B Rao <[email protected]>Cc Dan Williams <[email protected]>Cc Dave Hansen <[email protected]>Cc Davidlohr Bueso <[email protected]>Cc Hesham Almatary <[email protected]>Cc Jagdish Gediya <[email protected]>Cc Johannes Weiner <[email protected]>Cc Jonathan Cameron <[email protected]>Cc Michal Hocko <[email protected]>Cc Tim Chen <[email protected]>Cc Wei Xu <[email protected]>Cc Yang Shi <[email protected]>--- Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers | 4 ++-- mm/memory-tiers.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-)Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers +2
-2@@ -10,7 +10,7 @@ Description: A collection of all the memory tiers allocated. What: /sys/devices/virtual/memory_tiering/memory_tierN/ - /sys/devices/virtual/memory_tiering/memory_tierN/nodes + /sys/devices/virtual/memory_tiering/memory_tierN/nodes_list Date: August 2022 Contact: Linux memory management mailing list <[email protected]> Description: Directory with details of a specific memory tier@@ -21,5 +21,5 @@ Description: Directory with details of a specific memory tier A smaller value of N implies a higher (faster) memory tier in the hierarchy. - nodes: NUMA nodes that are part of this memory tier. + nodes_list: NUMA nodes that are part of this memory tier.mm/memory-tiers.c +4
-5@@ -131,8 +131,8 @@ static void memory_tier_device_release(struct device *dev)kfree (tier); } -static ssize_t nodes_show (struct device *dev, -struct device_attribute *attr,char *buf) +static ssize_t nodes_list_show (struct device *dev, +struct device_attribute *attr,char *buf) {int ret;nodemask_t nmask;@@ -143,10 +143,10 @@ static ssize_t nodes_show(struct device *dev,mutex_unlock (&memory_tier_lock);return ret; } -static DEVICE_ATTR_RO (nodes); +static DEVICE_ATTR_RO (nodes_list);static struct attribute *memtier_dev_attrs[] = { - &dev_attr_nodes.attr, + &dev_attr_nodes_list.attr,NULL }; --2.35.1
Quoted 4 lines · Wei Xu
How about "nodelist", instead of "
nodes_list"? It is more concise and follows the convention of:
/sys/devices/system/nodes/node0/cpulist
Sounds good to me.
It seems that cpumap/cpulist is another pair of mask/list.
/sys/devices/system/node/node0/cpumap/sys/devices/system/node/node0/cpulist
/sys/devices/system/cpu/cpu0/cache/index1/shared_cpu_map /sys/devices/system/cpu/cpu0/cache/index1/shared_cpu_list
Best Regards,
Huang, Ying
Quoted 84 lines · Huang Ying
Quoted 83 lines
In sysfs, we use attribute name "cpus" for cpu mask and "
cpus_list" for cpu list. For example, in my system,$ cat /sys/devices/system/cpu/cpu2/topology/core_cpus 0,00100004 $ cat /sys/devices/system/cpu/cpu2/topology/core_cpus_list 2,20It looks reasonable to use "nodes" for node mask and "
nodes_list" for node list. So, rename the attribute to follow the naming convention.Signed-off-by "Huang, Ying" <[email protected]>Cc Aneesh Kumar K.V <[email protected]>Cc Alistair Popple <[email protected]>Cc Bharata B Rao <[email protected]>Cc Dan Williams <[email protected]>Cc Dave Hansen <[email protected]>Cc Davidlohr Bueso <[email protected]>Cc Hesham Almatary <[email protected]>Cc Jagdish Gediya <[email protected]>Cc Johannes Weiner <[email protected]>Cc Jonathan Cameron <[email protected]>Cc Michal Hocko <[email protected]>Cc Tim Chen <[email protected]>Cc Wei Xu <[email protected]>Cc Yang Shi <[email protected]>--- Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers | 4 ++-- mm/memory-tiers.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-)Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers +2
-2@@ -10,7 +10,7 @@ Description: A collection of all the memory tiers allocated. What: /sys/devices/virtual/memory_tiering/memory_tierN/ - /sys/devices/virtual/memory_tiering/memory_tierN/nodes + /sys/devices/virtual/memory_tiering/memory_tierN/nodes_list Date: August 2022 Contact: Linux memory management mailing list <[email protected]> Description: Directory with details of a specific memory tier@@ -21,5 +21,5 @@ Description: Directory with details of a specific memory tier A smaller value of N implies a higher (faster) memory tier in the hierarchy. - nodes: NUMA nodes that are part of this memory tier. + nodes_list: NUMA nodes that are part of this memory tier.mm/memory-tiers.c +4
-5@@ -131,8 +131,8 @@ static void memory_tier_device_release(struct device *dev)kfree (tier); } -static ssize_t nodes_show (struct device *dev, -struct device_attribute *attr,char *buf) +static ssize_t nodes_list_show (struct device *dev, +struct device_attribute *attr,char *buf) {int ret;nodemask_t nmask;@@ -143,10 +143,10 @@ static ssize_t nodes_show(struct device *dev,mutex_unlock (&memory_tier_lock);return ret; } -static DEVICE_ATTR_RO (nodes); +static DEVICE_ATTR_RO (nodes_list);static struct attribute *memtier_dev_attrs[] = { - &dev_attr_nodes.attr, + &dev_attr_nodes_list.attr,NULL }; --2.35.1