Skip to contentSkip to conversation

qemu.inc: add virtio input in required dependencies

PATCH In review [email protected] 2 participants 4 messages Oct 18, 2022 – Oct 26, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qemu.inc: add virtio input in required dependencies

From: Thomas Perrot <[email protected]>

Otherwise, it isn't possible to interact with the UI of images that provide graphic support.

This issue only occurs when NO_RECOMMENDATIONS = "1" for Qemu targets which are kernel-modules in MACHINE_EXTRA_RRECOMMENDS.

---
 meta/conf/machine/include/qemu.inc | 2 ++
 1 file changed, 2 insertions(+)
meta/conf/machine/include/qemu.inc +2 -0
index 0d71bcbbad0d..dabe7ed8f386 100644
@@ -10,6 +10,8 @@ XSERVER ?= "xserver-xorg \
             xf86-video-fbdev \
             "
 
+MACHINE_EXTRA_RDEPENDS += "kernel-module-virtio-input"
+
 MACHINE_FEATURES = "alsa bluetooth usbgadget screen vfat"
 
 MACHINEOVERRIDES =. "qemuall:"
Signature · 1 line
2.37.3
#1 lore raw
Quoted 18 lines · Thomas Perrot via lists.openembedded.org

From: Thomas Perrot <[email protected]>

Otherwise, it isn't possible to interact with the UI of images that provide graphic support.

This issue only occurs when NO_RECOMMENDATIONS = "1" for Qemu targets which are kernel-modules in MACHINE_EXTRA_RRECOMMENDS.

---
 meta/conf/machine/include/qemu.inc | 2 ++
 1 file changed, 2 insertions(+)
meta/conf/machine/include/qemu.inc +0 -0
index 0d71bcbbad0d..dabe7ed8f386 100644

meta/conf/machine/include/qemu.inc XSERVER ?= "xserver-xorg \ · line 17

Quoted 8 lines
meta/conf/machine/include/qemu.inc +2 -0
@@ -10,6 +10,8 @@ XSERVER ?= "xserver-xorg \
             xf86-video-fbdev \
             "
 
+MACHINE_EXTRA_RDEPENDS += "kernel-module-virtio-input"
+
 MACHINE_FEATURES = "alsa bluetooth usbgadget screen vfat"
 
 MACHINEOVERRIDES =. "qemuall:"

This will fail if the kernel has the module built in - kernel modules are always recommends for that reason. We'll have to find a different solution I'm afraid.

Cheers,

Richard

#2 lore raw

Hello Richard,

Quoted 25 lines · Richard Purdie
Quoted 23 lines · Thomas Perrot via lists.openembedded.org

From: Thomas Perrot <[email protected]>

Otherwise, it isn't possible to interact with the UI of images that provide graphic support.

This issue only occurs when NO_RECOMMENDATIONS = "1" for Qemu targets which are kernel-modules in MACHINE_EXTRA_RRECOMMENDS.

---
 meta/conf/machine/include/qemu.inc | 2 ++

 1 file changed, 2 insertions(+)
meta/conf/machine/include/qemu.inc +0 -0
index 0d71bcbbad0d..dabe7ed8f386 100644
@@ -10,6 +10,8 @@ XSERVER ?= "xserver-xorg \
              xf86-video-fbdev \

             "

+MACHINE_EXTRA_RDEPENDS += "kernel-module-virtio-input"

Quoted 8 lines
Quoted 4 lines

+
 MACHINE_FEATURES = "alsa bluetooth usbgadget screen vfat"
 MACHINEOVERRIDES =. "qemuall:"

This will fail if the kernel has the module built in - kernel modules are always recommends for that reason. We'll have to find a different solution I'm afraid.

When this kernel module is built in, so the Qemu boot process stalled:
"please wait: booting..."
For this reason, is the proposed solution acceptable?

Kind regards,
Thomas

Quoted 17 lines

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#172150):
https://lists.openembedded.org/g/openembedded-core/message/172150
Mute This Topic: https://lists.openembedded.org/mt/94404446/5443093
Group Owner: [email protected] Unsubscribe:
https://lists.openembedded.org/g/openembedded-core/unsub [
[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
#3 lore raw
Quoted 37 lines · Thomas Perrot

Hello Richard,

Quoted 25 lines · Richard Purdie
Quoted 23 lines · Thomas Perrot via lists.openembedded.org

From: Thomas Perrot <[email protected]>

Otherwise, it isn't possible to interact with the UI of images that provide graphic support.

This issue only occurs when NO_RECOMMENDATIONS = "1" for Qemu targets which are kernel-modules in MACHINE_EXTRA_RRECOMMENDS.

---
 meta/conf/machine/include/qemu.inc | 2 ++

 1 file changed, 2 insertions(+)
meta/conf/machine/include/qemu.inc +0 -0
index 0d71bcbbad0d..dabe7ed8f386 100644
@@ -10,6 +10,8 @@ XSERVER ?= "xserver-xorg \
              xf86-video-fbdev \

             "

+MACHINE_EXTRA_RDEPENDS += "kernel-module-virtio-input"

Quoted 8 lines
Quoted 4 lines

+
 MACHINE_FEATURES = "alsa bluetooth usbgadget screen vfat"
 MACHINEOVERRIDES =. "qemuall:"

This will fail if the kernel has the module built in - kernel modules are always recommends for that reason. We'll have to find a different solution I'm afraid.

Quoted 3 lines

When this kernel module is built in, so the Qemu boot process stalled:
"please wait: booting..."
For this reason, is the proposed solution acceptable?

Not really.

Is there some special reason building that module in could cause a hang? That sounds rather like a kernel bug :(.

It would be near impossible to explain to users why some kernel modules are reccommends and some are not which is why I don't really want to start listing modules as RDEPENDS.

Cheers,

Richard