drm/i915/selftests: Stop using kthread_stop()
Subsystems (2)
PATCH 1/1 drm/i915/selftests: Stop using kthread_stop()
From: Tvrtko Ursulin <[email protected]>
Since a7c01fa93aeb ("signal: break out of wait loops on kthread_stop()") kthread_stop() started asserting a pending signal which wreaks havoc with a few of our selftests. Mainly because they are not fully expecting to handle signals, but also cutting the intended test runtimes short due signal_pending() now returning true (via __igt_timeout), which therefore breaks both the patterns of:
kthread_run()
..sleep for igt_timeout_ms to allow test to exercise stuff.. kthread_stop()
And check for errors recorded in the thread.
And also:
Main thread | Test thread
---------------+------------------------------
kthread_run() |
kthread_stop() | do stuff until __igt_timeout
| -- exits early due signal --
Where this kthread_stop() was assume would have a "join" semantics, which it would have had if not the new signal assertion issue.
To recap, threads are now likely to catch a previously impossible ERESTARTSYS or EINTR, marking the test as failed, or have a pointlessly short run time.
To work around this start using kthread_work(er) API which provides an explicit way of waiting for threads to exit. And for cases where parent controls the test duration we add explicit signaling which threads will now use instead of relying on kthread_should_stop().
--- .../drm/i915/gem/selftests/i915_gem_context.c | 118 ++++---- drivers/gpu/drm/i915/gt/selftest_execlists.c | 48 ++-- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 51 ++-- drivers/gpu/drm/i915/selftests/i915_request.c | 252 +++++++++++------- 4 files changed, 281 insertions(+), 188 deletions(-)
drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c +66 -52
@@ -179,97 +179,108 @@ static int live_nop_switch(void *arg) }struct parallel_switch { -struct task_struct *tsk; +struct kthread_worker *worker; +struct kthread_work work;struct intel_context *ce[2 ]; +int result; }; -static int __live_parallel_switch1 (void *data) +static void __live_parallel_switch1 (struct kthread_work *work) { -struct parallel_switch *arg = data; +struct parallel_switch *arg = +container_of (work,typeof (*arg), work);IGT_TIMEOUT (end_time);unsigned long count; count =0 ; + arg->result =0 ;do {struct i915_request *rq =NULL ; -int err, n; +int n; - err =0 ; -for (n =0 ; !err && n <ARRAY_SIZE (arg->ce); n++) { +for (n =0 ; !arg->result && n <ARRAY_SIZE (arg->ce); n++) {struct i915_request *prev = rq; rq =i915_request_create (arg->ce[n]);if (IS_ERR (rq)) {i915_request_put (prev); -return PTR_ERR (rq); + arg->result =PTR_ERR (rq); +break ; }i915_request_get (rq);if (prev) { - err =i915_request_await_dma_fence (rq, &prev->fence); + arg->result = +i915_request_await_dma_fence (rq, + &prev->fence);i915_request_put (prev); }i915_request_add (rq); } + +if (IS_ERR_OR_NULL (rq)) +break ; +if (i915_request_wait (rq,0 ,HZ ) <0 ) - err = -ETIME ; + arg->result = -ETIME ; +i915_request_put (rq); -if (err) -return err; count++; - }while (!__igt_timeout (end_time,NULL )); + }while (!arg->result && !__igt_timeout (end_time,NULL )); -pr_info ("%s: %lu switches (sync)\n" , arg->ce[0 ]->engine->name, count); -return 0 ; +pr_info ("%s: %lu switches (sync) <%d>\n" , + arg->ce[0 ]->engine->name, count, arg->result); } -static int __live_parallel_switchN (void *data) +static void __live_parallel_switchN (struct kthread_work *work) { -struct parallel_switch *arg = data; +struct parallel_switch *arg = +container_of (work,typeof (*arg), work);struct i915_request *rq =NULL ;IGT_TIMEOUT (end_time);unsigned long count;int n; count =0 ; + arg->result =0 ;do { -for (n =0 ; n <ARRAY_SIZE (arg->ce); n++) { +for (n =0 ; !arg->result && n <ARRAY_SIZE (arg->ce); n++) {struct i915_request *prev = rq; -int err =0 ; rq =i915_request_create (arg->ce[n]);if (IS_ERR (rq)) {i915_request_put (prev); -return PTR_ERR (rq); + arg->result =PTR_ERR (rq); +break ; }i915_request_get (rq);if (prev) { - err =i915_request_await_dma_fence (rq, &prev->fence); + arg->result = +i915_request_await_dma_fence (rq, + &prev->fence);i915_request_put (prev); }i915_request_add (rq); -if (err) { -i915_request_put (rq); -return err; - } } count++; - }while (!__igt_timeout (end_time,NULL )); -i915_request_put (rq); + }while (!arg->result && !__igt_timeout (end_time,NULL )); -pr_info ("%s: %lu switches (many)\n" , arg->ce[0 ]->engine->name, count); -return 0 ; +if (!IS_ERR_OR_NULL (rq)) +i915_request_put (rq); + +pr_info ("%s: %lu switches (many) <%d>\n" , + arg->ce[0 ]->engine->name, count, arg->result); }static int live_parallel_switch (void *arg) {struct drm_i915_private *i915 = arg; -static int (*const func[])(void *arg) = { +static void (*const func[])(struct kthread_work *) = { __live_parallel_switch1, __live_parallel_switchN,NULL ,
@@ -277,7 +288,7 @@ static int live_parallel_switch(void *arg)struct parallel_switch *data =NULL ;struct i915_gem_engines *engines;struct i915_gem_engines_iter it; -int (*const *fn)(void *arg); +void (*const *fn)(struct kthread_work *);struct i915_gem_context *ctx;struct intel_context *ce;struct file *file;
@@ -348,9 +359,22 @@ static int live_parallel_switch(void *arg) } } +for (n =0 ; n < count; n++) { +struct kthread_worker *worker; + +if (!data[n].ce[0 ]) +continue ; + + worker =kthread_create_worker (0 ,"igt/parallel:%s" , + data[n].ce[0 ]->engine->name); +if (IS_ERR (worker)) + goto out; + + data[n].worker = worker; + } +for (fn = func; !err && *fn; fn++) {struct igt_live_test t; -int n; err =igt_live_test_begin (&t, i915, __func__,"" );if (err)
@@ -360,30 +384,17 @@ static int live_parallel_switch(void *arg)if (!data[n].ce[0 ])continue ; - data[n].tsk =kthread_run (*fn, &data[n], -"igt/parallel:%s" , - data[n].ce[0 ]->engine->name); -if (IS_ERR (data[n].tsk)) { - err =PTR_ERR (data[n].tsk); -break ; - } -get_task_struct (data[n].tsk); + data[n].result =0 ; +kthread_init_work (&data[n].work, *fn); +kthread_queue_work (data[n].worker, &data[n].work); } -yield ();/* start all threads before we kthread_stop() */ -for (n =0 ; n < count; n++) { -int status; - -if (IS_ERR_OR_NULL (data[n].tsk)) -continue ; - - status =kthread_stop (data[n].tsk); -if (status && !err) - err = status; - -put_task_struct (data[n].tsk); - data[n].tsk =NULL ; +if (data[n].ce[0 ]) { +kthread_flush_work (&data[n].work); +if (data[n].result && !err) + err = data[n].result; + } }if (igt_live_test_end (&t))
@@ -399,6 +410,9 @@ static int live_parallel_switch(void *arg)intel_context_unpin (data[n].ce[m]);intel_context_put (data[n].ce[m]); } + +if (data[n].worker) +kthread_destroy_worker (data[n].worker); }kfree (data); out_file:
drivers/gpu/drm/i915/gt/selftest_execlists.c +23 -25
106 lines not on this page · raw message
drivers/gpu/drm/i915/gt/selftest_hangcheck.c +30 -21
116 lines not on this page · raw message
drivers/gpu/drm/i915/selftests/i915_request.c +162 -90
520 lines not on this page · raw message
Signature · 1 line
2.34.1
Quoted 331 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Since
a7c01fa93aeb("signal: break out of wait loops onkthread_stop()")kthread_stop()started asserting a pending signal which wreaks havoc with a few of our selftests. Mainly because they are not fully expecting to handle signals, but also cutting the intended test runtimes short duesignal_pending()now returning true (via__igt_timeout), which therefore breaks both the patterns of:
kthread_run()
..sleep forigt_timeout_msto allow test to exercise stuff..kthread_stop()And check for errors recorded in the thread.
And also:
Main thread | Test thread
---------------+------------------------------
kthread_run()|
kthread_stop()| do stuff until__igt_timeout
| -- exits early due signal --Where this
kthread_stop()was assume would have a "join" semantics, which it would have had if not the new signal assertion issue.To recap, threads are now likely to catch a previously impossible ERESTARTSYS or EINTR, marking the test as failed, or have a pointlessly short run time.
To work around this start using
kthread_work(er)API which provides an explicit way of waiting for threads to exit. And for cases where parent controls the test duration we add explicit signaling which threads will now use instead of relying onkthread_should_stop().Signed-off-by Tvrtko Ursulin <[email protected]>Cc Ville Syrjälä <[email protected]>--- .../drm/i915/gem/selftests/i915_gem_context.c | 118 ++++---- drivers/gpu/drm/i915/gt/selftest_execlists.c | 48 ++-- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 51 ++-- drivers/gpu/drm/i915/selftests/i915_request.c | 252 +++++++++++------- 4 files changed, 281 insertions(+), 188 deletions(-)drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c +66
-52@@ -179,97 +179,108 @@ static int live_nop_switch(void *arg) }struct parallel_switch { -struct task_struct *tsk; +struct kthread_worker *worker; +struct kthread_work work;struct intel_context *ce[2 ]; +int result; }; -static int __live_parallel_switch1 (void *data) +static void __live_parallel_switch1 (struct kthread_work *work) { -struct parallel_switch *arg = data; +struct parallel_switch *arg = +container_of (work,typeof (*arg), work);IGT_TIMEOUT (end_time);unsigned long count; count =0 ; + arg->result =0 ;do {struct i915_request *rq =NULL ; -int err, n; +int n; - err =0 ; -for (n =0 ; !err && n <ARRAY_SIZE (arg->ce); n++) { +for (n =0 ; !arg->result && n <ARRAY_SIZE (arg->ce); n++) {struct i915_request *prev = rq; rq =i915_request_create (arg->ce[n]);if (IS_ERR (rq)) {i915_request_put (prev); -return PTR_ERR (rq); + arg->result =PTR_ERR (rq); +break ; }i915_request_get (rq);if (prev) { - err =i915_request_await_dma_fence (rq, &prev->fence); + arg->result = +i915_request_await_dma_fence (rq, + &prev->fence);i915_request_put (prev); }i915_request_add (rq); } + +if (IS_ERR_OR_NULL (rq)) +break ; +if (i915_request_wait (rq,0 ,HZ ) <0 ) - err = -ETIME ; + arg->result = -ETIME ; +i915_request_put (rq); -if (err) -return err; count++; - }while (!__igt_timeout (end_time,NULL )); + }while (!arg->result && !__igt_timeout (end_time,NULL )); -pr_info ("%s: %lu switches (sync)\n" , arg->ce[0 ]->engine->name, count); -return 0 ; +pr_info ("%s: %lu switches (sync) <%d>\n" , + arg->ce[0 ]->engine->name, count, arg->result); } -static int __live_parallel_switchN (void *data) +static void __live_parallel_switchN (struct kthread_work *work) { -struct parallel_switch *arg = data; +struct parallel_switch *arg = +container_of (work,typeof (*arg), work);struct i915_request *rq =NULL ;IGT_TIMEOUT (end_time);unsigned long count;int n; count =0 ; + arg->result =0 ;do { -for (n =0 ; n <ARRAY_SIZE (arg->ce); n++) { +for (n =0 ; !arg->result && n <ARRAY_SIZE (arg->ce); n++) {struct i915_request *prev = rq; -int err =0 ; rq =i915_request_create (arg->ce[n]);if (IS_ERR (rq)) {i915_request_put (prev); -return PTR_ERR (rq); + arg->result =PTR_ERR (rq); +break ; }i915_request_get (rq);if (prev) { - err =i915_request_await_dma_fence (rq, &prev->fence); + arg->result = +i915_request_await_dma_fence (rq, + &prev->fence);i915_request_put (prev); }i915_request_add (rq); -if (err) { -i915_request_put (rq); -return err; - } } count++; - }while (!__igt_timeout (end_time,NULL )); -i915_request_put (rq); + }while (!arg->result && !__igt_timeout (end_time,NULL )); -pr_info ("%s: %lu switches (many)\n" , arg->ce[0 ]->engine->name, count); -return 0 ; +if (!IS_ERR_OR_NULL (rq)) +i915_request_put (rq); + +pr_info ("%s: %lu switches (many) <%d>\n" , + arg->ce[0 ]->engine->name, count, arg->result); }static int live_parallel_switch (void *arg) {struct drm_i915_private *i915 = arg; -static int (*const func[])(void *arg) = { +static void (*const func[])(struct kthread_work *) = { __live_parallel_switch1, __live_parallel_switchN,NULL ,@@ -277,7 +288,7 @@ static int live_parallel_switch(void *arg)struct parallel_switch *data =NULL ;struct i915_gem_engines *engines;struct i915_gem_engines_iter it; -int (*const *fn)(void *arg); +void (*const *fn)(struct kthread_work *);struct i915_gem_context *ctx;struct intel_context *ce;struct file *file;@@ -348,9 +359,22 @@ static int live_parallel_switch(void *arg) } } +for (n =0 ; n < count; n++) { +struct kthread_worker *worker; + +if (!data[n].ce[0 ]) +continue ; + + worker =kthread_create_worker (0 ,"igt/parallel:%s" , + data[n].ce[0 ]->engine->name); +if (IS_ERR (worker)) + goto out; + + data[n].worker = worker; + } +for (fn = func; !err && *fn; fn++) {struct igt_live_test t; -int n; err =igt_live_test_begin (&t, i915, __func__,"" );if (err)@@ -360,30 +384,17 @@ static int live_parallel_switch(void *arg)if (!data[n].ce[0 ])continue ; - data[n].tsk =kthread_run (*fn, &data[n], -"igt/parallel:%s" , - data[n].ce[0 ]->engine->name); -if (IS_ERR (data[n].tsk)) { - err =PTR_ERR (data[n].tsk); -break ; - } -get_task_struct (data[n].tsk); + data[n].result =0 ; +kthread_init_work (&data[n].work, *fn); +kthread_queue_work (data[n].worker, &data[n].work); } -yield ();/* start all threads before we kthread_stop() */ -for (n =0 ; n < count; n++) { -int status; - -if (IS_ERR_OR_NULL (data[n].tsk)) -continue ; - - status =kthread_stop (data[n].tsk); -if (status && !err) - err = status; - -put_task_struct (data[n].tsk); - data[n].tsk =NULL ; +if (data[n].ce[0 ]) { +kthread_flush_work (&data[n].work); +if (data[n].result && !err) + err = data[n].result; + } }if (igt_live_test_end (&t))@@ -399,6 +410,9 @@ static int live_parallel_switch(void *arg)intel_context_unpin (data[n].ce[m]);intel_context_put (data[n].ce[m]); } + +if (data[n].worker) +kthread_destroy_worker (data[n].worker); }kfree (data); out_file:drivers/gpu/drm/i915/gt/selftest_execlists.c +10
-11@@ -3473,12 +3473,14 @@ static int random_priority(struct rnd_state *rnd)struct preempt_smoke {struct intel_gt *gt; +struct kthread_work work;struct i915_gem_context **contexts;struct intel_engine_cs *engine;struct drm_i915_gem_object *batch;unsigned int ncontext;struct rnd_state prng;unsigned long count; +int result; };static struct i915_gem_context *smoke_context (struct preempt_smoke *smoke)@@ -3538,34 +3540,31 @@ static int smoke_submit(struct preempt_smoke *smoke,return err; } -static int smoke_crescendo_thread (void *arg) +static void smoke_crescendo_work (struct kthread_work *work) { -struct preempt_smoke *smoke = arg; +struct preempt_smoke *smoke =container_of (work,typeof (*smoke), work);IGT_TIMEOUT (end_time);unsigned long count; count =0 ;do {struct i915_gem_context *ctx =smoke_context (smoke); -int err; - err =smoke_submit (smoke, - ctx, count %I915_PRIORITY_MAX , - smoke->batch); -if (err) -return err; + smoke->result =smoke_submit (smoke, ctx, + count %I915_PRIORITY_MAX , + smoke->batch); count++; - }while (count < smoke->ncontext && !__igt_timeout (end_time,NULL )); + }while (!smoke->result && count < smoke->ncontext && + !__igt_timeout (end_time,NULL )); smoke->count = count; -return 0 ; }static int smoke_crescendo (struct preempt_smoke *smoke,unsigned int flags) #define BATCH BIT(0) { -struct task_struct *tsk[I915_NUM_ENGINES ] = {}; +struct kthread_worker *worker[I915_NUM_ENGINES ] = {};struct preempt_smoke *arg;struct intel_engine_cs *engine;enum intel_engine_id id;
drivers/gpu/drm/i915/gt/selftest_execlists.c static int smoke_crescendo(struct preempt_smoke *smoke, unsigned int flags) · line 3578
Quoted 4 lines
drivers/gpu/drm/i915/gt/selftest_execlists.c +1
-0@@ -3576,6 +3575,8 @@ static int smoke_crescendo(struct preempt_smoke *smoke, unsigned int flags)if (!arg)return -ENOMEM ; +memset (arg,0 ,I915_NUM_ENGINES *sizeof (*arg));
kcalloc()?
Quoted 151 lines
drivers/gpu/drm/i915/gt/selftest_execlists.c +12
-14+for_each_engine (engine, smoke->gt, id) { arg[id] = *smoke; arg[id].engine = engine;@@ -3583,31 +3584,28 @@ static int smoke_crescendo(struct preempt_smoke *smoke, unsigned int flags) arg[id].batch =NULL ; arg[id].count =0 ; - tsk[id] =kthread_run (smoke_crescendo_thread, arg, -"igt/smoke:%d" , id); -if (IS_ERR (tsk[id])) { - err =PTR_ERR (tsk[id]); + worker[id] =kthread_create_worker (0 ,"igt/smoke:%d" , id); +if (IS_ERR (worker[id])) { + err =PTR_ERR (worker[id]);break ; } -get_task_struct (tsk[id]); - } -yield ();/* start all threads before we kthread_stop() */ +kthread_init_work (&arg[id].work, smoke_crescendo_work); +kthread_queue_work (worker[id], &arg[id].work); + } count =0 ;for_each_engine (engine, smoke->gt, id) { -int status; - -if (IS_ERR_OR_NULL (tsk[id])) +if (IS_ERR_OR_NULL (worker[id]))continue ; - status =kthread_stop (tsk[id]); -if (status && !err) - err = status; +kthread_flush_work (&arg[id].work); +if (arg[id].result && !err) + err = arg[id].result; count += arg[id].count; -put_task_struct (tsk[id]); +kthread_destroy_worker (worker[id]); } pr_info("Submitted %lu crescendo:%x requests across %d engines and %d contexts\n",drivers/gpu/drm/i915/gt/selftest_hangcheck.c +24
-18@@ -866,10 +866,13 @@ static int igt_reset_active_engine(void *arg) }struct active_engine { -struct task_struct *task; +struct kthread_worker *worker; +struct kthread_work work;struct intel_engine_cs *engine;unsigned long resets;unsigned int flags; +bool stop; +int result; };#define TEST_ACTIVE BIT(0)@@ -900,10 +903,10 @@ static int active_request_put(struct i915_request *rq)return err; } -static int active_engine (void *data) +static void active_engine (struct kthread_work *work) {I915_RND_STATE (prng); -struct active_engine *arg = data; +struct active_engine *arg =container_of (work,typeof (*arg), work);struct intel_engine_cs *engine = arg->engine;struct i915_request *rq[8 ] = {};struct intel_context *ce[ARRAY_SIZE (rq)];@@ -913,16 +916,17 @@ static int active_engine(void *data)for (count =0 ; count <ARRAY_SIZE (ce); count++) { ce[count] =intel_context_create (engine);if (IS_ERR (ce[count])) { - err =PTR_ERR (ce[count]); -pr_err ("[%s] Create context #%ld failed: %d!\n" , engine->name, count, err); + arg->result =PTR_ERR (ce[count]); +pr_err ("[%s] Create context #%ld failed: %d!\n" , + engine->name, count, arg->result);while (--count)intel_context_put (ce[count]); -return err; +return ; } } count =0 ; -while (!kthread_should_stop ()) { +while (!READ_ONCE (arg->stop)) {unsigned int idx = count++ & (ARRAY_SIZE (rq) -1 );struct i915_request *old = rq[idx];struct i915_request *new;@@ -967,7 +971,7 @@ static int active_engine(void *data)intel_context_put (ce[count]); } -return err; + arg->result = err; } static int __igt_reset_engines(struct intel_gt *gt,@@ -1022,7 +1026,7 @@ static int __igt_reset_engines(struct intel_gt *gt,memset (threads,0 ,sizeof (*threads) *I915_NUM_ENGINES );for_each_engine (other, gt, tmp) { -struct task_struct *tsk; +struct kthread_worker *worker; threads[tmp].resets =i915_reset_engine_count (global, other);@@ -1036,19 +1040,21 @@ static int __igt_reset_engines(struct intel_gt *gt, threads[tmp].engine = other; threads[tmp].flags = flags; - tsk =kthread_run (active_engine, &threads[tmp], -"igt/%s" , other->name); -if (IS_ERR (tsk)) { - err =PTR_ERR (tsk); -pr_err ("[%s] Thread spawn failed: %d!\n" , engine->name, err); + worker =kthread_create_worker (0 ,"igt/%s" , + other->name); +if (IS_ERR (worker)) { + err =PTR_ERR (worker); +pr_err ("[%s] Worker create failed: %d!\n" , + engine->name, err); goto unwind; } - threads[tmp].task = tsk; -get_task_struct (tsk); - } + threads[tmp].worker = worker; -yield ();/* start all threads before we begin */ +kthread_init_work (&threads[tmp].work, active_engine); +kthread_queue_work (threads[tmp].worker, + &threads[tmp].work); + }st_engine_heartbeat_disable_no_pm (engine); GEM_BUG_ON(test_and_set_bit(I915_RESET_ENGINE + id,
drivers/gpu/drm/i915/gt/selftest_hangcheck.c static int __igt_reset_engines(struct intel_gt *gt, · line 1210
Quoted 10 lines
drivers/gpu/drm/i915/gt/selftest_hangcheck.c +3
-2@@ -1197,17 +1203,20 @@ static int __igt_reset_engines(struct intel_gt *gt,for_each_engine (other, gt, tmp) {int ret; -if (!threads[tmp].task) +if (!threads[tmp].worker)continue ; - ret =kthread_stop (threads[tmp].task); +WRITE_ONCE (threads[tmp].stop, true); +kthread_flush_work (&threads[tmp].work);
Could perhaps optimize things a bit flagging all the threads to stop before doing any flush_work()s. And maybe also do all the init stuff before queuing any works. But dunno if that's worth the hassle.
Looks reasonable enough to me.
Signature · 2 lines
Ville Syrjälä Intel
Quoted 335 lines · Ville Syrjälä
Quoted 334 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Since
a7c01fa93aeb("signal: break out of wait loops onkthread_stop()")kthread_stop()started asserting a pending signal which wreaks havoc with a few of our selftests. Mainly because they are not fully expecting to handle signals, but also cutting the intended test runtimes short duesignal_pending()now returning true (via__igt_timeout), which therefore breaks both the patterns of:
kthread_run()
..sleep forigt_timeout_msto allow test to exercise stuff..kthread_stop()And check for errors recorded in the thread.
And also:
Main thread | Test thread
---------------+------------------------------
kthread_run()|
kthread_stop()| do stuff until__igt_timeout
| -- exits early due signal --Where this
kthread_stop()was assume would have a "join" semantics, which it would have had if not the new signal assertion issue.To recap, threads are now likely to catch a previously impossible ERESTARTSYS or EINTR, marking the test as failed, or have a pointlessly short run time.
To work around this start using
kthread_work(er)API which provides an explicit way of waiting for threads to exit. And for cases where parent controls the test duration we add explicit signaling which threads will now use instead of relying onkthread_should_stop().Signed-off-by Tvrtko Ursulin <[email protected]>Cc Ville Syrjälä <[email protected]>--- .../drm/i915/gem/selftests/i915_gem_context.c | 118 ++++---- drivers/gpu/drm/i915/gt/selftest_execlists.c | 48 ++-- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 51 ++-- drivers/gpu/drm/i915/selftests/i915_request.c | 252 +++++++++++------- 4 files changed, 281 insertions(+), 188 deletions(-)drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c +66
-52@@ -179,97 +179,108 @@ static int live_nop_switch(void *arg) }struct parallel_switch { -struct task_struct *tsk; +struct kthread_worker *worker; +struct kthread_work work;struct intel_context *ce[2 ]; +int result; }; -static int __live_parallel_switch1 (void *data) +static void __live_parallel_switch1 (struct kthread_work *work) { -struct parallel_switch *arg = data; +struct parallel_switch *arg = +container_of (work,typeof (*arg), work);IGT_TIMEOUT (end_time);unsigned long count; count =0 ; + arg->result =0 ;do {struct i915_request *rq =NULL ; -int err, n; +int n; - err =0 ; -for (n =0 ; !err && n <ARRAY_SIZE (arg->ce); n++) { +for (n =0 ; !arg->result && n <ARRAY_SIZE (arg->ce); n++) {struct i915_request *prev = rq; rq =i915_request_create (arg->ce[n]);if (IS_ERR (rq)) {i915_request_put (prev); -return PTR_ERR (rq); + arg->result =PTR_ERR (rq); +break ; }i915_request_get (rq);if (prev) { - err =i915_request_await_dma_fence (rq, &prev->fence); + arg->result = +i915_request_await_dma_fence (rq, + &prev->fence);i915_request_put (prev); }i915_request_add (rq); } + +if (IS_ERR_OR_NULL (rq)) +break ; +if (i915_request_wait (rq,0 ,HZ ) <0 ) - err = -ETIME ; + arg->result = -ETIME ; +i915_request_put (rq); -if (err) -return err; count++; - }while (!__igt_timeout (end_time,NULL )); + }while (!arg->result && !__igt_timeout (end_time,NULL )); -pr_info ("%s: %lu switches (sync)\n" , arg->ce[0 ]->engine->name, count); -return 0 ; +pr_info ("%s: %lu switches (sync) <%d>\n" , + arg->ce[0 ]->engine->name, count, arg->result); } -static int __live_parallel_switchN (void *data) +static void __live_parallel_switchN (struct kthread_work *work) { -struct parallel_switch *arg = data; +struct parallel_switch *arg = +container_of (work,typeof (*arg), work);struct i915_request *rq =NULL ;IGT_TIMEOUT (end_time);unsigned long count;int n; count =0 ; + arg->result =0 ;do { -for (n =0 ; n <ARRAY_SIZE (arg->ce); n++) { +for (n =0 ; !arg->result && n <ARRAY_SIZE (arg->ce); n++) {struct i915_request *prev = rq; -int err =0 ; rq =i915_request_create (arg->ce[n]);if (IS_ERR (rq)) {i915_request_put (prev); -return PTR_ERR (rq); + arg->result =PTR_ERR (rq); +break ; }i915_request_get (rq);if (prev) { - err =i915_request_await_dma_fence (rq, &prev->fence); + arg->result = +i915_request_await_dma_fence (rq, + &prev->fence);i915_request_put (prev); }i915_request_add (rq); -if (err) { -i915_request_put (rq); -return err; - } } count++; - }while (!__igt_timeout (end_time,NULL )); -i915_request_put (rq); + }while (!arg->result && !__igt_timeout (end_time,NULL )); -pr_info ("%s: %lu switches (many)\n" , arg->ce[0 ]->engine->name, count); -return 0 ; +if (!IS_ERR_OR_NULL (rq)) +i915_request_put (rq); + +pr_info ("%s: %lu switches (many) <%d>\n" , + arg->ce[0 ]->engine->name, count, arg->result); }static int live_parallel_switch (void *arg) {struct drm_i915_private *i915 = arg; -static int (*const func[])(void *arg) = { +static void (*const func[])(struct kthread_work *) = { __live_parallel_switch1, __live_parallel_switchN,NULL ,@@ -277,7 +288,7 @@ static int live_parallel_switch(void *arg)struct parallel_switch *data =NULL ;struct i915_gem_engines *engines;struct i915_gem_engines_iter it; -int (*const *fn)(void *arg); +void (*const *fn)(struct kthread_work *);struct i915_gem_context *ctx;struct intel_context *ce;struct file *file;@@ -348,9 +359,22 @@ static int live_parallel_switch(void *arg) } } +for (n =0 ; n < count; n++) { +struct kthread_worker *worker; + +if (!data[n].ce[0 ]) +continue ; + + worker =kthread_create_worker (0 ,"igt/parallel:%s" , + data[n].ce[0 ]->engine->name); +if (IS_ERR (worker)) + goto out; + + data[n].worker = worker; + } +for (fn = func; !err && *fn; fn++) {struct igt_live_test t; -int n; err =igt_live_test_begin (&t, i915, __func__,"" );if (err)@@ -360,30 +384,17 @@ static int live_parallel_switch(void *arg)if (!data[n].ce[0 ])continue ; - data[n].tsk =kthread_run (*fn, &data[n], -"igt/parallel:%s" , - data[n].ce[0 ]->engine->name); -if (IS_ERR (data[n].tsk)) { - err =PTR_ERR (data[n].tsk); -break ; - } -get_task_struct (data[n].tsk); + data[n].result =0 ; +kthread_init_work (&data[n].work, *fn); +kthread_queue_work (data[n].worker, &data[n].work); } -yield ();/* start all threads before we kthread_stop() */ -for (n =0 ; n < count; n++) { -int status; - -if (IS_ERR_OR_NULL (data[n].tsk)) -continue ; - - status =kthread_stop (data[n].tsk); -if (status && !err) - err = status; - -put_task_struct (data[n].tsk); - data[n].tsk =NULL ; +if (data[n].ce[0 ]) { +kthread_flush_work (&data[n].work); +if (data[n].result && !err) + err = data[n].result; + } }if (igt_live_test_end (&t))@@ -399,6 +410,9 @@ static int live_parallel_switch(void *arg)intel_context_unpin (data[n].ce[m]);intel_context_put (data[n].ce[m]); } + +if (data[n].worker) +kthread_destroy_worker (data[n].worker); }kfree (data); out_file:drivers/gpu/drm/i915/gt/selftest_execlists.c +10
-11@@ -3473,12 +3473,14 @@ static int random_priority(struct rnd_state *rnd)struct preempt_smoke {struct intel_gt *gt; +struct kthread_work work;struct i915_gem_context **contexts;struct intel_engine_cs *engine;struct drm_i915_gem_object *batch;unsigned int ncontext;struct rnd_state prng;unsigned long count; +int result; };static struct i915_gem_context *smoke_context (struct preempt_smoke *smoke)@@ -3538,34 +3540,31 @@ static int smoke_submit(struct preempt_smoke *smoke,return err; } -static int smoke_crescendo_thread (void *arg) +static void smoke_crescendo_work (struct kthread_work *work) { -struct preempt_smoke *smoke = arg; +struct preempt_smoke *smoke =container_of (work,typeof (*smoke), work);IGT_TIMEOUT (end_time);unsigned long count; count =0 ;do {struct i915_gem_context *ctx =smoke_context (smoke); -int err; - err =smoke_submit (smoke, - ctx, count %I915_PRIORITY_MAX , - smoke->batch); -if (err) -return err; + smoke->result =smoke_submit (smoke, ctx, + count %I915_PRIORITY_MAX , + smoke->batch); count++; - }while (count < smoke->ncontext && !__igt_timeout (end_time,NULL )); + }while (!smoke->result && count < smoke->ncontext && + !__igt_timeout (end_time,NULL )); smoke->count = count; -return 0 ; }static int smoke_crescendo (struct preempt_smoke *smoke,unsigned int flags) #define BATCH BIT(0) { -struct task_struct *tsk[I915_NUM_ENGINES ] = {}; +struct kthread_worker *worker[I915_NUM_ENGINES ] = {};struct preempt_smoke *arg;struct intel_engine_cs *engine;enum intel_engine_id id;@@ -3576,6 +3575,8 @@ static int smoke_crescendo(struct preempt_smoke *smoke, unsigned int flags)if (!arg)return -ENOMEM ;
Quoted 3 lines
drivers/gpu/drm/i915/gt/selftest_execlists.c static int smoke_crescendo(struct preempt_smoke *smoke, unsigned int flags) · line 3578
Quoted 1 line
drivers/gpu/drm/i915/gt/selftest_execlists.c +1
-0+memset (arg,0 ,I915_NUM_ENGINES *sizeof (*arg));
kcalloc()?
Yeah, answer below.
Quoted 159 lines
Quoted 159 lines
drivers/gpu/drm/i915/gt/selftest_execlists.c +12
-14+for_each_engine (engine, smoke->gt, id) { arg[id] = *smoke; arg[id].engine = engine;@@ -3583,31 +3584,28 @@ static int smoke_crescendo(struct preempt_smoke *smoke, unsigned int flags) arg[id].batch =NULL ; arg[id].count =0 ; - tsk[id] =kthread_run (smoke_crescendo_thread, arg, -"igt/smoke:%d" , id); -if (IS_ERR (tsk[id])) { - err =PTR_ERR (tsk[id]); + worker[id] =kthread_create_worker (0 ,"igt/smoke:%d" , id); +if (IS_ERR (worker[id])) { + err =PTR_ERR (worker[id]);break ; } -get_task_struct (tsk[id]); - } -yield ();/* start all threads before we kthread_stop() */ +kthread_init_work (&arg[id].work, smoke_crescendo_work); +kthread_queue_work (worker[id], &arg[id].work); + } count =0 ;for_each_engine (engine, smoke->gt, id) { -int status; - -if (IS_ERR_OR_NULL (tsk[id])) +if (IS_ERR_OR_NULL (worker[id]))continue ; - status =kthread_stop (tsk[id]); -if (status && !err) - err = status; +kthread_flush_work (&arg[id].work); +if (arg[id].result && !err) + err = arg[id].result; count += arg[id].count; -put_task_struct (tsk[id]); +kthread_destroy_worker (worker[id]); } pr_info("Submitted %lu crescendo:%x requests across %d engines and %d contexts\n",drivers/gpu/drm/i915/gt/selftest_hangcheck.c +25
-19@@ -866,10 +866,13 @@ static int igt_reset_active_engine(void *arg) }struct active_engine { -struct task_struct *task; +struct kthread_worker *worker; +struct kthread_work work;struct intel_engine_cs *engine;unsigned long resets;unsigned int flags; +bool stop; +int result; };#define TEST_ACTIVE BIT(0)@@ -900,10 +903,10 @@ static int active_request_put(struct i915_request *rq)return err; } -static int active_engine (void *data) +static void active_engine (struct kthread_work *work) {I915_RND_STATE (prng); -struct active_engine *arg = data; +struct active_engine *arg =container_of (work,typeof (*arg), work);struct intel_engine_cs *engine = arg->engine;struct i915_request *rq[8 ] = {};struct intel_context *ce[ARRAY_SIZE (rq)];@@ -913,16 +916,17 @@ static int active_engine(void *data)for (count =0 ; count <ARRAY_SIZE (ce); count++) { ce[count] =intel_context_create (engine);if (IS_ERR (ce[count])) { - err =PTR_ERR (ce[count]); -pr_err ("[%s] Create context #%ld failed: %d!\n" , engine->name, count, err); + arg->result =PTR_ERR (ce[count]); +pr_err ("[%s] Create context #%ld failed: %d!\n" , + engine->name, count, arg->result);while (--count)intel_context_put (ce[count]); -return err; +return ; } } count =0 ; -while (!kthread_should_stop ()) { +while (!READ_ONCE (arg->stop)) {unsigned int idx = count++ & (ARRAY_SIZE (rq) -1 );struct i915_request *old = rq[idx];struct i915_request *new;@@ -967,7 +971,7 @@ static int active_engine(void *data)intel_context_put (ce[count]); } -return err; + arg->result = err; } static int __igt_reset_engines(struct intel_gt *gt,@@ -1022,7 +1026,7 @@ static int __igt_reset_engines(struct intel_gt *gt,memset (threads,0 ,sizeof (*threads) *I915_NUM_ENGINES );for_each_engine (other, gt, tmp) { -struct task_struct *tsk; +struct kthread_worker *worker; threads[tmp].resets =i915_reset_engine_count (global, other);@@ -1036,19 +1040,21 @@ static int __igt_reset_engines(struct intel_gt *gt, threads[tmp].engine = other; threads[tmp].flags = flags; - tsk =kthread_run (active_engine, &threads[tmp], -"igt/%s" , other->name); -if (IS_ERR (tsk)) { - err =PTR_ERR (tsk); -pr_err ("[%s] Thread spawn failed: %d!\n" , engine->name, err); + worker =kthread_create_worker (0 ,"igt/%s" , + other->name); +if (IS_ERR (worker)) { + err =PTR_ERR (worker); +pr_err ("[%s] Worker create failed: %d!\n" , + engine->name, err); goto unwind; } - threads[tmp].task = tsk; -get_task_struct (tsk); - } + threads[tmp].worker = worker; -yield ();/* start all threads before we begin */ +kthread_init_work (&threads[tmp].work, active_engine); +kthread_queue_work (threads[tmp].worker, + &threads[tmp].work); + }st_engine_heartbeat_disable_no_pm (engine); GEM_BUG_ON(test_and_set_bit(I915_RESET_ENGINE + id,@@ -1197,17 +1203,20 @@ static int __igt_reset_engines(struct intel_gt *gt,for_each_engine (other, gt, tmp) {int ret; -if (!threads[tmp].task) +if (!threads[tmp].worker)continue ;
Quoted 8 lines
drivers/gpu/drm/i915/gt/selftest_hangcheck.c static int __igt_reset_engines(struct intel_gt *gt, · line 1210
Quoted 3 lines
drivers/gpu/drm/i915/gt/selftest_hangcheck.c +2
-1- ret =kthread_stop (threads[tmp].task); +WRITE_ONCE (threads[tmp].stop, true); +kthread_flush_work (&threads[tmp].work);Could perhaps optimize things a bit flagging all the threads to stop before doing any flush_work()s. And maybe also do all the init stuff before queuing any works. But dunno if that's worth the hassle.
Init stage probably isn't worth complicating, but stopping would be nicer indeed to happen more in sync across threads. Mostly for cases where some sort of metrics per thread is output, and where stop points are relatively spread out.
I will leave it all for a follow up though. If this version happens to get a green CI light I will just merge it as is to restore CI coverage and unblock things.
Quoted 2 lines
Looks reasonable enough to me.
Reviewed-by Ville Syrjälä <[email protected]>
Thanks!
Regards,
Tvrtko
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Stop using kthread_stop()
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915/selftests: Stop using kthread_stop()
URL : https://patchwork.freedesktop.org/series/109953/
State : warning
== Summary ==
Error: dim checkpatch failed3e7e152706c8 drm/i915/selftests: Stop using kthread_stop()
-:9: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit a7c01fa93aeb ("signal: break out of wait loops on kthread_stop()")' #9:
Since a7c01fa93aeb ("signal: break out of wait loops on kthread_stop()")
total: 1 errors, 0 warnings, 0 checks, 957 lines checked
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Stop using kthread_stop()
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915/selftests: Stop using kthread_stop()
URL : https://patchwork.freedesktop.org/series/109953/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12267 -> Patchwork_109953v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/index.html
Participating hosts (46 -> 44)
------------------------------
Additional (2): bat-atsm-1 fi-tgl-dsi
Missing (4): fi-ctg-p8600 fi-icl-u2 fi-bdw-samus fi-hsw-4200u
Known issues
------------
Here are the changes found in Patchwork_109953v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][1] -> [INCOMPLETE][2] ([i915#4785])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/fi-hsw-4770/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/fi-hsw-4770/igt@i915_selftest@[email protected]
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][3] ([fdo#109271] / [i915#4312] / [i915#5594])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/fi-hsw-4770/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rplp-1}: [DMESG-WARN][4] ([i915#2867]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/bat-rplp-1/igt@gem_exec_suspend@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/bat-rplp-1/igt@gem_exec_suspend@[email protected]
- {bat-adlm-1}: [DMESG-WARN][6] ([i915#2867]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/bat-adlm-1/igt@gem_exec_suspend@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/bat-adlm-1/igt@gem_exec_suspend@[email protected]
* igt@i915_selftest@live@gem_contexts:
- {bat-dg2-9}: [DMESG-FAIL][8] ([i915#7270]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/bat-dg2-9/igt@i915_selftest@live@gem_contexts.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/bat-dg2-9/igt@i915_selftest@live@gem_contexts.html
- fi-kbl-7567u: [DMESG-FAIL][10] ([i915#7270]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/fi-kbl-7567u/igt@i915_selftest@live@gem_contexts.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/fi-kbl-7567u/igt@i915_selftest@live@gem_contexts.html
- fi-hsw-g3258: [DMESG-FAIL][12] ([i915#7270]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/fi-hsw-g3258/igt@i915_selftest@live@gem_contexts.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/fi-hsw-g3258/igt@i915_selftest@live@gem_contexts.html
- {bat-jsl-1}: [DMESG-FAIL][14] ([i915#7270]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/bat-jsl-1/igt@i915_selftest@live@gem_contexts.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/bat-jsl-1/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@requests:
- {bat-dg2-9}: [DMESG-FAIL][16] ([i915#7269]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/bat-dg2-9/igt@i915_selftest@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/bat-dg2-9/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [DMESG-FAIL][18] ([i915#4983]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/bat-rpls-2/igt@i915_selftest@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/bat-rpls-2/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6559]: https://gitlab.freedesktop.org/drm/intel/issues/6559
[i915#6856]: https://gitlab.freedesktop.org/drm/intel/issues/6856
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7030]: https://gitlab.freedesktop.org/drm/intel/issues/7030
[i915#7125]: https://gitlab.freedesktop.org/drm/intel/issues/7125
[i915#7269]: https://gitlab.freedesktop.org/drm/intel/issues/7269
[i915#7270]: https://gitlab.freedesktop.org/drm/intel/issues/7270
Build changes
-------------
* Linux: CI_DRM_12267 -> Patchwork_109953v1
CI-20190529: 20190529
CI_DRM_12267: 1e08742713bca00944d4d38d1080a14dbfa649dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7020: 05b7eaf9ade2216d17c069c89439015757ee25f7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109953v1: 1e08742713bca00944d4d38d1080a14dbfa649dc @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
53fa010f12a9 drm/i915/selftests: Stop using kthread_stop()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Stop using kthread_stop()
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915/selftests: Stop using kthread_stop()
URL : https://patchwork.freedesktop.org/series/109953/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12267_full -> Patchwork_109953v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_109953v1_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-apl: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [FAIL][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50]) ([i915#4386])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl1/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl1/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl1/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl1/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl2/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl2/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl2/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl3/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl3/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl3/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl6/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl6/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl6/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl6/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl7/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl7/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl7/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl7/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl8/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl8/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl8/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl8/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl8/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl6/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl6/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl3/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl3/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl3/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl3/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl2/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl2/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl2/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl2/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl2/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl1/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl1/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl1/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl8/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl8/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl8/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl8/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl7/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl7/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl7/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl7/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl6/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl6/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl6/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@hang:
- shard-skl: NOTRUN -> [SKIP][51] ([fdo#109271]) +54 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl6/igt@[email protected]
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [PASS][52] -> [SKIP][53] ([i915#4525]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb4/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-iclb5/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-skl: NOTRUN -> [FAIL][54] ([i915#2846])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl6/igt@[email protected]
* igt@gem_exec_suspend@basic-s3@smem:
- shard-apl: [PASS][55] -> [DMESG-WARN][56] ([i915#180]) +4 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl8/igt@gem_exec_suspend@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl2/igt@gem_exec_suspend@[email protected]
* igt@gem_lmem_swapping@heavy-multi:
- shard-apl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#4613])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl3/igt@[email protected]
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-skl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#4613])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl6/igt@[email protected]
* igt@gem_userptr_blits@input-checking:
- shard-skl: NOTRUN -> [DMESG-WARN][59] ([i915#4991])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl6/igt@[email protected]
* igt@gem_userptr_blits@readonly-unsync:
- shard-tglb: NOTRUN -> [SKIP][60] ([i915#3297])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-tglb1/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [PASS][61] -> [SKIP][62] ([i915#4281])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb5/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-iclb3/igt@[email protected]
* igt@i915_pm_rps@engine-order:
- shard-apl: NOTRUN -> [FAIL][63] ([i915#6537])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl3/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- shard-skl: [PASS][64] -> [DMESG-FAIL][65] ([i915#5334])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl2/igt@i915_selftest@live@gt_heartbeat.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl10/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-apl: NOTRUN -> [SKIP][66] ([fdo#109271]) +65 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl3/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-tglb: NOTRUN -> [SKIP][67] ([i915#5286])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-tglb1/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-tglb: [PASS][68] -> [FAIL][69] ([i915#3743]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb3/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-tglb6/igt@[email protected]
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#3886])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl2/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#3886]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl2/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_color_chamelium@ctm-max:
- shard-skl: NOTRUN -> [SKIP][72] ([fdo#109271] / [fdo#111827]) +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl6/igt@[email protected]
* igt@kms_color_chamelium@ctm-negative:
- shard-apl: NOTRUN -> [SKIP][73] ([fdo#109271] / [fdo#111827]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl3/igt@[email protected]
* igt@kms_content_protection@legacy@pipe-a-dp-1:
- shard-apl: NOTRUN -> [INCOMPLETE][74] ([i915#1319] / [i915#7121] / [i915#7173])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl3/igt@kms_content_protection@[email protected]
* igt@kms_content_protection@uevent@pipe-a-dp-1:
- shard-apl: NOTRUN -> [FAIL][75] ([i915#1339] / [i915#7144])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl3/igt@kms_content_protection@[email protected]
* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-tglb: NOTRUN -> [SKIP][76] ([fdo#109274] / [fdo#111825] / [i915#3637])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-tglb1/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [PASS][77] -> [FAIL][78] ([i915#79]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl1/igt@kms_flip@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl6/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-skl: [PASS][79] -> [INCOMPLETE][80] ([i915#4939])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl6/igt@kms_flip@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@c-edp1:
- shard-skl: [PASS][81] -> [INCOMPLETE][82] ([i915#4839])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl4/igt@kms_flip@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][83] ([i915#2587] / [i915#2672]) +3 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-iclb7/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][84] ([i915#6375])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][85] ([i915#2672]) +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][86] ([i915#2672] / [i915#3555])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][87] ([i915#6497])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1:
- shard-iclb: [PASS][88] -> [SKIP][89] ([i915#5176]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb5/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#658]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl6/igt@[email protected]
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-apl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#658])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl3/igt@[email protected]
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][92] -> [SKIP][93] ([fdo#109441])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-iclb7/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-b-query-busy:
- shard-skl: [PASS][94] -> [DMESG-WARN][95] ([i915#1982])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl2/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl10/igt@[email protected]
* igt@kms_writeback@writeback-invalid-parameters:
- shard-skl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#2437])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl6/igt@[email protected]
* igt@sysfs_clients@fair-0:
- shard-apl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#2994]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl3/igt@[email protected]
* igt@sysfs_clients@fair-3:
- shard-skl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#2994])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl10/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_balancer@parallel:
- shard-iclb: [SKIP][99] ([i915#4525]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb7/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-iclb4/igt@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][101] ([i915#2842]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk6/igt@gem_exec_fair@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-glk6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][103] ([i915#2842]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb5/igt@gem_exec_fair@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-iclb3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-gtt-read-noreloc:
- {shard-rkl}: [SKIP][105] ([i915#3281]) -> [PASS][106] +4 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-1/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-rkl-5/igt@[email protected]
* igt@gem_userptr_blits@forbidden-operations:
- {shard-rkl}: [SKIP][107] ([i915#3282]) -> [PASS][108] +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-3/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-rkl-5/igt@[email protected]
* igt@gen9_exec_parse@secure-batches:
- {shard-rkl}: [SKIP][109] ([i915#2527]) -> [PASS][110] +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-1/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-rkl-5/igt@[email protected]
* igt@i915_pm_rps@min-max-config-idle:
- {shard-rkl}: [FAIL][111] ([i915#7142]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-6/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-rkl-4/igt@[email protected]
* igt@i915_selftest@live@gem_contexts:
- shard-glk: [DMESG-FAIL][113] ([i915#7270]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk2/igt@i915_selftest@live@gem_contexts.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-glk3/igt@i915_selftest@live@gem_contexts.html
* igt@kms_cursor_crc@cursor-sliding-256x256@pipe-a-hdmi-a-1:
- shard-glk: [DMESG-WARN][115] ([i915#118]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk8/igt@kms_cursor_crc@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-glk1/igt@kms_cursor_crc@[email protected]
* igt@kms_cursor_crc@cursor-suspend@pipe-b-edp-1:
- shard-tglb: [INCOMPLETE][117] -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb1/igt@kms_cursor_crc@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-tglb1/igt@kms_cursor_crc@[email protected]
* igt@kms_cursor_legacy@short-flip-before-cursor@atomic-transitions-varying-size:
- shard-skl: [FAIL][119] ([i915#3927]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl9/igt@kms_cursor_legacy@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl1/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2:
- shard-glk: [FAIL][121] ([i915#79]) -> [PASS][122] +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk2/igt@kms_flip@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-glk1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [FAIL][123] ([i915#79]) -> [PASS][124] +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl1/igt@kms_flip@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl6/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt:
- {shard-rkl}: [SKIP][125] ([i915#1849] / [i915#4098]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-2/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-rkl-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [DMESG-WARN][127] ([i915#180]) -> [PASS][128] +2 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl2/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl2/igt@[email protected]
* igt@kms_plane@plane-position-hole-dpms@pipe-b-planes:
- {shard-rkl}: [SKIP][129] ([i915#1849] / [i915#3558]) -> [PASS][130] +1 similar issue
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-2/igt@kms_plane@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-rkl-6/igt@kms_plane@[email protected]
* igt@kms_plane_lowres@tiling-yf@pipe-a-hdmi-a-1:
- shard-glk: [FAIL][131] -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk6/igt@kms_plane_lowres@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-glk6/igt@kms_plane_lowres@[email protected]
* igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
- {shard-rkl}: [SKIP][133] ([i915#1845] / [i915#4098]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-2/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-rkl-6/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-tglb: [FAIL][135] ([i915#5639]) -> [PASS][136]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb3/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-tglb2/igt@[email protected]
* igt@prime_vgem@basic-read:
- {shard-rkl}: [SKIP][137] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][138]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-1/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-rkl-5/igt@[email protected]
* igt@prime_vgem@coherency-gtt:
- {shard-rkl}: [SKIP][139] ([fdo#109295] / [fdo#111656] / [i915#3708]) -> [PASS][140]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-3/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-rkl-5/igt@[email protected]
#### Warnings ####
* igt@gem_pread@exhaustion:
- shard-apl: [WARN][141] ([i915#2658]) -> [INCOMPLETE][142] ([i915#7268])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl8/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl3/igt@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-glk: [INCOMPLETE][143] -> [INCOMPLETE][144] ([i915#7296])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk3/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-glk3/igt@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][145] ([i915#588]) -> [SKIP][146] ([i915#658])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb2/igt@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-iclb7/igt@[email protected]
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-iclb: [SKIP][147] ([i915#658]) -> [SKIP][148] ([i915#2920])
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb7/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][149] ([i915#2920]) -> [SKIP][150] ([fdo#111068] / [i915#658])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb2/igt@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-iclb4/igt@[email protected]
* igt@runner@aborted:
- shard-apl: ([FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155], [FAIL][156], [FAIL][157], [FAIL][158], [FAIL][159]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][160], [FAIL][161], [FAIL][162], [FAIL][163], [FAIL][164], [FAIL][165], [FAIL][166], [FAIL][167], [FAIL][168]) ([i915#180] / [i915#3002] / [i915#4312])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl6/igt@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl2/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl6/igt@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl2/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl8/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl8/igt@[email protected]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl1/igt@[email protected]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl8/igt@[email protected]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl6/igt@[email protected]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl3/igt@[email protected]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl6/igt@[email protected]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl6/igt@[email protected]
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl7/igt@[email protected]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl6/igt@[email protected]
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl7/igt@[email protected]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl3/igt@[email protected]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl2/igt@[email protected]
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-apl2/igt@[email protected]
- shard-skl: ([FAIL][169], [FAIL][170], [FAIL][171], [FAIL][172], [FAIL][173], [FAIL][174]) ([i915#3002] / [i915#4312]) -> ([FAIL][175], [FAIL][176], [FAIL][177], [FAIL][178], [FAIL][179], [FAIL][180]) ([i915#3002] / [i915#4312] / [i915#6949])
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl6/igt@[email protected]
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl2/igt@[email protected]
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl1/igt@[email protected]
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl7/igt@[email protected]
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl9/igt@[email protected]
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl1/igt@[email protected]
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl6/igt@[email protected]
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl1/igt@[email protected]
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl2/igt@[email protected]
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl6/igt@[email protected]
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl4/igt@[email protected]
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/shard-skl4/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1339]: https://gitlab.freedesktop.org/drm/intel/issues/1339
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3692]: https://gitlab.freedesktop.org/drm/intel/issues/3692
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3927]: https://gitlab.freedesktop.org/drm/intel/issues/3927
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4386]: https://gitlab.freedesktop.org/drm/intel/issues/4386
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4839]: https://gitlab.freedesktop.org/drm/intel/issues/4839
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6375]: https://gitlab.freedesktop.org/drm/intel/issues/6375
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6949]: https://gitlab.freedesktop.org/drm/intel/issues/6949
[i915#7121]: https://gitlab.freedesktop.org/drm/intel/issues/7121
[i915#7142]: https://gitlab.freedesktop.org/drm/intel/issues/7142
[i915#7144]: https://gitlab.freedesktop.org/drm/intel/issues/7144
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7268]: https://gitlab.freedesktop.org/drm/intel/issues/7268
[i915#7270]: https://gitlab.freedesktop.org/drm/intel/issues/7270
[i915#7296]: https://gitlab.freedesktop.org/drm/intel/issues/7296
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12267 -> Patchwork_109953v1
CI-20190529: 20190529
CI_DRM_12267: 1e08742713bca00944d4d38d1080a14dbfa649dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7020: 05b7eaf9ade2216d17c069c89439015757ee25f7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109953v1: 1e08742713bca00944d4d38d1080a14dbfa649dc @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109953v1/index.html