Skip to contentSkip to conversation

scripts: checkpatch: allow case x: return #x macros

RFC New Stanislaw Gruszka 1 participant 1 message Oct 20, 2022 Checkpatch

lore
Share & tools
lore
#0 lore raw

RFC 1/1 scripts: checkpatch: allow case x: return #x macros

Do not report errors like below:

./scripts/checkpatch.pl -f drivers/net/wireless/ath/ath10k/wmi.h

ERROR: Macros with complex values should be enclosed in parentheses +#define C2S(x) case x: return #x

since "case x: return #x" macros are already used by some in-kernel drivers.

---
 scripts/checkpatch.pl | 1 +
 1 file changed, 1 insertion(+)
scripts/checkpatch.pl +1 -0
index 1e5e66ae5a52..4b888b1313d5 100755
@@ -5901,6 +5901,7 @@ sub process {
 			    $dstat !~ /$exceptions/ &&
 			    $dstat !~ /^\.$Ident\s*=/ &&				# .foo =
 			    $dstat !~ /^(?:\#\s*$Ident|\#\s*$Constant)\s*$/ &&		# stringification #foo
+			    $dstat !~ /^case\s*$Ident:\s*return\s*#$Ident$/ &&		# case x: return #x
 			    $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ &&	# do {...} while (...); // do {...} while (...)
 			    $dstat !~ /^while\s*$Constant\s*$Constant\s*$/ &&		# while (...) {...}
 			    $dstat !~ /^for\s*$Constant$/ &&				# for (...)
Signature · 1 line
2.25.4