Skip to contentSkip to conversation

runqemu: Fix gl-es argument from causing other arguments to be ignored

PATCH In review Joshua Watt 1 participant 2 messages Oct 21, 2022 – Oct 26, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 runqemu: Fix gl-es argument from causing other arguments to be ignored

The code to parse arguments was inadvertently skipping all arguments in the elif block after gl-es if it was specified on the command line.

---
 scripts/runqemu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/runqemu +1 -1
index 983f7514c7..189fc3da91 100755
@@ -497,7 +497,7 @@ class BaseConfig(object):
                 self.gtk = True
             elif arg == 'gl':
                 self.gl = True
-            elif 'gl-es' in sys.argv[1:]:
+            elif arg == 'gl-es':
                 self.gl_es = True
             elif arg == 'egl-headless':
                 self.egl_headless = True
Signature · 1 line
2.33.0
#1 lore raw

Steve,

Please backport this to kirkstone at your convenience.

Thanks

Quoted 25 lines · Joshua Watt

The code to parse arguments was inadvertently skipping all arguments in the elif block after gl-es if it was specified on the command line.

---
 scripts/runqemu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/runqemu +1 -2
index 983f7514c7..189fc3da91 100755
@@ -497,7 +497,7 @@ class BaseConfig(object):
                 self.gtk = True
             elif arg == 'gl':
                 self.gl = True
-            elif 'gl-es' in sys.argv[1:]:
+            elif arg == 'gl-es':
                 self.gl_es = True
             elif arg == 'egl-headless':
                 self.egl_headless = True
--

2.33.0