kbuild: fix 'Broken pipe' message for AR=gcc-ar
PATCH 1/1 kbuild: fix 'Broken pipe' message for AR=gcc-ar
Since commit 321648455061 ("kbuild: use obj-y instead extra-y for objects placed at the head"), 'make AR=gcc-ar' shows the following message:
/usr/bin/ar terminated with signal 13 [Broken pipe]
The resulting vmlinux is correct, but it is better to silence this.
'head -n1' exits after reading the first line, so the pipe is closed.
Use 'sed -n 1p' to eat the stream till the end.
---
Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
@@ -1218,7 +1218,7 @@ quiet_cmd_ar_vmlinux.a = AR $@ cmd_ar_vmlinux.a = \ rm -f $@; \ $(AR) cDPrST $@ $(KBUILD_VMLINUX_OBJS); \ - $(AR) mPiT $$($(AR) t $@ | head -n1) $@ $$($(AR) t $@ | grep -F --file=$(srctree)/scripts/head-object-list.txt) + $(AR) mPiT $$($(AR) t $@ | sed -n 1p) $@ $$($(AR) t $@ | grep -F --file=$(srctree)/scripts/head-object-list.txt) targets += vmlinux.a vmlinux.a: $(KBUILD_VMLINUX_OBJS) scripts/head-object-list.txt autoksyms_recursive FORCE
Signature · 1 line
2.34.1
Quoted 6 lines · Masahiro Yamada
Since commit 321648455061 ("kbuild: use obj-y instead extra-y for objects placed at the head"), 'make AR=gcc-ar' shows the following message:
/usr/bin/arterminated with signal 13 [Broken pipe]
Not just AR=gcc-ar, but also AR=llvm-ar:
error: write on a pipe with no reader
Note that due to
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8017ce50641c303b9b5d96f3c10229ecfd770a70
we should send a backport to stable like:
https://github.com/engstk/op8/commit/6f2688e3eb4ec06b276e541640d4f06364b68442
Quoted 31 lines
The resulting vmlinux is correct, but it is better to silence this.
'head -n1' exits after reading the first line, so the pipe is closed.
Use 'sed -n 1p' to eat the stream till the end.
Fixes 321648455061 ("kbuild: use obj-y instead extra-y for objects placed at the head")Reported-by Jiri Slaby <[email protected]>Signed-off-by Masahiro Yamada <[email protected]>---
Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Makefile +1
-2@@ -1218,7 +1218,7 @@ quiet_cmd_ar_vmlinux.a = AR $@ cmd_ar_vmlinux.a = \ rm -f $@; \ $(AR) cDPrST $@ $(KBUILD_VMLINUX_OBJS); \ - $(AR) mPiT $$($(AR) t $@ | head -n1) $@ $$($(AR) t $@ | grep -F --file=$(srctree)/scripts/head-object-list.txt) + $(AR) mPiT $$($(AR) t $@ | sed -n 1p) $@ $$($(AR) t $@ | grep -F --file=$(srctree)/scripts/head-object-list.txt) targets += vmlinux.a vmlinux.a: $(KBUILD_VMLINUX_OBJS) scripts/head-object-list.txt autoksyms_recursive FORCE --2.34.1
Signature · 2 lines
Thanks, ~Nick Desaulniers
Quoted 9 lines · Nick Desaulniers
Quoted 6 lines · Masahiro Yamada
Since commit 321648455061 ("kbuild: use obj-y instead extra-y for objects placed at the head"), 'make AR=gcc-ar' shows the following message:
/usr/bin/arterminated with signal 13 [Broken pipe]
Quoted 7 lines
Not just AR=gcc-ar, but also AR=llvm-ar:
error: write on a pipe with no reader
Thank you.
I updated the commit description, and sent v2.
https://lore.kernel.org/linux-kbuild/[email protected]/T/#u
Quoted 4 lines
Note that due to
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8017ce50641c303b9b5d96f3c10229ecfd770a70
we should send a backport to stable like:
https://github.com/engstk/op8/commit/6f2688e3eb4ec06b276e541640d4f06364b68442
Maybe, we can backport 8017ce50641c30 itself,
but I am not sure if it is cleanly applicable.
Signature · 2 lines
Best Regards Masahiro Yamada