tests: Add missing _require_odirect from generic tests
PATCH 1/1 tests: Add missing _require_odirect from generic tests
--- tests/generic/219 | 1 + tests/generic/252 | 1 + tests/generic/446 | 1 + tests/generic/459 | 1 + tests/generic/569 | 1 + tests/generic/570 | 1 + tests/generic/587 | 1 + 7 files changed, 7 insertions(+)
tests/generic/219 +1 -0
@@ -20,6 +20,7 @@ _require_scratch _require_quota _require_user _require_group +_require_odirect test_files() {
tests/generic/252 +1 -0
@@ -27,6 +27,7 @@ _require_scratch _require_dm_target error _require_xfs_io_command "falloc" _require_aiodio "aiocp" +_require_odirect AIO_TEST="$here/src/aio-dio-regress/aiocp" # Disable the scratch rt device to avoid test failures relating to the rt
tests/generic/446 +1 -0
@@ -21,6 +21,7 @@ _begin_fstest auto quick rw punch _require_scratch _require_xfs_io_command "truncate" _require_xfs_io_command "fpunch" +_require_odirect # format and mount _scratch_mkfs > $seqres.full 2>&1
tests/generic/459 +1 -0
@@ -47,6 +47,7 @@ _require_dm_target snapshot _require_command $LVM_PROG lvm _require_command "$THIN_CHECK_PROG" thin_check _require_freeze +_require_odirect vgname=vg_$seq lvname=lv_$seq
tests/generic/569 +1 -0
@@ -25,6 +25,7 @@ _supported_fs generic _require_xfs_io_command "falloc" _require_test_program swapon _require_scratch_swapfile +_require_odirect _scratch_mkfs > $seqres.full 2>&1 _scratch_mount >> $seqres.full 2>&1
tests/generic/570 +1 -0
@@ -25,6 +25,7 @@ _supported_fs generic _require_test_program swapon _require_scratch_nocheck _require_block_device $SCRATCH_DEV +_require_odirect # We cannot create swap on a zoned device because it can cause random write IOs _require_non_zoned_device "$SCRATCH_DEV" test -e /dev/snapshot && _notrun "userspace hibernation to swap is enabled"
tests/generic/587 +1 -0
@@ -25,6 +25,7 @@ _require_user _require_quota _require_xfs_io_command "falloc" _require_scratch +_require_odirect cat > $tmp.awk << ENDL {
Signature · 1 line
2.37.3
Quoted 28 lines · Lukas Czerner
Signed-off-by Lukas Czerner <[email protected]>--- tests/generic/219 | 1 + tests/generic/252 | 1 + tests/generic/446 | 1 + tests/generic/459 | 1 + tests/generic/569 | 1 + tests/generic/570 | 1 + tests/generic/587 | 1 + 7 files changed, 7 insertions(+)tests/generic/219 +1
-0@@ -20,6 +20,7 @@ _require_scratch _require_quota _require_user _require_group +_require_odirect test_files() {tests/generic/252 +0
-0
tests/generic/252 _require_scratch · line 30
Quoted 4 lines
tests/generic/252 +1
-0@@ -27,6 +27,7 @@ _require_scratch _require_dm_target error _require_xfs_io_command "falloc" _require_aiodio "aiocp" +_require_odirect
I think this's a duplication, due to _require_aiodio already contains the _require_odirect. Do you hit any failure on this test?
Others make sense to me.
Thanks,
Zorro
Quoted 66 lines
tests/generic/252 +0
-0AIO_TEST="$here/src/aio-dio-regress/aiocp" # Disable the scratch rt device to avoid test failures relating to the rttests/generic/446 +1
-0@@ -21,6 +21,7 @@ _begin_fstest auto quick rw punch _require_scratch _require_xfs_io_command "truncate" _require_xfs_io_command "fpunch" +_require_odirect # format and mount _scratch_mkfs > $seqres.full 2>&1tests/generic/459 +1
-0@@ -47,6 +47,7 @@ _require_dm_target snapshot _require_command $LVM_PROG lvm _require_command "$THIN_CHECK_PROG" thin_check _require_freeze +_require_odirect vgname=vg_$seq lvname=lv_$seqtests/generic/569 +1
-0@@ -25,6 +25,7 @@ _supported_fs generic _require_xfs_io_command "falloc" _require_test_program swapon _require_scratch_swapfile +_require_odirect _scratch_mkfs > $seqres.full 2>&1 _scratch_mount >> $seqres.full 2>&1tests/generic/570 +1
-0@@ -25,6 +25,7 @@ _supported_fs generic _require_test_program swapon _require_scratch_nocheck _require_block_device $SCRATCH_DEV +_require_odirect # We cannot create swap on a zoned device because it can cause random write IOs _require_non_zoned_device "$SCRATCH_DEV" test -e /dev/snapshot && _notrun "userspace hibernation to swap is enabled"tests/generic/587 +1
-0@@ -25,6 +25,7 @@ _require_user _require_quota _require_xfs_io_command "falloc" _require_scratch +_require_odirect cat > $tmp.awk << ENDL {Signature · 1 line
2.37.3
Quoted 22 lines · Zorro Lang
Quoted 21 lines · Lukas Czerner
Signed-off-by Lukas Czerner <[email protected]>--- tests/generic/219 | 1 + tests/generic/252 | 1 + tests/generic/446 | 1 + tests/generic/459 | 1 + tests/generic/569 | 1 + tests/generic/570 | 1 + tests/generic/587 | 1 + 7 files changed, 7 insertions(+)tests/generic/219 +1
-0@@ -20,6 +20,7 @@ _require_scratch _require_quota _require_user _require_group +_require_odirect
Quoted 14 lines
tests/generic/252 _require_scratch · line 30
Quoted 11 lines
tests/generic/219 +0
-0test_files() {tests/generic/252 +1
-0@@ -27,6 +27,7 @@ _require_scratch _require_dm_target error _require_xfs_io_command "falloc" _require_aiodio "aiocp" +_require_odirectI think this's a duplication, due to
_require_aiodioalready contains the_require_odirect. Do you hit any failure on this test?
Ah, you're right. I'll resend the patch.
Thanks!
-Lukas
Quoted 73 lines
Others make sense to me.
Thanks,
ZorroQuoted 66 lines
tests/generic/252 +0
-0AIO_TEST="$here/src/aio-dio-regress/aiocp" # Disable the scratch rt device to avoid test failures relating to the rttests/generic/446 +1
-0@@ -21,6 +21,7 @@ _begin_fstest auto quick rw punch _require_scratch _require_xfs_io_command "truncate" _require_xfs_io_command "fpunch" +_require_odirect # format and mount _scratch_mkfs > $seqres.full 2>&1tests/generic/459 +1
-0@@ -47,6 +47,7 @@ _require_dm_target snapshot _require_command $LVM_PROG lvm _require_command "$THIN_CHECK_PROG" thin_check _require_freeze +_require_odirect vgname=vg_$seq lvname=lv_$seqtests/generic/569 +1
-0@@ -25,6 +25,7 @@ _supported_fs generic _require_xfs_io_command "falloc" _require_test_program swapon _require_scratch_swapfile +_require_odirect _scratch_mkfs > $seqres.full 2>&1 _scratch_mount >> $seqres.full 2>&1tests/generic/570 +1
-0@@ -25,6 +25,7 @@ _supported_fs generic _require_test_program swapon _require_scratch_nocheck _require_block_device $SCRATCH_DEV +_require_odirect # We cannot create swap on a zoned device because it can cause random write IOs _require_non_zoned_device "$SCRATCH_DEV" test -e /dev/snapshot && _notrun "userspace hibernation to swap is enabled"tests/generic/587 +1
-0@@ -25,6 +25,7 @@ _require_user _require_quota _require_xfs_io_command "falloc" _require_scratch +_require_odirect cat > $tmp.awk << ENDL {Signature · 1 line
2.37.3
PATCH v2 1/1 tests: Add missing _require_odirect from generic tests
In reply to Lukas Czerner---
v2: generic/252 already has _require_odirect, remove it from patch
tests/generic/219 | 1 + tests/generic/446 | 1 + tests/generic/459 | 1 + tests/generic/569 | 1 + tests/generic/570 | 1 + tests/generic/587 | 1 + 6 files changed, 6 insertions(+)
tests/generic/219 +1 -0
@@ -20,6 +20,7 @@ _require_scratch _require_quota _require_user _require_group +_require_odirect test_files() {
tests/generic/446 +1 -0
@@ -21,6 +21,7 @@ _begin_fstest auto quick rw punch _require_scratch _require_xfs_io_command "truncate" _require_xfs_io_command "fpunch" +_require_odirect # format and mount _scratch_mkfs > $seqres.full 2>&1
tests/generic/459 +1 -0
@@ -47,6 +47,7 @@ _require_dm_target snapshot _require_command $LVM_PROG lvm _require_command "$THIN_CHECK_PROG" thin_check _require_freeze +_require_odirect vgname=vg_$seq lvname=lv_$seq
tests/generic/569 +1 -0
@@ -25,6 +25,7 @@ _supported_fs generic _require_xfs_io_command "falloc" _require_test_program swapon _require_scratch_swapfile +_require_odirect _scratch_mkfs > $seqres.full 2>&1 _scratch_mount >> $seqres.full 2>&1
tests/generic/570 +1 -0
@@ -25,6 +25,7 @@ _supported_fs generic _require_test_program swapon _require_scratch_nocheck _require_block_device $SCRATCH_DEV +_require_odirect # We cannot create swap on a zoned device because it can cause random write IOs _require_non_zoned_device "$SCRATCH_DEV" test -e /dev/snapshot && _notrun "userspace hibernation to swap is enabled"
tests/generic/587 +1 -0
@@ -25,6 +25,7 @@ _require_user _require_quota _require_xfs_io_command "falloc" _require_scratch +_require_odirect cat > $tmp.awk << ENDL {
Signature · 1 line
2.37.3
Quoted 3 lines · Lukas Czerner
Signed-off-by Lukas Czerner <[email protected]>---
v2: generic/252 already has_require_odirect, remove it from patch
This version looks good to me,
Quoted 84 lines
tests/generic/219 | 1 + tests/generic/446 | 1 + tests/generic/459 | 1 + tests/generic/569 | 1 + tests/generic/570 | 1 + tests/generic/587 | 1 + 6 files changed, 6 insertions(+)tests/generic/219 +1
-0@@ -20,6 +20,7 @@ _require_scratch _require_quota _require_user _require_group +_require_odirect test_files() {tests/generic/446 +1
-0@@ -21,6 +21,7 @@ _begin_fstest auto quick rw punch _require_scratch _require_xfs_io_command "truncate" _require_xfs_io_command "fpunch" +_require_odirect # format and mount _scratch_mkfs > $seqres.full 2>&1tests/generic/459 +1
-0@@ -47,6 +47,7 @@ _require_dm_target snapshot _require_command $LVM_PROG lvm _require_command "$THIN_CHECK_PROG" thin_check _require_freeze +_require_odirect vgname=vg_$seq lvname=lv_$seqtests/generic/569 +1
-0@@ -25,6 +25,7 @@ _supported_fs generic _require_xfs_io_command "falloc" _require_test_program swapon _require_scratch_swapfile +_require_odirect _scratch_mkfs > $seqres.full 2>&1 _scratch_mount >> $seqres.full 2>&1tests/generic/570 +1
-0@@ -25,6 +25,7 @@ _supported_fs generic _require_test_program swapon _require_scratch_nocheck _require_block_device $SCRATCH_DEV +_require_odirect # We cannot create swap on a zoned device because it can cause random write IOs _require_non_zoned_device "$SCRATCH_DEV" test -e /dev/snapshot && _notrun "userspace hibernation to swap is enabled"tests/generic/587 +1
-0@@ -25,6 +25,7 @@ _require_user _require_quota _require_xfs_io_command "falloc" _require_scratch +_require_odirect cat > $tmp.awk << ENDL {Signature · 1 line
2.37.3