dt-bindings: mfd: ti,am3359-tscadc: change clock-names property to enum
Subsystems (2)
PATCH 1/1 dt-bindings: mfd: ti,am3359-tscadc: change clock-names property to enum
Several J7 platforms use adc_tsc_fck instead of fck for clock naming. To avoid warnings from dt-schema on invalid clock naming; create an enum with both fck, and adc_tsc_fck options.
--- Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml +3 -1
@@ -28,7 +28,9 @@ properties: maxItems: 1 clock-names: - const: fck + enum: + - fck + - adc_tsc_fck dmas: items:
Signature · 1 line
2.38.GIT
Hi Matt,
[email protected] wrote on Mon, 24 Oct 2022 03:07:06 -0700:
Quoted 3 lines
Several J7 platforms use
adc_tsc_fckinstead of fck for clock naming. To avoid warnings from dt-schema on invalid clock naming; create an enum with both fck, andadc_tsc_fckoptions.
Looks like I've missed this definition when introducing the bindings. But in practice this property looks very k3 specific and is not used anywhere else so would it be worth considering renaming the properties in the DT instead? There won't be any backward compatibility issue apparently.
Quoted 10 lines
Signed-off-by Matt Ranostay <[email protected]>--- Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml +0
-0
Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml properties: · line 36
Quoted 10 lines
Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml +3
-1@@ -28,7 +28,9 @@ properties: maxItems: 1 clock-names: - const: fck + enum: + - fck + - adc_tsc_fck dmas: items:
Thanks,
Miquèl
Quoted 8 lines · Miquel Raynal
Hi Matt,
[email protected] wrote on Mon, 24 Oct 2022 03:07:06 -0700:
Quoted 3 lines
Several J7 platforms use
adc_tsc_fckinstead of fck for clock naming. To avoid warnings from dt-schema on invalid clock naming; create an enum with both fck, andadc_tsc_fckoptions.
Quoted 6 lines
Looks like I've missed this definition when introducing the bindings. But in practice this property looks very k3 specific and is not used anywhere else so would it be worth considering renaming the properties in the DT instead? There won't be any backward compatibility issue apparently.
That should work as well, and probably is a better solution. I'll send a patchset in the near future with those changes.
- Matt
Quoted 24 lines
Quoted 10 lines
Signed-off-by Matt Ranostay <[email protected]>--- Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml +0
-0Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml properties: · line 36
Quoted 10 lines
Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml +3
-1@@ -28,7 +28,9 @@ properties: maxItems: 1 clock-names: - const: fck + enum: + - fck + - adc_tsc_fck dmas: items:Thanks,
Miquèl