arm64: dts: qcom: sc8280xp: add TCSR node
PATCH 1/1 arm64: dts: qcom: sc8280xp: add TCSR node
Add the TCSR node which is needed for PCIe configuration.
--- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/qcom/sc8280xp.dtsi +5 -0
@@ -984,6 +984,11 @@ tcsr_mutex: hwlock@1f40000 { #hwlock-cells = <1>; }; + tcsr: syscon@1fc0000 { + compatible = "qcom,sc8280xp-tcsr", "syscon"; + reg = <0x0 0x01fc0000 0x0 0x30000>; + }; + usb_0_hsphy: phy@88e5000 { compatible = "qcom,sc8280xp-usb-hs-phy", "qcom,usb-snps-hs-5nm-phy";
Signature · 1 line
2.37.3
Quoted 5 lines · Johan Hovold
Add the TCSR node which is needed for PCIe configuration.
Signed-off-by Johan Hovold <[email protected]>--- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 5 +++++
Please send the patches together with the binding. There is no need to have this split and it causes additional effort during review - lookup of the binding.
Also additional effort during binding review - lack of usage of bindings.
Best regards,
Krzysztof
Quoted 10 lines · Krzysztof Kozlowski
Quoted 5 lines · Johan Hovold
Add the TCSR node which is needed for PCIe configuration.
Signed-off-by Johan Hovold <[email protected]>--- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 5 +++++Please send the patches together with the binding. There is no need to have this split and it causes additional effort during review - lookup of the binding.
I was under the impression that the dts changes should be submitted separately from the binding as they go through different trees. (And last time I posted them together the subsystem maintainer ended up taking also the dts changes by mistake).
The binding has been picked up by Lee now so I posted the dts change. Could have added a lore link though.
Quoted 5 lines
Also additional effort during binding review - lack of usage of bindings.
Reviewed-by Krzysztof Kozlowski <[email protected]>
Johan
Quoted 8 lines · Johan Hovold
Quoted 7 lines · Krzysztof Kozlowski
Quoted 5 lines · Johan Hovold
Add the TCSR node which is needed for PCIe configuration.
Signed-off-by Johan Hovold <[email protected]>--- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 5 +++++
Quoted 8 lines
Quoted 3 lines
Please send the patches together with the binding. There is no need to have this split and it causes additional effort during review - lookup of the binding.
I was under the impression that the dts changes should be submitted separately from the binding as they go through different trees. (And last time I posted them together the subsystem maintainer ended up taking also the dts changes by mistake).
Yes, that's also true. :)
Quoted 2 lines
The binding has been picked up by Lee now so I posted the dts change. Could have added a lore link though.
This also would work and help a lot.
It depends in general on the maintainer - for example Greg does not want to deal with individual patches, especially if DTS is just one patch and USB would be 10 of them. Our toolset is not good for picking up 10 out of 11. For all such cases - please provide link to lore.
If however there are just two patches - one DTS and one for maintainer - then having them in one patchset should not cause additional effort for the maintainer.
As you can see on the list, majority of patchsets consist of bindings+DTS. Pretty often entire piece - bindings+driver+DTS.
Best regards,
Krzysztof
Quoted 25 lines · Krzysztof Kozlowski
Quoted 8 lines · Johan Hovold
Quoted 7 lines · Krzysztof Kozlowski
Quoted 5 lines · Johan Hovold
Add the TCSR node which is needed for PCIe configuration.
Signed-off-by Johan Hovold <[email protected]>--- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 5 +++++Quoted 8 lines
Quoted 3 lines
Please send the patches together with the binding. There is no need to have this split and it causes additional effort during review - lookup of the binding.
I was under the impression that the dts changes should be submitted separately from the binding as they go through different trees. (And last time I posted them together the subsystem maintainer ended up taking also the dts changes by mistake).
Yes, that's also true. :)
Quoted 2 lines
The binding has been picked up by Lee now so I posted the dts change. Could have added a lore link though.
This also would work and help a lot.
Quoted 8 lines
It depends in general on the maintainer - for example Greg does not want to deal with individual patches, especially if DTS is just one patch and USB would be 10 of them. Our toolset is not good for picking up 10 out of 11. For all such cases - please provide link to lore.
If however there are just two patches - one DTS and one for maintainer - then having them in one patchset should not cause additional effort for the maintainer.
I'm pretty sure I saw Lee complaining about Bjorn taking also the binding update through the qcom tree recently when someone did just that. Apparently it was TCSR related too:
https://lore.kernel.org/all/Yzbk%[email protected]/
Heh. That was you. :)
Quoted 2 lines
As you can see on the list, majority of patchsets consist of bindings+DTS. Pretty often entire piece - bindings+driver+DTS.
Yeah, and whatever alternative you go with, someone will get it wrong or complain it seems.
Johan
Quoted 15 lines · Johan Hovold
Quoted 6 lines
Quoted 3 lines
The binding has been picked up by Lee now so I posted the dts change. Could have added a lore link though.
This also would work and help a lot.
Quoted 8 lines
It depends in general on the maintainer - for example Greg does not want to deal with individual patches, especially if DTS is just one patch and USB would be 10 of them. Our toolset is not good for picking up 10 out of 11. For all such cases - please provide link to lore.
If however there are just two patches - one DTS and one for maintainer - then having them in one patchset should not cause additional effort for the maintainer.
Quoted 7 lines
I'm pretty sure I saw Lee complaining about Bjorn taking also the binding update through the qcom tree recently when someone did just that. Apparently it was TCSR related too:
https://lore.kernel.org/all/Yzbk%[email protected]/
Heh. That was you. :)
Yep. It was a patchset of 16 patches where one should go to MFD and 15 to Qualcomm SoC.
Quoted 6 lines
Quoted 3 lines
As you can see on the list, majority of patchsets consist of bindings+DTS. Pretty often entire piece - bindings+driver+DTS.
Yeah, and whatever alternative you go with, someone will get it wrong or complain it seems.
:)
Best regards,
Krzysztof