media: dvb-core: remove variable n, turn for-loop to while-loop
Subsystems (2)
PATCH 1/1 media: dvb-core: remove variable n, turn for-loop to while-loop
Variable n is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it. This allows the for-loop to be replaced with a while-loop.
Signed-off-by Colin Ian King <[email protected]>
--- drivers/media/dvb-core/dvb_demux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/dvb-core/dvb_demux.c +2 -2
@@ -233,7 +233,7 @@ static int dvb_dmx_swfilter_section_copy_dump(struct dvb_demux_feed *feed, {struct dvb_demux *demux = feed->demux;struct dmx_section_feed *sec = &feed->feed.sec; -u16 limit, seclen, n; +u16 limit, seclen;if (sec->tsfeedp >=DMX_MAX_SECFEED_SIZE )return 0 ;
@@ -262,7 +262,7 @@ static int dvb_dmx_swfilter_section_copy_dump(struct dvb_demux_feed *feed,/* to be sure always set secbuf */ sec->secbuf = sec->secbuf_base + sec->secbufp; -for (n =0 ; sec->secbufp +2 < limit; n++) { +while (sec->secbufp +2 < limit) { seclen =section_length (sec->secbuf);if (seclen <=0 || seclen >DMX_MAX_SECTION_SIZE || seclen + sec->secbufp > limit)
Signature · 1 line
2.37.3
Hi Colin,
Quoted 35 lines · Colin Ian King
Variable n is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it. This allows the for-loop to be replaced with a while-loop.
Signed-off-by Colin Ian King <[email protected]>--- drivers/media/dvb-core/dvb_demux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/media/dvb-core/dvb_demux.c +2
-2@@ -233,7 +233,7 @@ static int dvb_dmx_swfilter_section_copy_dump(struct dvb_demux_feed *feed, {struct dvb_demux *demux = feed->demux;struct dmx_section_feed *sec = &feed->feed.sec; -u16 limit, seclen, n; +u16 limit, seclen;if (sec->tsfeedp >=DMX_MAX_SECFEED_SIZE )return 0 ;@@ -262,7 +262,7 @@ static int dvb_dmx_swfilter_section_copy_dump(struct dvb_demux_feed *feed,/* to be sure always set secbuf */ sec->secbuf = sec->secbuf_base + sec->secbufp; -for (n =0 ; sec->secbufp +2 < limit; n++) { +while (sec->secbufp +2 < limit) { seclen =section_length (sec->secbuf);if (seclen <=0 || seclen >DMX_MAX_SECTION_SIZE || seclen + sec->secbufp > limit)Signature · 1 line
2.37.3
Looks good to me.
We save some space into function stack :)
Reviewed-by Tommaso Merciai <[email protected]>
Regards,
Tommaso
Signature · 10 lines
Tommaso Merciai Embedded Linux Engineer [email protected] __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 [email protected] www.amarulasolutions.com