Skip to contentSkip to conversation

ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1

PATCH Applied Christian Marangi 3 participants 3 messages Oct 25, 2022 – Nov 7, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1

It was reported non working mmc with this option enabled. Both mmc for ipq8064 are supplied by a fixed 3.3v regulator so mmc can't be run at 1.8v.
Disable it to restore correct functionality of this SoC feature.

---
 arch/arm/boot/dts/qcom-ipq8064.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/qcom-ipq8064.dtsi +0 -1
index 90c08b51680a..01ff24560ee6 100644
@@ -756,7 +756,6 @@ sdcc1: mmc@12400000 {
 				non-removable;
 				cap-sd-highspeed;
 				cap-mmc-highspeed;
-				mmc-ddr-1_8v;
 				vmmc-supply = <&vsdcc_fixed>;
 				dmas = <&sdcc1bam 2>, <&sdcc1bam 1>;
 				dma-names = "tx", "rx";
Signature · 1 line
2.37.2
Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 7 lines · Christian Marangi

It was reported non working mmc with this option enabled. Both mmc for ipq8064 are supplied by a fixed 3.3v regulator so mmc can't be run at 1.8v.
Disable it to restore correct functionality of this SoC feature.

Perhaps there's some board where this property makes sense, but it seems like something that should be added when needed in the leaf DTS, and not supplied in the base DTSI. So:

This also fixes problems I've seen on my systems, so:

Thanks!

#2 lore raw
In reply to Christian Marangi
Quoted 6 lines · Christian Marangi

It was reported non working mmc with this option enabled. Both mmc for ipq8064 are supplied by a fixed 3.3v regulator so mmc can't be run at 1.8v.
Disable it to restore correct functionality of this SoC feature.

Applied, thanks!

[1/1] ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1

      commit: c9713e4ede1e5d044b64fe4d3cbb84223625637f

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>