fprobe: Check rethook_alloc() return in rethook initialization
PATCH 1/1 fprobe: Check rethook_alloc() return in rethook initialization
Check if fp->rethook succeeded to be allocated. Otherwise, if rethook_alloc() fails, then we end up dereferencing a NULL pointer in rethook_add_node().
Fixes 5b0ab78998e3 ("fprobe: Add exit_handler support")
Signed-off-by Rafael Mendonca <[email protected]>
--- kernel/trace/fprobe.c | 2 ++ 1 file changed, 2 insertions(+)
kernel/trace/fprobe.c +2 -0
@@ -141,6 +141,8 @@ static int fprobe_init_rethook(struct fprobe *fp, int num)return -E2BIG ; fp->rethook =rethook_alloc ((void *)fp, fprobe_exit_handler); +if (!fp->rethook) +return -ENOMEM ;for (i =0 ; i < size; i++) {struct fprobe_rethook_node *node;
Signature · 1 line
2.34.1
Quoted 3 lines · On Tue, 25 Oct 2022 00:12:08 -0300 Rafael Mendonca <[email protected]>…
Check if
fp->rethooksucceeded to be allocated. Otherwise, ifrethook_alloc()fails, then we end up dereferencing a NULL pointer inrethook_add_node().
Good catch!
Thank you!
Quoted 23 lines
Fixes 5b0ab78998e3 ("fprobe: Add exit_handler support")Signed-off-by Rafael Mendonca <[email protected]>--- kernel/trace/fprobe.c | 2 ++ 1 file changed, 2 insertions(+)kernel/trace/fprobe.c +2
-0@@ -141,6 +141,8 @@ static int fprobe_init_rethook(struct fprobe *fp, int num)return -E2BIG ; fp->rethook =rethook_alloc ((void *)fp, fprobe_exit_handler); +if (!fp->rethook) +return -ENOMEM ;for (i =0 ; i < size; i++) {struct fprobe_rethook_node *node;Signature · 1 line
2.34.1
Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>
Quoted 11 lines · On Tue, 25 Oct 2022 17:03:46 +0900 Masami Hiramatsu (Google)…
Quoted 3 lines · On Tue, 25 Oct 2022 00:12:08 -0300 Rafael Mendonca <[email protected]>…
Check if
fp->rethooksucceeded to be allocated. Otherwise, ifrethook_alloc()fails, then we end up dereferencing a NULL pointer inrethook_add_node().Good catch!
Masami, feel free to pull this in.
-- Steve