Skip to contentSkip to conversation

speakup: include types.h so u_char is a known type

PATCH In review Eric Curtin 2 participants 3 messages Oct 25, 2022 Speakup console speech driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 speakup: include types.h so u_char is a known type

Fixes build of utils.h header file, occurred when building kernel on postmarketOS on Lenovo Duet Chromebook.

drivers/accessibility/speakup/utils.h:57:9: error: unknown type name 'u_char'; did you mean 'char'?

     57 |         u_char *pn = (u_char *)name;
        |         ^~~~~~
        |         char
Fixes 6a5c94d92699 ("speakup: Generate speakupmap.h automatically")
---
 drivers/accessibility/speakup/utils.h | 1 +
 1 file changed, 1 insertion(+)
drivers/accessibility/speakup/utils.h +1 -0
index 4bf2ee8ac246..f6fe477ecb28 100644
@@ -7,6 +7,7 @@
  */
 
 #include <stdio.h>
+#include <sys/types.h>
 
 #define MAXKEYS 512
 #define MAXKEYVAL 160
Signature · 1 line
2.37.3
maintainer
#1 lore raw

Hello,

Eric Curtin, le mar. 25 oct. 2022 11:18:24 +0100, a ecrit:

Quoted 8 lines

Fixes build of utils.h header file, occurred when building kernel on postmarketOS on Lenovo Duet Chromebook.

drivers/accessibility/speakup/utils.h:57:9: error: unknown type name 'u_char'; did you mean 'char'?

     57 |         u_char *pn = (u_char *)name;
        |         ^~~~~~
        |         char

There is already a patch pending commit that just replaces it with unsigned char.

(see
Subject: [PATCH] speakup: replace utils' u_char with unsigned char )

Samuel

#2 lore raw
Quoted 7 lines · Samuel Thibault

Hello,

Eric Curtin, le mar. 25 oct. 2022 11:18:24 +0100, a ecrit:

Quoted 3 lines

Fixes build of utils.h header file, occurred when building kernel on postmarketOS on Lenovo Duet Chromebook.

Quoted 8 lines
Quoted 5 lines

drivers/accessibility/speakup/utils.h:57:9: error: unknown type name 'u_char'; did you mean 'char'?

     57 |         u_char *pn = (u_char *)name;
        |         ^~~~~~
        |         char

There is already a patch pending commit that just replaces it with unsigned char.

Sorry I missed that. that works for me :)

Quoted 7 lines

(see
Subject: [PATCH] speakup: replace utils' u_char with unsigned char )

Samuel