Skip to contentSkip to conversation

net: dp83822: Print the SOR1 strap status

PATCH Applied Fabio Estevam 3 participants 3 messages Oct 25, 2022 – Oct 27, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: dp83822: Print the SOR1 strap status

During the bring-up of the Ethernet PHY, it is very useful to see the bootstrap status information, as it can help identifying hardware bootstrap mistakes.

Allow printing the SOR1 register, which contains the strap status to ease the bring-up.

---
 drivers/net/phy/dp83822.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/phy/dp83822.c +2 -0
index b60db8b6f477..a6f05e35d91f 100644
@@ -524,6 +524,8 @@ static int dp83822_read_straps(struct phy_device *phydev)
 	if (val < 0)
 		return val;
 
+	phydev_dbg(phydev, "SOR1 strap register: 0x%04x\n", val);
+
 	fx_enabled = (val & DP83822_COL_STRAP_MASK) >> DP83822_COL_SHIFT;
 	if (fx_enabled == DP83822_STRAP_MODE2 ||
 	    fx_enabled == DP83822_STRAP_MODE3)
Signature · 1 line
2.25.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Fabio Estevam

During the bring-up of the Ethernet PHY, it is very useful to see the bootstrap status information, as it can help identifying hardware bootstrap mistakes.

Allow printing the SOR1 register, which contains the strap status to ease the bring-up.

Andrew

#2 lore raw
In reply to Fabio Estevam
This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:

Quoted 8 lines · On Tue, 25 Oct 2022 09:01:09 -0300 you wrote:

During the bring-up of the Ethernet PHY, it is very useful to see the bootstrap status information, as it can help identifying hardware bootstrap mistakes.

Allow printing the SOR1 register, which contains the strap status to ease the bring-up.

[...]

Here is the summary with links:
- [net-next] net: dp83822: Print the SOR1 strap status

    https://git.kernel.org/netdev/net-next/c/c926b4c3fa1f

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html