setfsuid02: using -1 as invalid fsuid for setfsuid()
PATCH 1/1 setfsuid02: using -1 as invalid fsuid for setfsuid()
a uid which does not have an entry in the /etc/passwd file is not really an invalid fsuid for setfsuid(), so changing the test to use -1 as an invalid fsuid.
And second setfsuid(-1) call is to verify that preceding call has actually failed and there is no change in the fsuid.
--- testcases/kernel/syscalls/setfsuid/setfsuid02.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
testcases/kernel/syscalls/setfsuid/setfsuid02.c +1 -3
@@ -21,9 +21,7 @@ static void run(void)uid_t invalid_uid, current_uid; current_uid =geteuid (); - invalid_uid =1 ; -while (getpwuid (invalid_uid)) - invalid_uid++; + invalid_uid =-1 ;UID16_CHECK (invalid_uid, setfsuid);
Signature · 5 lines
2.38.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Avinesh,
Quoted 5 lines
a uid which does not have an entry in the
/etc/passwdfile is not really an invalid fsuid forsetfsuid(), so changing the test to use -1 as an invalid fsuid.
And second setfsuid(-1) call is to verify that preceding call has actually failed and there is no change in the fsuid.
Here was supposed to be
as the problem was introduced in your rewrite, right?
testcases/kernel/syscalls/setfsuid/setfsuid02.c static void run(void) · line 24
Quoted 12 lines
testcases/kernel/syscalls/setfsuid/setfsuid02.c +1
-3@@ -21,9 +21,7 @@ static void run(void)uid_t invalid_uid, current_uid; current_uid =geteuid (); - invalid_uid =1 ; -while (getpwuid (invalid_uid)) - invalid_uid++; + invalid_uid =-1 ;
IMHO it should be casted
invalid_uid = (uid_t)-1;
as the code in shadow-utils:
https://github.com/shadow-maint/shadow/blob/eaebea55a495a56317ed85e959b3599f73c6bdf2/src/newusers.c#L342-L345
This does not work on 16-bit version, because uid_t is unsigned int, -1 overflows the allowed value when we do check:
UID16_CHECK(invalid_uid, setfsuid);
setfsuid02.c:26: TBROK: uid -1 of invalid_uid is too large for testing 16-bit version of setfsuid()
It also does not make sense to check invalid_uid, it should have been current_uid in 85f0b8478 (my bad not catching this):
UID16_CHECK(current_uid, setfsuid);
Please, always try to test 16-bit variant (most of us does not bother to test 32-bit compatibility, but at least to see TCONF is worth).
If you agree, I merge it with changes below.
Kind regards,
Petr
kernel/syscalls/setfsuid/setfsuid02.c +2 -2
@@ -21,9 +21,9 @@ static void run(void)uid_t invalid_uid, current_uid; current_uid =geteuid (); - invalid_uid =-1 ; + invalid_uid = (uid_t)-1 ; -UID16_CHECK (invalid_uid, setfsuid); +UID16_CHECK (current_uid, setfsuid);TST_EXP_VAL_SILENT (SETFSUID (invalid_uid), current_uid); TST_EXP_VAL(SETFSUID(invalid_uid), current_uid,
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hello,
Quoted 5 lines · Avinesh Kumar
a uid which does not have an entry in the
/etc/passwdfile is not really an invalid fsuid forsetfsuid(), so changing the test to use -1 as an invalid fsuid.
And second setfsuid(-1) call is to verify that preceding call has actually failed and there is no change in the fsuid.
I think the original test is flawed and testing what using -1 does is not very interesting as the kernel uses standard boilerplate to deal with this.
AFAICT we don't test what happens if a non-root user tries to set the fsuid to a uid that is not the euid, ruid or saved uid or 0/-1.
Possibly that is something for a new test though.
Quoted 23 lines
Signed-off-by Avinesh Kumar <[email protected]>--- testcases/kernel/syscalls/setfsuid/setfsuid02.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)testcases/kernel/syscalls/setfsuid/setfsuid02.c +1
-3@@ -21,9 +21,7 @@ static void run(void)uid_t invalid_uid, current_uid; current_uid =geteuid (); - invalid_uid =1 ; -while (getpwuid (invalid_uid)) - invalid_uid++; + invalid_uid =-1 ;UID16_CHECK (invalid_uid, setfsuid);Signature · 1 line
2.38.0
Signature · 5 lines
Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 8 lines · Petr Vorel
Hi Avinesh,
Quoted 5 lines
a uid which does not have an entry in the
/etc/passwdfile is not really an invalid fsuid forsetfsuid(), so changing the test to use -1 as an invalid fsuid.
And second setfsuid(-1) call is to verify that preceding call has actually failed and there is no change in the fsuid.
Quoted 4 lines
Here was supposed to be
Fixes 85f0b8478 ("setfsuid02: Rewrite using new LTP API")as the problem was introduced in your rewrite, right?
No, the original test was already broken, it just didn't do any real failure checks so it always passed.
Quoted 4 lines
It also does not make sense to check
invalid_uid, it should have beencurrent_uidin85f0b8478(my bad not catching this):
UID16_CHECK(current_uid, setfsuid);
No, UID16_CHECK(invalid_uid, setfsuid); is the correct test call. The test is supposed to verify that trying to set invalid_uid will fail, and the only way to verify that it failed is to call setfsuid(invalid_uid) again and check that it returns current_uid.
Signature · 11 lines
Martin Doucha [email protected] QA Engineer for Software Maintenance SUSE LINUX, s.r.o. CORSO IIa Krizikova 148/34 186 00 Prague 8 Czech Republic -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Martin, Avinesh,
Quoted 9 lines · Petr Vorel
Quoted 7 lines
Hi Avinesh,
Quoted 5 lines
a uid which does not have an entry in the
/etc/passwdfile is not really an invalid fsuid forsetfsuid(), so changing the test to use -1 as an invalid fsuid.
And second setfsuid(-1) call is to verify that preceding call has actually failed and there is no change in the fsuid.
Quoted 7 lines
Quoted 4 lines
Here was supposed to be
Fixes 85f0b8478 ("setfsuid02: Rewrite using new LTP API")as the problem was introduced in your rewrite, right?
No, the original test was already broken, it just didn't do any real failure checks so it always passed.
Right, thanks!
Quoted 9 lines
Quoted 4 lines
It also does not make sense to check
invalid_uid, it should have beencurrent_uidin85f0b8478(my bad not catching this):
UID16_CHECK(current_uid, setfsuid);No,
UID16_CHECK(invalid_uid, setfsuid); is the correct test call. The test is supposed to verify that trying to setinvalid_uidwill fail, and the only way to verify that it failed is to callsetfsuid(invalid_uid)again and check that it returnscurrent_uid.
I'm somehow blind today. UID16_CHECK() in compat_tst_16.h calls UID_SIZE_CHECK(), which just checks the uid value. I don't see setfsuid() call, IMHO that's done in SETFSUID().
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 7 lines · Petr Vorel
Quoted 4 lines
No,
UID16_CHECK(invalid_uid, setfsuid); is the correct test call. The test is supposed to verify that trying to setinvalid_uidwill fail, and the only way to verify that it failed is to callsetfsuid(invalid_uid)again and check that it returnscurrent_uid.I'm somehow blind today.
UID16_CHECK()incompat_tst_16.hcallsUID_SIZE_CHECK(), which just checks the uid value. I don't seesetfsuid()call, IMHO that's done inSETFSUID().
It doesn't make sense to call UID16_CHECK() on a value that we'll never pass to a 16bit syscall, does it?
Signature · 11 lines
Martin Doucha [email protected] QA Engineer for Software Maintenance SUSE LINUX, s.r.o. CORSO IIa Krizikova 148/34 186 00 Prague 8 Czech Republic -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 11 lines · Petr Vorel
Quoted 7 lines
Quoted 4 lines
No,
UID16_CHECK(invalid_uid, setfsuid); is the correct test call. The test is supposed to verify that trying to setinvalid_uidwill fail, and the only way to verify that it failed is to callsetfsuid(invalid_uid)again and check that it returnscurrent_uid.I'm somehow blind today.
UID16_CHECK()incompat_tst_16.hcallsUID_SIZE_CHECK(), which just checks the uid value. I don't seesetfsuid()call, IMHO that's done inSETFSUID().It doesn't make sense to call
UID16_CHECK()on a value that we'll never pass to a 16bit syscall, does it?
Ah, sure, I see current_uid is used for checking only. So what is your suggestion to fix the problem on 16-bit?
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 2 lines · Petr Vorel
Ah, sure, I see
current_uidis used for checking only. So what is your suggestion to fix the problem on 16-bit?
I guess using UID_T (defined in the LTP compat headers) instead of uid_t is the solution, then -1 will be cast to the correct bitsize.
Signature · 11 lines
Martin Doucha [email protected] QA Engineer for Software Maintenance SUSE LINUX, s.r.o. CORSO IIa Krizikova 148/34 186 00 Prague 8 Czech Republic -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 6 lines · Petr Vorel
Quoted 2 lines
Ah, sure, I see
current_uidis used for checking only. So what is your suggestion to fix the problem on 16-bit?I guess using
UID_T(defined in the LTP compat headers) instead ofuid_tis the solution, then -1 will be cast to the correct bitsize.
Thank you, that worked.
Merged, with additional cast to long to keep compiler happy.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 10 lines
Hello,
Quoted 5 lines · Avinesh Kumar
a uid which does not have an entry in the
/etc/passwdfile is not really an invalid fsuid forsetfsuid(), so changing the test to use -1 as an invalid fsuid.
And second setfsuid(-1) call is to verify that preceding call has actually failed and there is no change in the fsuid.
Quoted 8 lines
I think the original test is flawed and testing what using -1 does is not very interesting as the kernel uses standard boilerplate to deal with this.
AFAICT we don't test what happens if a non-root user tries to set the fsuid to a uid that is not the euid, ruid or saved uid or 0/-1.
Possibly that is something for a new test though.
Ah, sorry, I overlooked this, merged now.
Kind regards,
Petr
Quoted 22 lines
Quoted 22 lines
Signed-off-by Avinesh Kumar <[email protected]>--- testcases/kernel/syscalls/setfsuid/setfsuid02.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)testcases/kernel/syscalls/setfsuid/setfsuid02.c +1
-3@@ -21,9 +21,7 @@ static void run(void)uid_t invalid_uid, current_uid; current_uid =geteuid (); - invalid_uid =1 ; -while (getpwuid (invalid_uid)) - invalid_uid++; + invalid_uid =-1 ;UID16_CHECK (invalid_uid, setfsuid);Signature · 1 line
2.38.0
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hello,
Quoted 14 lines · Petr Vorel
Quoted 13 lines
Hello,
Quoted 5 lines · Avinesh Kumar
a uid which does not have an entry in the
/etc/passwdfile is not really an invalid fsuid forsetfsuid(), so changing the test to use -1 as an invalid fsuid.
And second setfsuid(-1) call is to verify that preceding call has actually failed and there is no change in the fsuid.I think the original test is flawed and testing what using -1 does is not very interesting as the kernel uses standard boilerplate to deal with this.
Quoted 6 lines
Quoted 4 lines
AFAICT we don't test what happens if a non-root user tries to set the fsuid to a uid that is not the euid, ruid or saved uid or 0/-1.
Possibly that is something for a new test though.
Ah, sorry, I overlooked this, merged now.
No problem, I think that is the correct thing to do. I'll leave it to Avinesh or someone else to extend the test (or not).
Signature · 5 lines
Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Petr, Martin,
Thank you for the discussion and fixing the patch for 16-bit. I am making a note to always test 16-bit binaries also.
Quoted 7 lines · IST Petr Vorel
Quoted 6 lines · Petr Vorel
Quoted 2 lines
Ah, sure, I see
current_uidis used for checking only. So what is your suggestion to fix the problem on 16-bit?I guess using
UID_T(defined in the LTP compat headers) instead ofuid_tis the solution, then -1 will be cast to the correct bitsize.
Quoted 7 lines
Thank you, that worked.
Merged, with additional cast to long to keep compiler happy.
Kind regards,
Petr
Regards,
Avinesh
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Richie,
Quoted 23 lines · IST Richard Palethorpe
Hello,
Quoted 19 lines · Petr Vorel
Quoted 19 lines
Hello,
Quoted 5 lines · Avinesh Kumar
a uid which does not have an entry in the
/etc/passwdfile is not really an invalid fsuid forsetfsuid(), so changing the test to use -1 as an invalid fsuid.
And second setfsuid(-1) call is to verify that preceding call has actually failed and there is no change in the fsuid.I think the original test is flawed and testing what using -1 does is not very interesting as the kernel uses standard boilerplate to deal with this.
AFAICT we don't test what happens if a non-root user tries to set the fsuid to a uid that is not the euid, ruid or saved uid or 0/-1.
Possibly that is something for a new test though.
I'll post a new patch for this. Thank you for the suggestion.
Quoted 7 lines
Quoted 2 lines
Ah, sorry, I overlooked this, merged now.
No problem, I think that is the correct thing to do. I'll leave it to Avinesh or someone else to extend the test (or not).
Regards,
Avinesh
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp