Skip to contentSkip to conversation

nfsd: Set v4 version when only a minor version is set

RFC PATCH New Steve Dickson 1 participant 2 messages Oct 27, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover nfsd: Set v4 version when only a minor version is set

Make sure the v4 version is set when only a minor version is set in /etc/nfs.conf

Set v4 version if only minor version are specified

When vers4 in /etc/nfs.conf is set to 'n', all minor version are disabled as well. But when vers4 is set 'y' all minor version are settable. Meaning

vers4=n
vers4.2=y
does not work. rpc.nfsd complains there are no version set.

vers4=y
vers4=y
does work.

Now the rpc.nfsd(8) man page does say
vers4 Enable or disable a major NFS version.

It could be changed to
vers4 Enable or disable all major NFS versions.

Or the two line patch attached could be applied.

Steve Dickson (1):
nfsd: Set v4 version when only a minor version is set

 utils/nfsd/nfsd.c | 3 +++
 1 file changed, 3 insertions(+)
Signature · 1 line
2.37.3
#1 lore raw

PATCH 1/1 nfsd: Set v4 version when only a minor version is set

Make sure the v4 version is set when only a minor
version is set in /etc/nfs.conf

---
 utils/nfsd/nfsd.c | 3 +++
 1 file changed, 3 insertions(+)
utils/nfsd/nfsd.c +3 -0
index 4016a76..87c5ce9 100644
@@ -154,6 +154,9 @@ main(int argc, char **argv)
 		if (conf_get_bool("nfsd", tag, 0)) {
 			NFSCTL_MINORSET(minorversset, i);
 			NFSCTL_MINORSET(minorvers, i);
+			/* Make sure v4 is set */
+			if (!NFSCTL_VERISSET(versbits, 4))
+				NFSCTL_VERSET(versbits, 4);
 			if (i == 0)
 				force4dot0 = 1;
 		}
Signature · 1 line
2.37.3