Skip to contentSkip to conversation

WARNING: Possible repeated word: 'very'

PATCH In review UMWARI JOVIAL 4 participants 8 messages Oct 28, 2022 – Oct 29, 2022 Staging

lore
Share & tools
lore

UMWARI JOVIAL

author
#0 lore raw

PATCH 1/1 WARNING: Possible repeated word: 'very'

i used checkpatch.pl script to identify the above Repetition of the same word in one sentence same line

Signed-off-by UMWARI JOVIAL <[email protected]>
---
 drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/rtl871x_xmit.c +1 -1
index 090345bad223..30a0276b8b58 100644
@@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
  * If we turn on USE_RXTHREAD, then, no need for critical section.
  * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
  *
- * Must be very very cautious...
+ * Must be very cautious...
  *
  */
 struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv)
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 2 lines · UMWARI JOVIAL

i used checkpatch.pl script to identify the above Repetition of the same word in one sentence same line

Please read the documentation for how to write a good changelog text. Hint, "i" is not something you see in a text, right?

Also, why do you have WARNING in the subject line and not the driver name? Again, read the documentation please.

Quoted 11 lines
Signed-off-by UMWARI JOVIAL <[email protected]>
---
 drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/rtl871x_xmit.c +0 -0
index 090345bad223..30a0276b8b58 100644

drivers/staging/rtl8712/rtl871x_xmit.c void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) · line 769

Quoted 5 lines
drivers/staging/rtl8712/rtl871x_xmit.c +1 -1
@@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
  * If we turn on USE_RXTHREAD, then, no need for critical section.
  * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
  *
- * Must be very very cautious...
+ * Must be very cautious...

The original text here is correct.

thanks,

greg k-h

author
#2 lore raw

Thank you
working on it now

Best Regards
Umwari Jovial

Quoted 33 lines · Greg KH
Quoted 2 lines · UMWARI JOVIAL

i used checkpatch.pl script to identify the above Repetition of the same word in one sentence same line

Please read the documentation for how to write a good changelog text. Hint, "i" is not something you see in a text, right?

Also, why do you have WARNING in the subject line and not the driver name? Again, read the documentation please.

Quoted 11 lines
Signed-off-by UMWARI JOVIAL <[email protected]>
---
 drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/rtl871x_xmit.c +0 -0
index 090345bad223..30a0276b8b58 100644

drivers/staging/rtl8712/rtl871x_xmit.c void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) · line 769

Quoted 5 lines
drivers/staging/rtl8712/rtl871x_xmit.c +1 -1
@@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
  * If we turn on USE_RXTHREAD, then, no need for critical section.
  * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
  *
- * Must be very very cautious...
+ * Must be very cautious...

The original text here is correct.

thanks,

greg k-h

maintainer
#3 lore raw

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

Quoted 5 lines · jovial umwari

Thank you
working on it now

Best Regards
Umwari Jovial

As you spell your name this way in emails, please use the same format for your signed-off-by lines in your patches.

thanks,

greg k-h

author
#4 lore raw

Thank you for the corrections
i am very sorry for All these mistakes
i did not know

Best regards
Umwari Jovial

Quoted 26 lines · Greg KH

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

Quoted 5 lines · jovial umwari

Thank you
working on it now

Best Regards
Umwari Jovial

As you spell your name this way in emails, please use the same format for your signed-off-by lines in your patches.

thanks,

greg k-h

#5 lore raw
In reply to UMWARI JOVIAL
Quoted 4 lines · UMWARI JOVIAL

i used checkpatch.pl script to identify the above Repetition of the same word in one sentence same line

Signed-off-by UMWARI JOVIAL <[email protected]>

This is my (not yet automated) response:

You are sending patches to the Outreachy list, in a way that makes me suspect you have overlooked the Outreachy Project Contribution Information.

Please review:
https://www.outreachy.org/outreachy-december-2022-internship-round/communities/linux-kernel/ (only accepted applicants can see this link)

https://lore.kernel.org/outreachy/Y0D+dzbjRtuc0KT4@aschofie-mobl2/

Alison

Quoted 21 lines
---
 drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/rtl871x_xmit.c +1 -1
index 090345bad223..30a0276b8b58 100644
@@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
  * If we turn on USE_RXTHREAD, then, no need for critical section.
  * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
  *
- * Must be very very cautious...
+ * Must be very cautious...
  *
  */
 struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv)
Signature · 1 line
2.25.1
author
#6 lore raw

Noted. Thank you sir

Quoted 41 lines · Alison Schofield
Quoted 4 lines · UMWARI JOVIAL

i used checkpatch.pl script to identify the above Repetition of the same word in one sentence same line

Signed-off-by UMWARI JOVIAL <[email protected]>

This is my (not yet automated) response:

You are sending patches to the Outreachy list, in a way that makes me suspect you have overlooked the Outreachy Project Contribution Information.

Please review:
https://www.outreachy.org/outreachy-december-2022-internship-round/communities/linux-kernel/ (only accepted applicants can see this link)

https://lore.kernel.org/outreachy/Y0D+dzbjRtuc0KT4@aschofie-mobl2/

Alison

Quoted 21 lines
---
 drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/rtl871x_xmit.c +1 -2
index 090345bad223..30a0276b8b58 100644
@@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
  * If we turn on USE_RXTHREAD, then, no need for critical section.
  * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
  *
- * Must be very very cautious...
+ * Must be very cautious...
  *
  */
 struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv)
--

2.25.1

#7 lore raw
Quoted 1 line · jovial umwari

Noted. Thank you sir

Please don't top post. Your reponse should appear below the text that you are responding to.

julia

Quoted 46 lines
Quoted 41 lines · Alison Schofield
Quoted 4 lines · UMWARI JOVIAL

i used checkpatch.pl script to identify the above Repetition of the same word in one sentence same line

Signed-off-by UMWARI JOVIAL <[email protected]>

This is my (not yet automated) response:

You are sending patches to the Outreachy list, in a way that makes me suspect you have overlooked the Outreachy Project Contribution Information.

Please review:
https://www.outreachy.org/outreachy-december-2022-internship-round/communities/linux-kernel/ (only accepted applicants can see this link)

https://lore.kernel.org/outreachy/Y0D+dzbjRtuc0KT4@aschofie-mobl2/

Alison

Quoted 21 lines
---
 drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/rtl871x_xmit.c +1 -2
index 090345bad223..30a0276b8b58 100644
@@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
  * If we turn on USE_RXTHREAD, then, no need for critical section.
  * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
  *
- * Must be very very cautious...
+ * Must be very cautious...
  *
  */
 struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv)
--

2.25.1