Possible repeated word: 'very'
PATCH 1/1 Possible repeated word: 'very'
Reported By checkpatch.pl script
WARNING: Possible repeated word: 'very'
Repetition of the same word in one sentence same line
--- drivers/staging/rtl8712/rtl871x_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/rtl871x_xmit.c +1 -1
@@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)* If we turn on USE_RXTHREAD, then, no need for critical section. * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... * -* Must be very very cautious... +* Must be very cautious... * */ struct xmit_frame *r8712_alloc_xmitframe (struct xmit_priv *pxmitpriv)
Signature · 1 line
2.25.1
Quoted 27 lines · UMWARI JOVIAL
Reported By checkpatch.pl script
WARNING: Possible repeated word: 'very'
Repetition of the same word in one sentence same line
Signed-off-by UMWARI JOVIAL <[email protected]>--- drivers/staging/rtl8712/rtl871x_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8712/rtl871x_xmit.c +1
-1@@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)* If we turn on USE_RXTHREAD, then, no need for critical section. * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... * -* Must be very very cautious... +* Must be very cautious... * */ struct xmit_frame *r8712_alloc_xmitframe (struct xmit_priv *pxmitpriv)Signature · 1 line
2.25.1
This patch is an updated version of another patch you sent, so you must use the "v2" prefix. Furthermore, you need to have to name of the subsystem that change. So it should be something like:
[PATCH v2] staging: rtl8712: <short description of the commit>
And I think the person who wrote that just wanted to stress it by duplicating "very". So I don't think this patch is necessary.
Best regards,
Nam
Bagas Sanjaya
NAKQuoted 16 lines · UMWARI JOVIAL
Reported By checkpatch.pl script
WARNING: Possible repeated word: 'very'
Repetition of the same word in one sentence same line
Signed-off-by UMWARI JOVIAL <[email protected]>--- drivers/staging/rtl8712/rtl871x_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8712/rtl871x_xmit.c +0
-0
drivers/staging/rtl8712/rtl871x_xmit.c void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) · line 772
Quoted 8 lines
drivers/staging/rtl8712/rtl871x_xmit.c +1
-1@@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)* If we turn on USE_RXTHREAD, then, no need for critical section. * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... * -* Must be very very cautious... +* Must be very cautious... * */ struct xmit_frame *r8712_alloc_xmitframe (struct xmit_priv *pxmitpriv)
NAK!
You send patch with the same content as [1], for which Greg already replied as [2].
The code and its comments imply that calling r8712_alloc_xmitframe() must be done with extreme caution, isn't it?
Thanks.
[1]: https://lore.kernel.org/lkml/20221028051420.GA30073@rdm/
[2]: https://lore.kernel.org/lkml/[email protected]/
Signature · 1 line
An old man doll... just what I always wanted! - Clara