Skip to contentSkip to conversation

scsi: qla2xxx: Remove unused variable found_devs

PATCH Applied Colin Ian King 2 participants 2 messages Nov 1, 2022 – Nov 17, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: qla2xxx: Remove unused variable found_devs

Variable found_devs is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it.

---
 drivers/scsi/qla2xxx/qla_init.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/scsi/qla2xxx/qla_init.c +0 -4
index e12db95de688..8f737d80bce4 100644
@@ -5546,7 +5546,6 @@ static int
 qla2x00_configure_local_loop(scsi_qla_host_t *vha)
 {
 	int		rval, rval2;
-	int		found_devs;
 	int		found;
 	fc_port_t	*fcport, *new_fcport;
 	uint16_t	index;
@@ -5561,7 +5560,6 @@ qla2x00_configure_local_loop(scsi_qla_host_t *vha)
 	if (N2N_TOPO(ha))
 		return qla2x00_configure_n2n_loop(vha);
 
-	found_devs = 0;
 	new_fcport = NULL;
 	entries = MAX_FIBRE_DEVICES_LOOP;
 
@@ -5720,8 +5718,6 @@ qla2x00_configure_local_loop(scsi_qla_host_t *vha)
 
 		/* Base iIDMA settings on HBA port speed. */
 		fcport->fp_speed = ha->link_data_rate;
-
-		found_devs++;
 	}
 
 	list_for_each_entry(fcport, &vha->vp_fcports, list) {
Signature · 1 line
2.37.3
#1 lore raw
Quoted 5 lines · Colin Ian King

Variable found_devs is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it.

Applied to 6.2/scsi-queue, thanks!

[1/1] scsi: qla2xxx: Remove unused variable found_devs

      https://git.kernel.org/mkp/scsi/c/e137b81d30e7
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering