Skip to contentSkip to conversation

hw/i8042: Fix value uninitialized in kbd_io()

PATCH New hbuxiaofei 1 participant 1 message Nov 2, 2022 KVM

lore
Share & tools
lore

hbuxiaofei

author
#0 lore raw

PATCH 1/1 hw/i8042: Fix value uninitialized in kbd_io()

GCC Version:

    gcc (GCC) 8.4.1 20200928 (Red Hat 8.4.1-1)

hw/i8042.c: In function ‘kbd_io’:
hw/i8042.c:153:19: error: ‘value’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

     state.write_cmd = val;
     ~~~~~~~~~~~~~~~~^~~~~
  hw/i8042.c:298:5: note: ‘value’ was declared here
    u8 value;
       ^~~~~

cc1: all warnings being treated as errors
make: *** [Makefile:508: hw/i8042.o] Error 1

---
 hw/i8042.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/i8042.c +1 -1
index 20be36c..6e4b559 100644
@@ -295,7 +295,7 @@ static void kbd_reset(void)
 static void kbd_io(struct kvm_cpu *vcpu, u64 addr, u8 *data, u32 len,
 		   u8 is_write, void *ptr)
 {
-	u8 value;
+	u8 value = 0;
 
 	if (is_write)
 		value = ioport__read8(data);
Signature · 1 line
2.27.0