sunrpc: svc: Remove unnecessary (void*) conversions
Subsystems (2)
PATCH 1/1 sunrpc: svc: Remove unnecessary (void*) conversions
The iov_base pointer does not need to cast the type.
--- include/linux/sunrpc/svc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/sunrpc/svc.h +1 -1
@@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov)static inline void svc_ungetu32 (struct kvec *iov) { -__be32 *vp = (__be32 *)iov->iov_base; +__be32 *vp = iov->iov_base; iov->iov_base = (void *)(vp -1 ); iov->iov_len +=sizeof (*vp); }
Signature · 1 line
2.18.2
Quoted 12 lines · Li zeming
The
iov_basepointer does not need to cast the type.Signed-off-by Li zeming <[email protected]>--- include/linux/sunrpc/svc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/sunrpc/svc.h +0
-0
include/linux/sunrpc/svc.h static inline __be32 svc_getu32(struct kvec *iov) · line 228
Quoted 8 lines
include/linux/sunrpc/svc.h +1
-1@@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov)static inline void svc_ungetu32 (struct kvec *iov) { -__be32 *vp = (__be32 *)iov->iov_base; +__be32 *vp = iov->iov_base; iov->iov_base = (void *)(vp -1 ); iov->iov_len +=sizeof (*vp); }
Trond Myklebust
maintainerQuoted 12 lines · Li zeming
The
iov_basepointer does not need to cast the type.Signed-off-by Li zeming <[email protected]>---
include/linux/sunrpc/svc.h | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)include/linux/sunrpc/svc.h +0
-0@@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov)
Quoted 8 lines
static inline voidsvc_ungetu32(struct kvec *iov){
- __be32 *vp = (__be32*)iov->iov_base; + __be32 *vp =iov->iov_base;iov->iov_base= (void *)(vp - 1);iov->iov_len+=sizeof(*vp);
}
If you're going to submit a patch just in order to strip unnecessary casts, then why are you leaving the equally unnecessary cast in the next line?
That said, why waste time "fixing" an inlined function that is not actually called anywhere in the kernel? svc_ungetu32() should just be removed.
Signature · 3 lines
Trond Myklebust Linux NFS client maintainer, Hammerspace [email protected]
Quoted 30 lines · Trond Myklebust
Quoted 12 lines · Li zeming
The
iov_basepointer does not need to cast the type.Signed-off-by Li zeming <[email protected]>--- include/linux/sunrpc/svc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/sunrpc/svc.h +0
-0include/linux/sunrpc/svc.h static inline __be32 svc_getu32(struct kvec *iov) · line 228
Quoted 8 lines
include/linux/sunrpc/svc.h +1
-1@@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov)static inline void svc_ungetu32 (struct kvec *iov) { -__be32 *vp = (__be32 *)iov->iov_base; +__be32 *vp = iov->iov_base; iov->iov_base = (void *)(vp -1 ); iov->iov_len +=sizeof (*vp); }If you're going to submit a patch just in order to strip unnecessary casts, then why are you leaving the equally unnecessary cast in the next line?
Quoted 3 lines
That said, why waste time "fixing" an inlined function that is not actually called anywhere in the kernel?
svc_ungetu32()should just be removed.
Sorry for the delay, I was expecting an electrical service outage here at home yesterday, so the lab was powered off.
So, Li, can you drop this one, and instead send a patch that removes the definition of svc_ungetu32 ?
--
Chuck Lever
of course, I will submit a new one to delete the static svc_ungetu32() function for Patch.