Skip to contentSkip to conversation

qom.json: default the prealloc-threads to smp-cpus

PATCH Superseded Zhenyu Zhang 4 participants 7 messages Nov 3, 2022 – Nov 4, 2022

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qom.json: default the prealloc-threads to smp-cpus

Since the amount of prealloc-threads to smp-cpus is defaulted in hostmem, so sync this information.

---
 qapi/qom.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
qapi/qom.json +1 -1
index 87fcad2423..ac4cd213a7 100644
@@ -576,7 +576,7 @@
 #
 # @prealloc: if true, preallocate memory (default: false)
 #
-# @prealloc-threads: number of CPU threads to use for prealloc (default: 1)
+# @prealloc-threads: number of CPU threads to use for prealloc (default: smp-cpus) (since 7.1)
 #
 # @prealloc-context: thread context to use for creation of preallocation threads
 #                    (default: none) (since 7.2)
Signature · 1 line
2.31.1
#1 lore raw
Quoted 13 lines · Zhenyu Zhang

Since the amount of prealloc-threads to smp-cpus is defaulted in hostmem, so sync this information.

---
  qapi/qom.json | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
qapi/qom.json +0 -0
index 87fcad2423..ac4cd213a7 100644

qapi/qom.json line 579

Quoted 5 lines
qapi/qom.json +1 -1
@@ -576,7 +576,7 @@
  #
  # @prealloc: if true, preallocate memory (default: false)
  #
-# @prealloc-threads: number of CPU threads to use for prealloc (default: 1)
+# @prealloc-threads: number of CPU threads to use for prealloc (default: smp-cpus) (since 7.1)

The property is present since 5.0. Shouldn't this be "(default: smp-cpus) (since 5.0)"?

Quoted 3 lines
qapi/qom.json +0 -0
  #
  # @prealloc-context: thread context to use for creation of preallocation threads
  #                    (default: none) (since 7.2)
#2 lore raw

Hello Philippe

I checked out this modified patch:
https://www.mail-archive.com/[email protected]/msg888815.html
It should have been merged in 7.1

Quoted 28 lines · Philippe Mathieu-Daudé
Quoted 13 lines · Zhenyu Zhang

Since the amount of prealloc-threads to smp-cpus is defaulted in hostmem, so sync this information.

---
  qapi/qom.json | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
qapi/qom.json +0 -0
index 87fcad2423..ac4cd213a7 100644

qapi/qom.json line 579

Quoted 5 lines
qapi/qom.json +1 -1
@@ -576,7 +576,7 @@
  #
  # @prealloc: if true, preallocate memory (default: false)
  #
-# @prealloc-threads: number of CPU threads to use for prealloc (default: 1)
+# @prealloc-threads: number of CPU threads to use for prealloc (default: smp-cpus) (since 7.1)

The property is present since 5.0. Shouldn't this be "(default:
smp-cpus) (since 5.0)"?

Quoted 3 lines
qapi/qom.json +0 -0
  #
  # @prealloc-context: thread context to use for creation of preallocation threads
  #                    (default: none) (since 7.2)
#3 lore raw
Quoted 5 lines · Zhenyu Zhang

Hello Philippe

I checked out this modified patch:
https://www.mail-archive.com/[email protected]/msg888815.html
It should have been merged in 7.1

This changed the default value, not the property availability.

IIUC the '(since X)' format document when a property got added, regardless its default value.

This property is available since 5.0.

The default value changed in 7.1. You are correct we need to update the new value in documentation, but the 'since' tag should refer to when the property got added: 5.0.

Quoted 30 lines · Philippe Mathieu-Daudé
Quoted 28 lines · Zhenyu Zhang
Quoted 13 lines

Since the amount of prealloc-threads to smp-cpus is defaulted in hostmem, so sync this information.

---
   qapi/qom.json | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
qapi/qom.json +0 -0
index 87fcad2423..ac4cd213a7 100644

qapi/qom.json line 579

Quoted 5 lines
qapi/qom.json +1 -1
@@ -576,7 +576,7 @@
   #
   # @prealloc: if true, preallocate memory (default: false)
   #
-# @prealloc-threads: number of CPU threads to use for prealloc (default: 1)
+# @prealloc-threads: number of CPU threads to use for prealloc (default: smp-cpus) (since 7.1)

The property is present since 5.0. Shouldn't this be "(default:
smp-cpus) (since 5.0)"?

Quoted 3 lines
qapi/qom.json +0 -0
   #
   # @prealloc-context: thread context to use for creation of preallocation threads
   #                    (default: none) (since 7.2)
#4 lore raw

Ok, many thanks for the clarification.
I'll post a v2 patch to correct it.

Quoted 50 lines · Philippe Mathieu-Daudé
Quoted 5 lines · Zhenyu Zhang

Hello Philippe

I checked out this modified patch:
https://www.mail-archive.com/[email protected]/msg888815.html
It should have been merged in 7.1

This changed the default value, not the property availability.

IIUC the '(since X)' format document when a property got added, regardless its default value.

This property is available since 5.0.

The default value changed in 7.1. You are correct we need to update the new value in documentation, but the 'since' tag should refer to when the property got added: 5.0.

Quoted 30 lines · Philippe Mathieu-Daudé
Quoted 28 lines · Zhenyu Zhang
Quoted 13 lines

Since the amount of prealloc-threads to smp-cpus is defaulted in hostmem, so sync this information.

---
   qapi/qom.json | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
qapi/qom.json +0 -0
index 87fcad2423..ac4cd213a7 100644

qapi/qom.json line 579

Quoted 5 lines
qapi/qom.json +1 -1
@@ -576,7 +576,7 @@
   #
   # @prealloc: if true, preallocate memory (default: false)
   #
-# @prealloc-threads: number of CPU threads to use for prealloc (default: 1)
+# @prealloc-threads: number of CPU threads to use for prealloc (default: smp-cpus) (since 7.1)

The property is present since 5.0. Shouldn't this be "(default:
smp-cpus) (since 5.0)"?

Quoted 3 lines
qapi/qom.json +0 -0
   #
   # @prealloc-context: thread context to use for creation of preallocation threads
   #                    (default: none) (since 7.2)
#5 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 3 lines · Philippe Mathieu-Daudé
Quoted 2 lines · Zhenyu Zhang

Since the amount of prealloc-threads to smp-cpus is defaulted in hostmem, so sync this information.

Has this always defaulted to smp-cpus, or did this change along the way?

Quoted 8 lines
Quoted 8 lines
---
  qapi/qom.json | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
qapi/qom.json +0 -0
index 87fcad2423..ac4cd213a7 100644
Quoted 8 lines

qapi/qom.json line 579

Quoted 6 lines
qapi/qom.json +1 -1
@@ -576,7 +576,7 @@
  #
  # @prealloc: if true, preallocate memory (default: false)
  #
-# @prealloc-threads: number of CPU threads to use for prealloc (default: 1)
+# @prealloc-threads: number of CPU threads to use for prealloc (default: smp-cpus) (since 7.1)

The property is present since 5.0. Shouldn't this be "(default: smp-cpus) (since 5.0)"?

Yes.

Quoted 3 lines
Quoted 3 lines
qapi/qom.json +0 -0
  #
  # @prealloc-context: thread context to use for creation of preallocation threads
  #                    (default: none) (since 7.2)
#6 lore raw
Quoted 7 lines · On Fri, 04 Nov 2022 05:53:02 +0100 Markus Armbruster <[email protected]> wrote:
Quoted 3 lines · Philippe Mathieu-Daudé
Quoted 2 lines · Zhenyu Zhang

Since the amount of prealloc-threads to smp-cpus is defaulted in hostmem, so sync this information.

Has this always defaulted to smp-cpus, or did this change along the way?

yes and no
(originally value was 1 with vl.c fixing it up to smp-cpus when legacy -mem-prealloc was used)
ffac16fab33bb hostmem: introduce "prealloc-threads" property
however later on
2a4e02d104b1 hostmem: set default prealloc_threads to valid value
hack was merged (sigh),
brought back direct dependency on machine->smp.cpus to memory allocation and that flipped default to number of smp-cpus.

Quoted 23 lines
Quoted 8 lines
Quoted 8 lines
---
  qapi/qom.json | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
qapi/qom.json +0 -0
index 87fcad2423..ac4cd213a7 100644
Quoted 8 lines

qapi/qom.json line 579

Quoted 6 lines
qapi/qom.json +1 -1
@@ -576,7 +576,7 @@
  #
  # @prealloc: if true, preallocate memory (default: false)
  #
-# @prealloc-threads: number of CPU threads to use for prealloc (default: 1)
+# @prealloc-threads: number of CPU threads to use for prealloc (default: smp-cpus) (since 7.1)  

The property is present since 5.0. Shouldn't this be "(default: smp-cpus) (since 5.0)"?

Yes.

Quoted 3 lines
Quoted 3 lines
qapi/qom.json +0 -0
  #
  # @prealloc-context: thread context to use for creation of preallocation threads
  #                    (default: none) (since 7.2)