crypto: rockchip: Remove surplus dev_err() when using platform_get_irq()
Subsystems (3)
PATCH v2 1/1 crypto: rockchip: Remove surplus dev_err() when using platform_get_irq()
There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure.
./drivers/crypto/rockchip/rk3288_crypto.c:351:2-9: line 351 is redundant because platform_get_irq() already prints an error
---
change in v2:
--According to Corentin's suggestion, make the subject started by "crypto: rockchip:".
drivers/crypto/rockchip/rk3288_crypto.c | 1 - 1 file changed, 1 deletion(-)
drivers/crypto/rockchip/rk3288_crypto.c +0 -1
@@ -348,7 +348,6 @@ static int rk_crypto_probe(struct platform_device *pdev) crypto_info->irq =platform_get_irq (pdev,0 );if (crypto_info->irq <0 ) { -dev_err (&pdev->dev,"control Interrupt is not available.\n" ); err = crypto_info->irq; goto err_crypto; }
Signature · 1 line
2.20.1.7.g153144c
Quoted 11 lines · Yang Li
There is no need to call the
dev_err()function directly to print a custom message when handling an error from either theplatform_get_irq()orplatform_get_irq_byname()functions as both are going to display an appropriate error message in case of a failure../drivers/crypto/rockchip/rk3288_crypto.c:351:2-9: line 351 is redundant because
platform_get_irq()already prints an errorReported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>
Quoted 8 lines
---
change in v2:
--According to Corentin's suggestion, make the subject started by "crypto: rockchip:".drivers/crypto/rockchip/rk3288_crypto.c | 1 - 1 file changed, 1 deletion(-)
Hello
Thanks
Herbert Xu
maintainerQuoted 11 lines · Yang Li
There is no need to call the
dev_err()function directly to print a custom message when handling an error from either theplatform_get_irq()orplatform_get_irq_byname()functions as both are going to display an appropriate error message in case of a failure../drivers/crypto/rockchip/rk3288_crypto.c:351:2-9: line 351 is redundant because
platform_get_irq()already prints an errorReported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>
Quoted 7 lines
---
change in v2:
--According to Corentin's suggestion, make the subject started by "crypto: rockchip:".drivers/crypto/rockchip/rk3288_crypto.c | 1 - 1 file changed, 1 deletion(-)
Patch applied. Thanks.
Signature · 8 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip