vfio-ccw parent rework
Subsystems (13)
Eric Farman
maintainerv3 cover vfio-ccw parent rework
Hi Alex,
Here's the (last?) update to the vfio-ccw lifecycle changes that I've sent recently, and were previously discussed at various points [1][2].
Patches 1-5 rework the behavior of the vfio-ccw driver's private struct. In summary, the mdev pieces are split out of vfio_ccw_private and into a new vfio_ccw_parent struct that will continue to follow today's lifecycle. The remainder (bulk) of the private struct moves to follow the mdev probe/remove pair. There's opportunity for further separation of the things in the private struct, which would simplify some of the vfio-ccw code, but it got too hairy as I started that. Once vfio-ccw is no longer considered unique, those cleanups can happen at our leisure.
Patch 6 removes the trickery where vfio-ccw uses vfio_init_device instead of vfio_alloc_device, and thus removes vfio_init_device from the outside world.
Patch 7 removes vfio_free_device from vfio-ccw and the other drivers (hello, CC list!), letting it be handled by vfio_device_release directly.
I believe this covers everything in this space; let me know if not!
Thanks,
Eric
[1] https://lore.kernel.org/kvm/[email protected]/
[2] https://lore.kernel.org/kvm/[email protected]/
v2->v3:
- [MR] Added r-b to remaining patches (Thank you!)
- Patch 1:
[gfx checkpatch] Whitespace
[EF] Remove put_device(&parent->dev)
[MR] Fix error exit when alloc of parent fails
[MR] Check for !private on sch_probe error path
- Patch 3:
[EF] Fix error exit when alloc of private fails
- Patch 6:
[AW] Added ack (Thank you!)
- Patch 7:
[CH, AK] Added r-b (Thank you!)
[AW] Added ack (Thank you!)
v2: https://lore.kernel.org/kvm/[email protected]/
v1: https://lore.kernel.org/kvm/[email protected]/
Eric Farman (7):
vfio/ccw: create a parent struct vfio/ccw: remove private->sch
vfio/ccw: move private initialization to callback vfio/ccw: move private to mdev lifecycle vfio/ccw: remove release completion vfio/ccw: replace vfio_init_device with _alloc_
vfio: Remove vfio_free_device
drivers/gpu/drm/i915/gvt/kvmgt.c | 1 - drivers/s390/cio/vfio_ccw_chp.c | 5 +- drivers/s390/cio/vfio_ccw_drv.c | 173 +++++++++++--------------- drivers/s390/cio/vfio_ccw_fsm.c | 27 ++-- drivers/s390/cio/vfio_ccw_ops.c | 107 +++++++++++----- drivers/s390/cio/vfio_ccw_private.h | 37 ++++-- drivers/s390/crypto/vfio_ap_ops.c | 6 - drivers/vfio/fsl-mc/vfio_fsl_mc.c | 1 - drivers/vfio/pci/vfio_pci_core.c | 1 - drivers/vfio/platform/vfio_amba.c | 1 - drivers/vfio/platform/vfio_platform.c | 1 - drivers/vfio/vfio_main.c | 32 ++--- include/linux/vfio.h | 3 - samples/vfio-mdev/mbochs.c | 1 - samples/vfio-mdev/mdpy.c | 1 - samples/vfio-mdev/mtty.c | 1 - 16 files changed, 196 insertions(+), 202 deletions(-)
Signature · 1 line
2.34.1
Eric Farman
maintainerPATCH v3 1/7 vfio/ccw: create a parent struct
Move the stuff associated with the mdev parent (and thus the subchannel struct) into its own struct, and leave the rest in the existing private structure.
The subchannel will point to the parent, and the parent will point to the private, for the areas where one or both are needed. Further separation of these structs will follow.
--- drivers/s390/cio/vfio_ccw_drv.c | 98 +++++++++++++++++++++++------ drivers/s390/cio/vfio_ccw_ops.c | 8 ++- drivers/s390/cio/vfio_ccw_private.h | 20 ++++-- 3 files changed, 101 insertions(+), 25 deletions(-)
drivers/s390/cio/vfio_ccw_drv.c +80 -18
@@ -36,10 +36,19 @@ debug_info_t *vfio_ccw_debug_trace_id;*/ int vfio_ccw_sch_quiesce (struct subchannel *sch) { -struct vfio_ccw_private *private =dev_get_drvdata (&sch->dev); +struct vfio_ccw_parent *parent =dev_get_drvdata (&sch->dev); +struct vfio_ccw_private *private =dev_get_drvdata (&parent->dev);DECLARE_COMPLETION_ONSTACK (completion);int iretry, ret =0 ; +/* +* Probably an impossible situation, after being called through +* FSM callbacks. But in the event it did, register a warning +* and return as if things were fine. +*/ +if (WARN_ON (!private)) +return 0 ; + iretry =255 ; do {
@@ -121,7 +130,23 @@ static void vfio_ccw_crw_todo(struct work_struct *work)*/ static void vfio_ccw_sch_irq (struct subchannel *sch) { -struct vfio_ccw_private *private =dev_get_drvdata (&sch->dev); +struct vfio_ccw_parent *parent =dev_get_drvdata (&sch->dev); +struct vfio_ccw_private *private =dev_get_drvdata (&parent->dev); + +/* +* The subchannel should still be disabled at this point, +* so an interrupt would be quite surprising. As with an +* interrupt while the FSM is closed, let's attempt to +* disable the subchannel again. +*/ +if (!private) { +VFIO_CCW_MSG_EVENT (2 ,"sch %x.%x.%04x: unexpected interrupt\n" , + sch->schid.cssid, sch->schid.ssid, + sch->schid.sch_no); + +cio_disable_subchannel (sch); +return ; + }inc_irq_stat (IRQIO_CIO );vfio_ccw_fsm_event (private,VFIO_CCW_EVENT_INTERRUPT );
@@ -201,10 +226,19 @@ static void vfio_ccw_free_private(struct vfio_ccw_private *private)mutex_destroy (&private->io_mutex);kfree (private); } + +static void vfio_ccw_free_parent (struct device *dev) +{ + struct vfio_ccw_parent *parent = container_of(dev, struct vfio_ccw_parent, dev); + +kfree (parent); +} +static int vfio_ccw_sch_probe (struct subchannel *sch) {struct pmcw *pmcw = &sch->schib.pmcw;struct vfio_ccw_private *private; +struct vfio_ccw_parent *parent;int ret = -ENOMEM ;if (pmcw->qf) {
@@ -213,38 +247,58 @@ static int vfio_ccw_sch_probe(struct subchannel *sch)return -ENODEV ; } + parent =kzalloc (sizeof (*parent),GFP_KERNEL ); +if (!parent) +return -ENOMEM ; + +dev_set_name (&parent->dev,"parent" ); + parent->dev.parent = &sch->dev; + parent->dev.release = &vfio_ccw_free_parent; + ret =device_register (&parent->dev); +if (ret) + goto out_free; + private =vfio_ccw_alloc_private (sch); -if (IS_ERR (private)) +if (IS_ERR (private)) { +device_unregister (&parent->dev);return PTR_ERR (private); + } -dev_set_drvdata (&sch->dev, private); +dev_set_drvdata (&sch->dev, parent); +dev_set_drvdata (&parent->dev, private); - private->mdev_type.sysfs_name ="io" ; - private->mdev_type.pretty_name ="I/O subchannel (Non-QDIO)" ; - private->mdev_types[0 ] = &private->mdev_type; - ret =mdev_register_parent (&private->parent, &sch->dev, + parent->mdev_type.sysfs_name ="io" ; + parent->mdev_type.pretty_name ="I/O subchannel (Non-QDIO)" ; + parent->mdev_types[0 ] = &parent->mdev_type; + ret =mdev_register_parent (&parent->parent, &sch->dev, &vfio_ccw_mdev_driver, - private->mdev_types,1 ); + parent->mdev_types,1 );if (ret) - goto out_free; + goto out_unreg;VFIO_CCW_MSG_EVENT (4 ,"bound to subchannel %x.%x.%04x\n" , sch->schid.cssid, sch->schid.ssid, sch->schid.sch_no);return 0 ; +out_unreg: +device_unregister (&parent->dev); out_free: +dev_set_drvdata (&parent->dev,NULL );dev_set_drvdata (&sch->dev,NULL ); -vfio_ccw_free_private (private); +if (private) +vfio_ccw_free_private (private);return ret; }static void vfio_ccw_sch_remove (struct subchannel *sch) { -struct vfio_ccw_private *private =dev_get_drvdata (&sch->dev); +struct vfio_ccw_parent *parent =dev_get_drvdata (&sch->dev); +struct vfio_ccw_private *private =dev_get_drvdata (&parent->dev); -mdev_unregister_parent (&private->parent); +mdev_unregister_parent (&parent->parent); +device_unregister (&parent->dev);dev_set_drvdata (&sch->dev,NULL );vfio_ccw_free_private (private);
@@ -256,7 +310,11 @@ static void vfio_ccw_sch_remove(struct subchannel *sch)static void vfio_ccw_sch_shutdown (struct subchannel *sch) { -struct vfio_ccw_private *private =dev_get_drvdata (&sch->dev); +struct vfio_ccw_parent *parent =dev_get_drvdata (&sch->dev); +struct vfio_ccw_private *private =dev_get_drvdata (&parent->dev); + +if (WARN_ON (!private)) +return ;vfio_ccw_fsm_event (private,VFIO_CCW_EVENT_CLOSE );vfio_ccw_fsm_event (private,VFIO_CCW_EVENT_NOT_OPER );
@@ -274,7 +332,8 @@ static void vfio_ccw_sch_shutdown(struct subchannel *sch)*/ static int vfio_ccw_sch_event (struct subchannel *sch,int process) { -struct vfio_ccw_private *private =dev_get_drvdata (&sch->dev); +struct vfio_ccw_parent *parent =dev_get_drvdata (&sch->dev); +struct vfio_ccw_private *private =dev_get_drvdata (&parent->dev);unsigned long flags;int rc = -EAGAIN ;
@@ -287,8 +346,10 @@ static int vfio_ccw_sch_event(struct subchannel *sch, int process) rc =0 ; -if (cio_update_schib (sch)) -vfio_ccw_fsm_event (private,VFIO_CCW_EVENT_NOT_OPER ); +if (cio_update_schib (sch)) { +if (private) +vfio_ccw_fsm_event (private,VFIO_CCW_EVENT_NOT_OPER ); + } out_unlock:spin_unlock_irqrestore (sch->lock, flags);
@@ -326,7 +387,8 @@ static void vfio_ccw_queue_crw(struct vfio_ccw_private *private,static int vfio_ccw_chp_event (struct subchannel *sch,struct chp_link *link,int event) { -struct vfio_ccw_private *private =dev_get_drvdata (&sch->dev); +struct vfio_ccw_parent *parent =dev_get_drvdata (&sch->dev); +struct vfio_ccw_private *private =dev_get_drvdata (&parent->dev);int mask =chp_ssd_get_mask (&sch->ssd_info, link);int retry =255 ;
drivers/s390/cio/vfio_ccw_ops.c +6 -2
@@ -55,7 +55,9 @@ static int vfio_ccw_mdev_init_dev(struct vfio_device *vdev)static int vfio_ccw_mdev_probe (struct mdev_device *mdev) { -struct vfio_ccw_private *private =dev_get_drvdata (mdev->dev.parent); +struct subchannel *sch =to_subchannel (mdev->dev.parent); +struct vfio_ccw_parent *parent =dev_get_drvdata (&sch->dev); +struct vfio_ccw_private *private =dev_get_drvdata (&parent->dev);int ret;if (private->state ==VFIO_CCW_STATE_NOT_OPER )
@@ -100,7 +102,9 @@ static void vfio_ccw_mdev_release_dev(struct vfio_device *vdev)static void vfio_ccw_mdev_remove (struct mdev_device *mdev) { -struct vfio_ccw_private *private =dev_get_drvdata (mdev->dev.parent); +struct subchannel *sch =to_subchannel (mdev->dev.parent); +struct vfio_ccw_parent *parent =dev_get_drvdata (&sch->dev); +struct vfio_ccw_private *private =dev_get_drvdata (&parent->dev); VFIO_CCW_MSG_EVENT(2, "sch %x.%x.%04x: remove\n", private->sch->schid.cssid,
drivers/s390/cio/vfio_ccw_private.h +15 -5
@@ -67,6 +67,21 @@ struct vfio_ccw_crw {struct crw crw; }; +/** +* struct vfio_ccw_parent +* +* @dev: embedded device struct +* @parent: parent data structures for mdevs created +* @mdev_type(s): identifying information for mdevs created +*/ +struct vfio_ccw_parent { +struct device dev; + +struct mdev_parent parent; +struct mdev_type mdev_type; +struct mdev_type *mdev_types[1 ]; +}; +/** * struct vfio_ccw_private * @vdev: Embedded VFIO device
@@ -89,7 +104,6 @@ struct vfio_ccw_crw {* @io_work: work for deferral process of I/O handling * @crw_work: work for deferral process of CRW handling * @release_comp: synchronization helper for vfio device release -* @parent: parent data structures for mdevs created */ struct vfio_ccw_private {struct vfio_device vdev;
@@ -116,10 +130,6 @@ struct vfio_ccw_private {struct work_struct crw_work;struct completion release_comp; - -struct mdev_parent parent; -struct mdev_type mdev_type; -struct mdev_type *mdev_types[1 ]; }__aligned(8) ;int vfio_ccw_sch_quiesce (struct subchannel *sch);
Signature · 1 line
2.34.1
Eric Farman
maintainerPATCH v3 2/7 vfio/ccw: remove private->sch
In reply to Eric FarmanThese places all rely on the ability to jump from a private struct back to the subchannel struct. Rather than keeping a copy in our back pocket, let's use the relationship provided by the vfio_device embedded within the private.
--- drivers/s390/cio/vfio_ccw_chp.c | 5 +++-- drivers/s390/cio/vfio_ccw_drv.c | 3 +-- drivers/s390/cio/vfio_ccw_fsm.c | 27 ++++++++++++--------------- drivers/s390/cio/vfio_ccw_ops.c | 12 ++++++------ drivers/s390/cio/vfio_ccw_private.h | 7 ++++--- 5 files changed, 26 insertions(+), 28 deletions(-)
drivers/s390/cio/vfio_ccw_chp.c +3 -2
@@ -16,6 +16,7 @@ static ssize_t vfio_ccw_schib_region_read(struct vfio_ccw_private *private, char __user *buf, size_t count, loff_t *ppos) { + struct subchannel *sch = to_subchannel(private->vdev.dev->parent);unsigned int i =VFIO_CCW_OFFSET_TO_INDEX (*ppos) -VFIO_CCW_NUM_REGIONS ;loff_t pos = *ppos &VFIO_CCW_OFFSET_MASK ;struct ccw_schib_region *region;
@@ -27,12 +28,12 @@ static ssize_t vfio_ccw_schib_region_read(struct vfio_ccw_private *private,mutex_lock (&private->io_mutex); region = private->region[i].data; -if (cio_update_schib (private->sch)) { +if (cio_update_schib (sch)) { ret = -ENODEV ; goto out; } -memcpy (region, &private->sch->schib,sizeof (*region)); +memcpy (region, &sch->schib,sizeof (*region));if (copy_to_user (buf, (void *)region + pos, count)) { ret = -EFAULT ;
drivers/s390/cio/vfio_ccw_drv.c +1 -2
@@ -160,7 +160,6 @@ static struct vfio_ccw_private *vfio_ccw_alloc_private(struct subchannel *sch)if (!private)return ERR_PTR (-ENOMEM ); - private->sch = sch;mutex_init (&private->io_mutex); private->state =VFIO_CCW_STATE_STANDBY ;INIT_LIST_HEAD (&private->crw);
@@ -395,7 +394,7 @@ static int vfio_ccw_chp_event(struct subchannel *sch,if (!private || !mask)return 0 ; -trace_vfio_ccw_chp_event (private->sch->schid, mask, event); +trace_vfio_ccw_chp_event (sch->schid, mask, event); VFIO_CCW_MSG_EVENT(2, "sch %x.%x.%04x: mask=0x%x event=%d\n", sch->schid.cssid, sch->schid.ssid, sch->schid.sch_no,
drivers/s390/cio/vfio_ccw_fsm.c +12 -15
@@ -18,15 +18,13 @@static int fsm_io_helper (struct vfio_ccw_private *private) { -struct subchannel *sch; +struct subchannel *sch =to_subchannel (private->vdev.dev->parent);union orb *orb;int ccode;__u8 lpm;unsigned long flags;int ret; - sch = private->sch; -spin_lock_irqsave (sch->lock, flags); orb =cp_get_orb (&private->cp, (u32 )(addr_t )sch, sch->lpm);
@@ -80,13 +78,11 @@ static int fsm_io_helper(struct vfio_ccw_private *private)static int fsm_do_halt (struct vfio_ccw_private *private) { -struct subchannel *sch; +struct subchannel *sch =to_subchannel (private->vdev.dev->parent);unsigned long flags;int ccode;int ret; - sch = private->sch; -spin_lock_irqsave (sch->lock, flags);VFIO_CCW_TRACE_EVENT (2 ,"haltIO" );
@@ -121,13 +117,11 @@ static int fsm_do_halt(struct vfio_ccw_private *private)static int fsm_do_clear (struct vfio_ccw_private *private) { -struct subchannel *sch; +struct subchannel *sch =to_subchannel (private->vdev.dev->parent);unsigned long flags;int ccode;int ret; - sch = private->sch; -spin_lock_irqsave (sch->lock, flags);VFIO_CCW_TRACE_EVENT (2 ,"clearIO" );
@@ -160,7 +154,7 @@ static int fsm_do_clear(struct vfio_ccw_private *private)static void fsm_notoper (struct vfio_ccw_private *private,enum vfio_ccw_event event) { -struct subchannel *sch = private->sch; +struct subchannel *sch =to_subchannel (private->vdev.dev->parent); VFIO_CCW_MSG_EVENT(2, "sch %x.%x.%04x: notoper event %x state %x\n", sch->schid.cssid,
@@ -228,7 +222,7 @@ static void fsm_async_retry(struct vfio_ccw_private *private,static void fsm_disabled_irq (struct vfio_ccw_private *private,enum vfio_ccw_event event) { -struct subchannel *sch = private->sch; +struct subchannel *sch =to_subchannel (private->vdev.dev->parent);/* * An interrupt in a disabled state means a previous disable was not
@@ -238,7 +232,9 @@ static void fsm_disabled_irq(struct vfio_ccw_private *private, }inline struct subchannel_id get_schid (struct vfio_ccw_private *p) { -return p->sch->schid; +struct subchannel *sch =to_subchannel (p->vdev.dev->parent); + +return sch->schid; }/*
@@ -360,10 +356,11 @@ static void fsm_async_request(struct vfio_ccw_private *private,static void fsm_irq (struct vfio_ccw_private *private,enum vfio_ccw_event event) { +struct subchannel *sch =to_subchannel (private->vdev.dev->parent);struct irb *irb =this_cpu_ptr (&cio_irb);VFIO_CCW_TRACE_EVENT (6 ,"IRQ" ); -VFIO_CCW_TRACE_EVENT (6 ,dev_name (&private->sch->dev)); +VFIO_CCW_TRACE_EVENT (6 ,dev_name (&sch->dev));memcpy (&private->irb, irb,sizeof (*irb));
@@ -376,7 +373,7 @@ static void fsm_irq(struct vfio_ccw_private *private,static void fsm_open (struct vfio_ccw_private *private,enum vfio_ccw_event event) { -struct subchannel *sch = private->sch; +struct subchannel *sch =to_subchannel (private->vdev.dev->parent);int ret;spin_lock_irq (sch->lock);
@@ -397,7 +394,7 @@ static void fsm_open(struct vfio_ccw_private *private,static void fsm_close (struct vfio_ccw_private *private,enum vfio_ccw_event event) { -struct subchannel *sch = private->sch; +struct subchannel *sch =to_subchannel (private->vdev.dev->parent);int ret;spin_lock_irq (sch->lock);
drivers/s390/cio/vfio_ccw_ops.c +6 -6
@@ -68,9 +68,9 @@ static int vfio_ccw_mdev_probe(struct mdev_device *mdev)return ret;VFIO_CCW_MSG_EVENT (2 ,"sch %x.%x.%04x: create\n" , - private->sch->schid.cssid, - private->sch->schid.ssid, - private->sch->schid.sch_no); + sch->schid.cssid, + sch->schid.ssid, + sch->schid.sch_no); ret =vfio_register_emulated_iommu_dev (&private->vdev);if (ret)
@@ -107,9 +107,9 @@ static void vfio_ccw_mdev_remove(struct mdev_device *mdev)struct vfio_ccw_private *private =dev_get_drvdata (&parent->dev);VFIO_CCW_MSG_EVENT (2 ,"sch %x.%x.%04x: remove\n" , - private->sch->schid.cssid, - private->sch->schid.ssid, - private->sch->schid.sch_no); + sch->schid.cssid, + sch->schid.ssid, + sch->schid.sch_no);vfio_unregister_group_dev (&private->vdev);
drivers/s390/cio/vfio_ccw_private.h +4 -3
@@ -85,7 +85,6 @@ struct vfio_ccw_parent {/** * struct vfio_ccw_private * @vdev: Embedded VFIO device -* @sch: pointer to the subchannel * @state: internal state of the device * @completion: synchronization helper of the I/O completion * @io_region: MMIO region to input/output I/O arguments/results
@@ -107,7 +106,6 @@ struct vfio_ccw_parent {*/ struct vfio_ccw_private {struct vfio_device vdev; -struct subchannel *sch;int state;struct completion *completion;struct ccw_io_region *io_region;
@@ -172,7 +170,10 @@ extern fsm_func_t *vfio_ccw_jumptable[NR_VFIO_CCW_STATES][NR_VFIO_CCW_EVENTS];static inline void vfio_ccw_fsm_event (struct vfio_ccw_private *private,enum vfio_ccw_event event) { -trace_vfio_ccw_fsm_event (private->sch->schid, private->state, event); +struct subchannel *sch =to_subchannel (private->vdev.dev->parent); + +if (sch) +trace_vfio_ccw_fsm_event (sch->schid, private->state, event); vfio_ccw_jumptable[private->state][event](private, event); }
Signature · 1 line
2.34.1
Eric Farman
maintainerPATCH v3 3/7 vfio/ccw: move private initialization to callback
In reply to Eric FarmanThere's already a device initialization callback that is used to initialize the release completion workaround that was introduced by commit ebb72b765fb49 ("vfio/ccw: Use the new device life cycle helpers").
Move the other elements of the vfio_ccw_private struct that require distinct initialization over to that routine.
With that done, the vfio_ccw_alloc_private routine only does a kzalloc, so fold it inline.
--- drivers/s390/cio/vfio_ccw_drv.c | 74 ++++------------------------- drivers/s390/cio/vfio_ccw_ops.c | 43 +++++++++++++++++ drivers/s390/cio/vfio_ccw_private.h | 7 ++- 3 files changed, 58 insertions(+), 66 deletions(-)
drivers/s390/cio/vfio_ccw_drv.c +9 -65
@@ -23,10 +23,10 @@#include "vfio_ccw_private.h" struct workqueue_struct *vfio_ccw_work_q; -static struct kmem_cache *vfio_ccw_io_region; -static struct kmem_cache *vfio_ccw_cmd_region; -static struct kmem_cache *vfio_ccw_schib_region; -static struct kmem_cache *vfio_ccw_crw_region; +struct kmem_cache *vfio_ccw_io_region; +struct kmem_cache *vfio_ccw_cmd_region; +struct kmem_cache *vfio_ccw_schib_region; +struct kmem_cache *vfio_ccw_crw_region;debug_info_t *vfio_ccw_debug_msg_id;debug_info_t *vfio_ccw_debug_trace_id;
@@ -79,7 +79,7 @@ int vfio_ccw_sch_quiesce(struct subchannel *sch)return ret; } -static void vfio_ccw_sch_io_todo (struct work_struct *work) +void vfio_ccw_sch_io_todo (struct work_struct *work) {struct vfio_ccw_private *private;struct irb *irb;
@@ -115,7 +115,7 @@ static void vfio_ccw_sch_io_todo(struct work_struct *work)eventfd_signal (private->io_trigger,1 ); } -static void vfio_ccw_crw_todo (struct work_struct *work) +void vfio_ccw_crw_todo (struct work_struct *work) {struct vfio_ccw_private *private;
@@ -152,62 +152,6 @@ static void vfio_ccw_sch_irq(struct subchannel *sch)vfio_ccw_fsm_event (private,VFIO_CCW_EVENT_INTERRUPT ); } -static struct vfio_ccw_private *vfio_ccw_alloc_private (struct subchannel *sch) -{ -struct vfio_ccw_private *private; - - private =kzalloc (sizeof (*private),GFP_KERNEL ); -if (!private) -return ERR_PTR (-ENOMEM ); - -mutex_init (&private->io_mutex); - private->state =VFIO_CCW_STATE_STANDBY ; -INIT_LIST_HEAD (&private->crw); -INIT_WORK (&private->io_work, vfio_ccw_sch_io_todo); -INIT_WORK (&private->crw_work, vfio_ccw_crw_todo); - - private->cp.guest_cp =kcalloc (CCWCHAIN_LEN_MAX ,sizeof (struct ccw1 ), -GFP_KERNEL ); -if (!private->cp.guest_cp) - goto out_free_private; - - private->io_region =kmem_cache_zalloc (vfio_ccw_io_region, -GFP_KERNEL |GFP_DMA ); -if (!private->io_region) - goto out_free_cp; - - private->cmd_region =kmem_cache_zalloc (vfio_ccw_cmd_region, -GFP_KERNEL |GFP_DMA ); -if (!private->cmd_region) - goto out_free_io; - - private->schib_region =kmem_cache_zalloc (vfio_ccw_schib_region, -GFP_KERNEL |GFP_DMA ); - -if (!private->schib_region) - goto out_free_cmd; - - private->crw_region =kmem_cache_zalloc (vfio_ccw_crw_region, -GFP_KERNEL |GFP_DMA ); - -if (!private->crw_region) - goto out_free_schib; -return private; - -out_free_schib: -kmem_cache_free (vfio_ccw_schib_region, private->schib_region); -out_free_cmd: -kmem_cache_free (vfio_ccw_cmd_region, private->cmd_region); -out_free_io: -kmem_cache_free (vfio_ccw_io_region, private->io_region); -out_free_cp: -kfree (private->cp.guest_cp); -out_free_private: -mutex_destroy (&private->io_mutex); -kfree (private); -return ERR_PTR (-ENOMEM ); -} -static void vfio_ccw_free_private (struct vfio_ccw_private *private) {struct vfio_ccw_crw *crw, *temp;
@@ -257,10 +201,10 @@ static int vfio_ccw_sch_probe(struct subchannel *sch)if (ret) goto out_free; - private =vfio_ccw_alloc_private (sch); -if (IS_ERR (private)) { + private =kzalloc (sizeof (*private),GFP_KERNEL ); +if (!private) {device_unregister (&parent->dev); -return PTR_ERR (private); +return -ENOMEM ; }dev_set_drvdata (&sch->dev, parent);
drivers/s390/cio/vfio_ccw_ops.c +43 -0
51 lines not on this page · raw message
drivers/s390/cio/vfio_ccw_private.h +6 -1
@@ -131,6 +131,8 @@ struct vfio_ccw_private { }__aligned(8) ;int vfio_ccw_sch_quiesce (struct subchannel *sch); +void vfio_ccw_sch_io_todo (struct work_struct *work); +void vfio_ccw_crw_todo (struct work_struct *work);extern struct mdev_driver vfio_ccw_mdev_driver;
@@ -178,7 +180,10 @@ static inline void vfio_ccw_fsm_event(struct vfio_ccw_private *private, }extern struct workqueue_struct *vfio_ccw_work_q; - +extern struct kmem_cache *vfio_ccw_io_region; +extern struct kmem_cache *vfio_ccw_cmd_region; +extern struct kmem_cache *vfio_ccw_schib_region; +extern struct kmem_cache *vfio_ccw_crw_region;/* s390 debug feature, similar to base cio */ extern debug_info_t *vfio_ccw_debug_msg_id;
Signature · 1 line
2.34.1
Eric Farman
maintainerPATCH v3 4/7 vfio/ccw: move private to mdev lifecycle
In reply to Eric FarmanNow that the mdev parent data is split out into its own struct, it is safe to move the remaining private data to follow the mdev probe/remove lifecycle. The mdev parent data will remain where it is, and follow the subchannel and the css driver interfaces.
--- drivers/s390/cio/vfio_ccw_drv.c | 16 +--------------- drivers/s390/cio/vfio_ccw_ops.c | 26 +++++++++++++------------- drivers/s390/cio/vfio_ccw_private.h | 2 ++ 3 files changed, 16 insertions(+), 28 deletions(-)
drivers/s390/cio/vfio_ccw_drv.c +1 -15
@@ -152,7 +152,7 @@ static void vfio_ccw_sch_irq(struct subchannel *sch)vfio_ccw_fsm_event (private,VFIO_CCW_EVENT_INTERRUPT ); } -static void vfio_ccw_free_private (struct vfio_ccw_private *private) +void vfio_ccw_free_private (struct vfio_ccw_private *private) {struct vfio_ccw_crw *crw, *temp;
@@ -180,7 +180,6 @@ static void vfio_ccw_free_parent(struct device *dev)static int vfio_ccw_sch_probe (struct subchannel *sch) {struct pmcw *pmcw = &sch->schib.pmcw; -struct vfio_ccw_private *private;struct vfio_ccw_parent *parent;int ret = -ENOMEM ;
@@ -201,14 +200,7 @@ static int vfio_ccw_sch_probe(struct subchannel *sch)if (ret) goto out_free; - private =kzalloc (sizeof (*private),GFP_KERNEL ); -if (!private) { -device_unregister (&parent->dev); -return -ENOMEM ; - } -dev_set_drvdata (&sch->dev, parent); -dev_set_drvdata (&parent->dev, private); parent->mdev_type.sysfs_name ="io" ; parent->mdev_type.pretty_name ="I/O subchannel (Non-QDIO)" ;
@@ -227,25 +219,19 @@ static int vfio_ccw_sch_probe(struct subchannel *sch) out_unreg:device_unregister (&parent->dev); out_free: -dev_set_drvdata (&parent->dev,NULL );dev_set_drvdata (&sch->dev,NULL ); -if (private) -vfio_ccw_free_private (private);return ret; }static void vfio_ccw_sch_remove (struct subchannel *sch) {struct vfio_ccw_parent *parent =dev_get_drvdata (&sch->dev); -struct vfio_ccw_private *private =dev_get_drvdata (&parent->dev);mdev_unregister_parent (&parent->parent);device_unregister (&parent->dev);dev_set_drvdata (&sch->dev,NULL ); -vfio_ccw_free_private (private); -VFIO_CCW_MSG_EVENT (4 ,"unbound from subchannel %x.%x.%04x\n" , sch->schid.cssid, sch->schid.ssid, sch->schid.sch_no);
drivers/s390/cio/vfio_ccw_ops.c +13 -13
@@ -100,15 +100,20 @@ static int vfio_ccw_mdev_probe(struct mdev_device *mdev) {struct subchannel *sch =to_subchannel (mdev->dev.parent);struct vfio_ccw_parent *parent =dev_get_drvdata (&sch->dev); -struct vfio_ccw_private *private =dev_get_drvdata (&parent->dev); +struct vfio_ccw_private *private;int ret; -if (private->state ==VFIO_CCW_STATE_NOT_OPER ) -return -ENODEV ; + private =kzalloc (sizeof (*private),GFP_KERNEL ); +if (!private) +return -ENOMEM ; ret =vfio_init_device (&private->vdev, &mdev->dev, &vfio_ccw_dev_ops); -if (ret) +if (ret) { +kfree (private);return ret; + } + +dev_set_drvdata (&parent->dev, private); VFIO_CCW_MSG_EVENT(2, "sch %x.%x.%04x: create\n", sch->schid.cssid,
@@ -122,6 +127,7 @@ static int vfio_ccw_mdev_probe(struct mdev_device *mdev)return 0 ; err_put_vdev: +dev_set_drvdata (&parent->dev,NULL );vfio_put_device (&private->vdev);return ret; }
@@ -131,15 +137,6 @@ static void vfio_ccw_mdev_release_dev(struct vfio_device *vdev)struct vfio_ccw_private *private = container_of(vdev, struct vfio_ccw_private, vdev); -/* -* We cannot free vfio_ccw_private here because it includes -* parent info which must be free'ed by css driver. -* -* Use a workaround by memset'ing the core device part and -* then notifying the remove path that all active references -* to this device have been released. -*/ -memset (vdev,0 ,sizeof (*vdev));complete (&private->release_comp); }
@@ -156,6 +153,7 @@ static void vfio_ccw_mdev_remove(struct mdev_device *mdev)vfio_unregister_group_dev (&private->vdev); +dev_set_drvdata (&parent->dev,NULL );vfio_put_device (&private->vdev);/* * Wait for all active references on mdev are released so it
@@ -166,6 +164,8 @@ static void vfio_ccw_mdev_remove(struct mdev_device *mdev)* cycle. */ wait_for_completion (&private->release_comp); + +vfio_ccw_free_private (private); }static int vfio_ccw_mdev_open_device (struct vfio_device *vdev)
drivers/s390/cio/vfio_ccw_private.h +2 -0
@@ -134,6 +134,8 @@ int vfio_ccw_sch_quiesce(struct subchannel *sch);void vfio_ccw_sch_io_todo (struct work_struct *work);void vfio_ccw_crw_todo (struct work_struct *work); +void vfio_ccw_free_private (struct vfio_ccw_private *private); +extern struct mdev_driver vfio_ccw_mdev_driver;/*
Signature · 1 line
2.34.1
Eric Farman
maintainerPATCH v3 5/7 vfio/ccw: remove release completion
In reply to Eric FarmanThere's enough separation between the parent and private structs now, that it is fine to remove the release completion hack.
--- drivers/s390/cio/vfio_ccw_ops.c | 14 +------------- drivers/s390/cio/vfio_ccw_private.h | 3 --- 2 files changed, 1 insertion(+), 16 deletions(-)
drivers/s390/cio/vfio_ccw_ops.c +1 -13
@@ -54,7 +54,6 @@ static int vfio_ccw_mdev_init_dev(struct vfio_device *vdev)INIT_LIST_HEAD (&private->crw);INIT_WORK (&private->io_work, vfio_ccw_sch_io_todo);INIT_WORK (&private->crw_work, vfio_ccw_crw_todo); -init_completion (&private->release_comp); private->cp.guest_cp =kcalloc (CCWCHAIN_LEN_MAX ,sizeof (struct ccw1 ),GFP_KERNEL );
@@ -137,7 +136,7 @@ static void vfio_ccw_mdev_release_dev(struct vfio_device *vdev)struct vfio_ccw_private *private = container_of(vdev, struct vfio_ccw_private, vdev); -complete (&private->release_comp); +vfio_ccw_free_private (private); }static void vfio_ccw_mdev_remove (struct mdev_device *mdev)
@@ -155,17 +154,6 @@ static void vfio_ccw_mdev_remove(struct mdev_device *mdev)dev_set_drvdata (&parent->dev,NULL );vfio_put_device (&private->vdev); -/* -* Wait for all active references on mdev are released so it -* is safe to defer kfree() to a later point. -* -* TODO: the clean fix is to split parent/mdev info from ccw -* private structure so each can be managed in its own life -* cycle. -*/ -wait_for_completion (&private->release_comp); - -vfio_ccw_free_private (private); }static int vfio_ccw_mdev_open_device (struct vfio_device *vdev)
drivers/s390/cio/vfio_ccw_private.h +0 -3
@@ -102,7 +102,6 @@ struct vfio_ccw_parent {* @req_trigger: eventfd ctx for signaling userspace to return device * @io_work: work for deferral process of I/O handling * @crw_work: work for deferral process of CRW handling -* @release_comp: synchronization helper for vfio device release */ struct vfio_ccw_private {struct vfio_device vdev;
@@ -126,8 +125,6 @@ struct vfio_ccw_private {struct eventfd_ctx *req_trigger;struct work_struct io_work;struct work_struct crw_work; - -struct completion release_comp; }__aligned(8) ;int vfio_ccw_sch_quiesce (struct subchannel *sch);
Signature · 1 line
2.34.1
Eric Farman
maintainerPATCH v3 6/7 vfio/ccw: replace vfio_init_device with _alloc_
In reply to Eric FarmanNow that we have a reasonable separation of structs that follow the subchannel and mdev lifecycles, there's no reason we can't call the official vfio_alloc_device routine for our private data, and behave like everyone else.
--- drivers/s390/cio/vfio_ccw_drv.c | 18 ------------------ drivers/s390/cio/vfio_ccw_ops.c | 28 ++++++++++++++++++---------- drivers/s390/cio/vfio_ccw_private.h | 2 -- drivers/vfio/vfio_main.c | 10 +++++----- include/linux/vfio.h | 2 -- 5 files changed, 23 insertions(+), 37 deletions(-)
drivers/s390/cio/vfio_ccw_drv.c +0 -18
@@ -152,24 +152,6 @@ static void vfio_ccw_sch_irq(struct subchannel *sch)vfio_ccw_fsm_event (private,VFIO_CCW_EVENT_INTERRUPT ); } -void vfio_ccw_free_private (struct vfio_ccw_private *private) -{ -struct vfio_ccw_crw *crw, *temp; - -list_for_each_entry_safe (crw, temp, &private->crw, next) { -list_del (&crw->next); -kfree (crw); - } - -kmem_cache_free (vfio_ccw_crw_region, private->crw_region); -kmem_cache_free (vfio_ccw_schib_region, private->schib_region); -kmem_cache_free (vfio_ccw_cmd_region, private->cmd_region); -kmem_cache_free (vfio_ccw_io_region, private->io_region); -kfree (private->cp.guest_cp); -mutex_destroy (&private->io_mutex); -kfree (private); -} -static void vfio_ccw_free_parent (struct device *dev) { struct vfio_ccw_parent *parent = container_of(dev, struct vfio_ccw_parent, dev);
drivers/s390/cio/vfio_ccw_ops.c +18 -10
@@ -102,15 +102,10 @@ static int vfio_ccw_mdev_probe(struct mdev_device *mdev)struct vfio_ccw_private *private;int ret; - private =kzalloc (sizeof (*private),GFP_KERNEL ); -if (!private) -return -ENOMEM ; - - ret =vfio_init_device (&private->vdev, &mdev->dev, &vfio_ccw_dev_ops); -if (ret) { -kfree (private); -return ret; - } + private =vfio_alloc_device (vfio_ccw_private, vdev, &mdev->dev, + &vfio_ccw_dev_ops); +if (IS_ERR (private)) +return PTR_ERR (private);dev_set_drvdata (&parent->dev, private);
@@ -135,8 +130,21 @@ static void vfio_ccw_mdev_release_dev(struct vfio_device *vdev) {struct vfio_ccw_private *private = container_of(vdev, struct vfio_ccw_private, vdev); +struct vfio_ccw_crw *crw, *temp; + +list_for_each_entry_safe (crw, temp, &private->crw, next) { +list_del (&crw->next); +kfree (crw); + } + +kmem_cache_free (vfio_ccw_crw_region, private->crw_region); +kmem_cache_free (vfio_ccw_schib_region, private->schib_region); +kmem_cache_free (vfio_ccw_cmd_region, private->cmd_region); +kmem_cache_free (vfio_ccw_io_region, private->io_region); +kfree (private->cp.guest_cp); +mutex_destroy (&private->io_mutex); -vfio_ccw_free_private (private); +vfio_free_device (vdev); }static void vfio_ccw_mdev_remove (struct mdev_device *mdev)
drivers/s390/cio/vfio_ccw_private.h +0 -2
@@ -131,8 +131,6 @@ int vfio_ccw_sch_quiesce(struct subchannel *sch);void vfio_ccw_sch_io_todo (struct work_struct *work);void vfio_ccw_crw_todo (struct work_struct *work); -void vfio_ccw_free_private (struct vfio_ccw_private *private); -extern struct mdev_driver vfio_ccw_mdev_driver;/*
drivers/vfio/vfio_main.c +5 -5
@@ -348,6 +348,9 @@ static void vfio_device_release(struct device *dev) device->ops->release (device); } +static int vfio_init_device (struct vfio_device *device,struct device *dev, +const struct vfio_device_ops *ops); +/* * Allocate and initialize vfio_device so it can be registered to vfio * core.
@@ -386,11 +389,9 @@ EXPORT_SYMBOL_GPL(_vfio_alloc_device);/* * Initialize a vfio_device so it can be registered to vfio core. -* -* Only vfio-ccw driver should call this interface. */ -int vfio_init_device (struct vfio_device *device,struct device *dev, -const struct vfio_device_ops *ops) +static int vfio_init_device (struct vfio_device *device,struct device *dev, +const struct vfio_device_ops *ops) {int ret;
@@ -422,7 +423,6 @@ int vfio_init_device(struct vfio_device *device, struct device *dev,ida_free (&vfio.device_ida, device->index);return ret; } -EXPORT_SYMBOL_GPL (vfio_init_device);/* * The helper called by driver @release callback to free the device
include/linux/vfio.h +0 -2
@@ -176,8 +176,6 @@ struct vfio_device *_vfio_alloc_device(size_t size, struct device *dev, dev, ops), \ struct dev_struct, member) -int vfio_init_device (struct vfio_device *device,struct device *dev, -const struct vfio_device_ops *ops);void vfio_free_device (struct vfio_device *device);static inline void vfio_put_device (struct vfio_device *device) {
Signature · 1 line
2.34.1
Eric Farman
maintainerPATCH v3 7/7 vfio: Remove vfio_free_device
In reply to Eric FarmanWith the "mess" sorted out, we should be able to inline the vfio_free_device call introduced by commit cb9ff3f3b84c ("vfio: Add helpers for unifying vfio_device life cycle") and remove them from driver release callbacks.
--- drivers/gpu/drm/i915/gvt/kvmgt.c | 1 - drivers/s390/cio/vfio_ccw_ops.c | 2 -- drivers/s390/crypto/vfio_ap_ops.c | 6 ------ drivers/vfio/fsl-mc/vfio_fsl_mc.c | 1 - drivers/vfio/pci/vfio_pci_core.c | 1 - drivers/vfio/platform/vfio_amba.c | 1 - drivers/vfio/platform/vfio_platform.c | 1 - drivers/vfio/vfio_main.c | 22 ++++------------------ include/linux/vfio.h | 1 - samples/vfio-mdev/mbochs.c | 1 - samples/vfio-mdev/mdpy.c | 1 - samples/vfio-mdev/mtty.c | 1 - 12 files changed, 4 insertions(+), 35 deletions(-)
drivers/gpu/drm/i915/gvt/kvmgt.c +0 -1
@@ -1461,7 +1461,6 @@ static void intel_vgpu_release_dev(struct vfio_device *vfio_dev)struct intel_vgpu *vgpu =vfio_dev_to_vgpu (vfio_dev);intel_gvt_destroy_vgpu (vgpu); -vfio_free_device (vfio_dev); }static const struct vfio_device_ops intel_vgpu_dev_ops = {
drivers/s390/cio/vfio_ccw_ops.c +0 -2
@@ -143,8 +143,6 @@ static void vfio_ccw_mdev_release_dev(struct vfio_device *vdev)kmem_cache_free (vfio_ccw_io_region, private->io_region);kfree (private->cp.guest_cp);mutex_destroy (&private->io_mutex); - -vfio_free_device (vdev); }static void vfio_ccw_mdev_remove (struct mdev_device *mdev)
drivers/s390/crypto/vfio_ap_ops.c +0 -6
@@ -765,11 +765,6 @@ static void vfio_ap_mdev_unlink_fr_queues(struct ap_matrix_mdev *matrix_mdev) } } -static void vfio_ap_mdev_release_dev (struct vfio_device *vdev) -{ -vfio_free_device (vdev); -} -static void vfio_ap_mdev_remove (struct mdev_device *mdev) {struct ap_matrix_mdev *matrix_mdev =dev_get_drvdata (&mdev->dev);
@@ -1784,7 +1779,6 @@ static const struct attribute_group vfio_queue_attr_group = {static const struct vfio_device_ops vfio_ap_matrix_dev_ops = { .init = vfio_ap_mdev_init_dev, - .release = vfio_ap_mdev_release_dev, .open_device = vfio_ap_mdev_open_device, .close_device = vfio_ap_mdev_close_device, .ioctl = vfio_ap_mdev_ioctl,
drivers/vfio/fsl-mc/vfio_fsl_mc.c +0 -1
@@ -568,7 +568,6 @@ static void vfio_fsl_mc_release_dev(struct vfio_device *core_vdev)vfio_fsl_uninit_device (vdev);mutex_destroy (&vdev->igate); -vfio_free_device (core_vdev); }static int vfio_fsl_mc_remove (struct fsl_mc_device *mc_dev)
drivers/vfio/pci/vfio_pci_core.c +0 -1
@@ -2109,7 +2109,6 @@ void vfio_pci_core_release_dev(struct vfio_device *core_vdev)mutex_destroy (&vdev->vma_lock);kfree (vdev->region);kfree (vdev->pm_save); -vfio_free_device (core_vdev); }EXPORT_SYMBOL_GPL (vfio_pci_core_release_dev);
drivers/vfio/platform/vfio_amba.c +0 -1
@@ -95,7 +95,6 @@ static void vfio_amba_release_dev(struct vfio_device *core_vdev)vfio_platform_release_common (vdev);kfree (vdev->name); -vfio_free_device (core_vdev); }static void vfio_amba_remove (struct amba_device *adev)
drivers/vfio/platform/vfio_platform.c +0 -1
@@ -83,7 +83,6 @@ static void vfio_platform_release_dev(struct vfio_device *core_vdev) container_of(core_vdev, struct vfio_platform_device, vdev);vfio_platform_release_common (vdev); -vfio_free_device (core_vdev); }static int vfio_platform_remove (struct platform_device *pdev)
drivers/vfio/vfio_main.c +4 -18
@@ -339,13 +339,10 @@ static void vfio_device_release(struct device *dev)vfio_release_device_set (device);ida_free (&vfio.device_ida, device->index); -/* -* kvfree() cannot be done here due to a life cycle mess in -* vfio-ccw. Before the ccw part is fixed all drivers are -* required to support @release and call vfio_free_device() -* from there. -*/ - device->ops->release (device); +if (device->ops->release) + device->ops->release (device); + +kvfree (device); } static int vfio_init_device(struct vfio_device *device, struct device *dev,
@@ -424,17 +421,6 @@ static int vfio_init_device(struct vfio_device *device, struct device *dev,return ret; } -/* -* The helper called by driver @release callback to free the device -* structure. Drivers which don't have private data to clean can -* simply use this helper as its @release. -*/ -void vfio_free_device (struct vfio_device *device) -{ -kvfree (device); -} -EXPORT_SYMBOL_GPL (vfio_free_device); -static struct vfio_group *vfio_noiommu_group_alloc (struct device *dev,enum vfio_group_type type) {
include/linux/vfio.h +0 -1
@@ -176,7 +176,6 @@ struct vfio_device *_vfio_alloc_device(size_t size, struct device *dev, dev, ops), \ struct dev_struct, member) -void vfio_free_device (struct vfio_device *device);static inline void vfio_put_device (struct vfio_device *device) {put_device (&device->device);
samples/vfio-mdev/mbochs.c +0 -1
@@ -594,7 +594,6 @@ static void mbochs_release_dev(struct vfio_device *vdev)atomic_add (mdev_state->type->mbytes, &mbochs_avail_mbytes);kfree (mdev_state->pages);kfree (mdev_state->vconfig); -vfio_free_device (vdev); }static void mbochs_remove (struct mdev_device *mdev)
samples/vfio-mdev/mdpy.c +0 -1
@@ -283,7 +283,6 @@ static void mdpy_release_dev(struct vfio_device *vdev)vfree (mdev_state->memblk);kfree (mdev_state->vconfig); -vfio_free_device (vdev); }static void mdpy_remove (struct mdev_device *mdev)
samples/vfio-mdev/mtty.c +0 -1
@@ -784,7 +784,6 @@ static void mtty_release_dev(struct vfio_device *vdev)atomic_add (mdev_state->nr_ports, &mdev_avail_ports);kfree (mdev_state->vconfig); -vfio_free_device (vdev); }static void mtty_remove (struct mdev_device *mdev)
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.DOCS: warning for vfio-ccw parent rework (rev3)
In reply to Eric Farman== Series Details ==
== Series Details ==
Series: vfio-ccw parent rework (rev3)
URL : https://patchwork.freedesktop.org/series/109899/
State : warning
== Summary ==
Error: make htmldocs had i915 warnings./drivers/gpu/drm/i915/i915_perf_types.h:319: warning: Function parameter or member 'lock' not described in 'i915_perf_stream'
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for vfio-ccw parent rework (rev3)
In reply to Eric Farman== Series Details ==
== Series Details ==
Series: vfio-ccw parent rework (rev3)
URL : https://patchwork.freedesktop.org/series/109899/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12344 -> Patchwork_109899v3
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/index.html
Participating hosts (41 -> 29)
------------------------------
Additional (1): fi-cml-u2
Missing (13): fi-bdw-samus fi-tgl-dsi bat-dg2-8 bat-dg2-9 bat-adlp-6 bat-adlp-4 fi-ctg-p8600 bat-adln-1 bat-rplp-1 bat-rpls-1 bat-rpls-2 bat-dg2-11 bat-jsl-1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_109899v3:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* {igt@debugfs_test@basic-hwmon}:
- fi-cml-u2: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/fi-cml-u2/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_109899v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-cml-u2: NOTRUN -> [SKIP][2] ([i915#1208]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/fi-cml-u2/igt@gem_exec_fence@[email protected]
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][3] -> [FAIL][4] ([i915#7229])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/fi-pnv-d510/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/fi-pnv-d510/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-cml-u2: NOTRUN -> [SKIP][5] ([i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/fi-cml-u2/igt@[email protected]
* igt@gem_lmem_swapping@verify-random:
- fi-cml-u2: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/fi-cml-u2/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][7] -> [INCOMPLETE][8] ([i915#4785])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/fi-hsw-4770/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/fi-hsw-4770/igt@i915_selftest@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [PASS][9] -> [INCOMPLETE][10] ([i915#4817])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/fi-rkl-11600/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/fi-rkl-11600/igt@[email protected]
* igt@kms_chamelium@vga-hpd-fast:
- fi-cml-u2: NOTRUN -> [SKIP][11] ([fdo#109284] / [fdo#111827]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/fi-cml-u2/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-cml-u2: NOTRUN -> [SKIP][12] ([i915#4213])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/fi-cml-u2/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- fi-cml-u2: NOTRUN -> [SKIP][13] ([fdo#109285])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/fi-cml-u2/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-edp-1:
- fi-cml-u2: NOTRUN -> [INCOMPLETE][14] ([i915#7379])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/fi-cml-u2/igt@kms_pipe_crc_basic@[email protected]
* igt@kms_setmode@basic-clone-single-crtc:
- fi-cml-u2: NOTRUN -> [SKIP][15] ([i915#3555])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/fi-cml-u2/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- fi-cml-u2: NOTRUN -> [SKIP][16] ([fdo#109295] / [i915#3301])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/fi-cml-u2/igt@[email protected]
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][17] ([fdo#109271] / [i915#4312] / [i915#5594])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/fi-hsw-4770/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][18] ([i915#5334]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1208]: https://gitlab.freedesktop.org/drm/intel/issues/1208
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7379]: https://gitlab.freedesktop.org/drm/intel/issues/7379
Build changes
-------------
* Linux: CI_DRM_12344 -> Patchwork_109899v3
CI-20190529: 20190529
CI_DRM_12344: 36c4da734877fd1d69f0b9601dd7c3fa118d18f6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7044: dbeb6f92720292f8303182a0e649284cea5b11a6 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109899v3: 36c4da734877fd1d69f0b9601dd7c3fa118d18f6 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
94e05802053f vfio: Remove vfio_free_device 309beee6eef9 vfio/ccw: replace vfio_init_device with _alloc_ 1d88d78f039e vfio/ccw: remove release completion 132e41e902e5 vfio/ccw: move private to mdev lifecycle 88e85fccf5be vfio/ccw: move private initialization to callback 0e3f013bca6a vfio/ccw: remove private->sch 132cc2b65d99 vfio/ccw: create a parent struct
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for vfio-ccw parent rework (rev3)
In reply to Eric Farman== Series Details ==
== Series Details ==
Series: vfio-ccw parent rework (rev3)
URL : https://patchwork.freedesktop.org/series/109899/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12344_full -> Patchwork_109899v3_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_109899v3_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_109899v3_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (11 -> 9)
------------------------------
Missing (2): shard-rkl shard-dg1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_109899v3_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_mmap_gtt@flink-race:
- shard-skl: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl3/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_109899v3_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-apl: ([PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26]) -> ([FAIL][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51]) ([i915#4386])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl1/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl1/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl1/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl1/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl2/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl2/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl2/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl2/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl3/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl3/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl3/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl7/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl7/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl7/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl7/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl8/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl8/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl8/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl8/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl8/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl2/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl2/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl2/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl2/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl3/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl1/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl3/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl3/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl3/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl3/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl6/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl6/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl6/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl1/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl1/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl1/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl6/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl1/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl7/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl7/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl7/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl8/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl8/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl8/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl8/boot.html
- shard-snb: ([PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57], [PASS][58], [PASS][59], [PASS][60], [PASS][61], [PASS][62], [PASS][63], [PASS][64], [PASS][65], [PASS][66], [PASS][67], [PASS][68], [PASS][69], [PASS][70], [PASS][71], [PASS][72], [PASS][73], [PASS][74], [PASS][75], [PASS][76]) -> ([PASS][77], [PASS][78], [PASS][79], [PASS][80], [PASS][81], [PASS][82], [PASS][83], [PASS][84], [PASS][85], [PASS][86], [PASS][87], [PASS][88], [PASS][89], [FAIL][90], [PASS][91], [PASS][92], [PASS][93], [PASS][94], [PASS][95], [PASS][96], [PASS][97], [PASS][98], [PASS][99], [PASS][100], [PASS][101]) ([i915#4338])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb7/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb7/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb7/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb7/boot.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb6/boot.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb6/boot.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb6/boot.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb6/boot.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb6/boot.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb5/boot.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb5/boot.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb5/boot.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb5/boot.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb5/boot.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb4/boot.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb4/boot.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb4/boot.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb4/boot.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb4/boot.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb2/boot.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb2/boot.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb2/boot.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb2/boot.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb2/boot.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb2/boot.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb7/boot.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb7/boot.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb7/boot.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb7/boot.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb7/boot.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb6/boot.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb6/boot.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb6/boot.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb6/boot.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb6/boot.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb6/boot.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb5/boot.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb5/boot.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb5/boot.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb5/boot.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb5/boot.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb4/boot.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb4/boot.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb4/boot.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb4/boot.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb4/boot.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb2/boot.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb2/boot.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb2/boot.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb2/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][102] ([i915#2842])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-iclb2/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@heavy-verify-multi-ccs:
- shard-skl: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#4613]) +3 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl7/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-apl: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#4613]) +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl3/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-skl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#3323])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl7/igt@[email protected]
* igt@i915_module_load@load:
- shard-skl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#6227])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl3/igt@[email protected]
* igt@i915_pipe_stress@stress-xrgb8888-ytiled:
- shard-skl: NOTRUN -> [FAIL][107] ([i915#7036]) +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl7/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [PASS][108] -> [SKIP][109] ([i915#4281])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb6/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-iclb3/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-tglb: [PASS][110] -> [DMESG-WARN][111] ([i915#5591])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-tglb1/igt@i915_selftest@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-tglb8/igt@i915_selftest@[email protected]
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][112] -> [DMESG-WARN][113] ([i915#180])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl7/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl1/igt@[email protected]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][114] ([fdo#109271] / [i915#3886]) +7 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl4/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#3886]) +5 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl3/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@hdmi-crc-nonplanar-formats:
- shard-apl: NOTRUN -> [SKIP][116] ([fdo#109271] / [fdo#111827]) +6 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl3/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-with-enabled-mode:
- shard-skl: NOTRUN -> [SKIP][117] ([fdo#109271] / [fdo#111827]) +9 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl4/igt@[email protected]
* igt@kms_color@ctm-red-to-blue:
- shard-skl: NOTRUN -> [SKIP][118] ([fdo#109271] / [i915#3546])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl7/igt@[email protected]
* igt@kms_cursor_legacy@cursora-vs-flipa:
- shard-snb: NOTRUN -> [SKIP][119] ([fdo#109271]) +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-snb2/igt@[email protected]
* igt@kms_flip@2x-plain-flip-fb-recreate@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][120] -> [FAIL][121] ([i915#2122])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-glk3/igt@kms_flip@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-glk9/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [PASS][122] -> [FAIL][123] ([i915#79])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-skl7/igt@kms_flip@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl9/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: NOTRUN -> [FAIL][124] ([i915#2122]) +2 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][125] ([i915#2587] / [i915#2672]) +2 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-iclb1/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][126] ([i915#3555])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][127] ([i915#2672]) +3 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode:
- shard-skl: NOTRUN -> [SKIP][128] ([fdo#109271]) +248 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][129] ([i915#2672] / [i915#3555])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbcpsr-indfb-scaledprimary:
- shard-apl: NOTRUN -> [SKIP][130] ([fdo#109271]) +116 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl3/igt@[email protected]
* igt@kms_plane_alpha_blend@alpha-basic@pipe-a-edp-1:
- shard-skl: NOTRUN -> [FAIL][131] ([i915#4573]) +8 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl7/igt@kms_plane_alpha_blend@[email protected]
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1:
- shard-iclb: [PASS][132] -> [SKIP][133] ([i915#5176]) +2 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb7/igt@kms_plane_scaling@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-iclb2/igt@kms_plane_scaling@[email protected]
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-apl: NOTRUN -> [SKIP][134] ([fdo#109271] / [i915#658]) +1 similar issue
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl3/igt@[email protected]
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-skl: NOTRUN -> [SKIP][135] ([fdo#109271] / [i915#658]) +4 similar issues
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl4/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][136] -> [SKIP][137] ([fdo#109441]) +2 similar issues
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_sysfs_edid_timing:
- shard-skl: NOTRUN -> [FAIL][138] ([i915#6493])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl4/igt@kms_sysfs_edid_timing.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-apl: NOTRUN -> [SKIP][139] ([fdo#109271] / [i915#2437])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl3/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][140] ([fdo#109271] / [i915#2437])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl4/igt@[email protected]
* igt@perf@non-zero-reason:
- shard-skl: NOTRUN -> [TIMEOUT][141] ([i915#6943])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl7/igt@[email protected]
* igt@sysfs_clients@pidname:
- shard-apl: NOTRUN -> [SKIP][142] ([fdo#109271] / [i915#2994]) +1 similar issue
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl6/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][143] ([fdo#109271] / [i915#2994]) +2 similar issues
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl9/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [FAIL][144] ([i915#6268]) -> [PASS][145]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-tglb8/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-tglb7/igt@[email protected]
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [SKIP][146] ([i915#4525]) -> [PASS][147]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb8/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-iclb2/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][148] ([i915#2842]) -> [PASS][149] +1 similar issue
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-tglb1/igt@gem_exec_fair@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-tglb8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][150] ([i915#2842]) -> [PASS][151]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl1/igt@gem_exec_fair@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-iclb: [FAIL][152] ([i915#2842]) -> [PASS][153]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb2/igt@gem_exec_fair@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-iclb6/igt@gem_exec_fair@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][154] ([i915#2190]) -> [PASS][155]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-tglb7/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-tglb3/igt@[email protected]
* igt@gem_workarounds@suspend-resume-fd:
- shard-apl: [DMESG-WARN][156] ([i915#180]) -> [PASS][157]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/igt@[email protected]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl3/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [DMESG-WARN][158] ([i915#5566] / [i915#716]) -> [PASS][159]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl1/igt@[email protected]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl6/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][160] ([i915#3989] / [i915#454]) -> [PASS][161]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb3/igt@[email protected]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-iclb8/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- shard-skl: [DMESG-FAIL][162] ([i915#5334]) -> [PASS][163]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-skl9/igt@i915_selftest@live@gt_heartbeat.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl10/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_async_flips@alternate-sync-async-flip@pipe-c-hdmi-a-1:
- shard-glk: [FAIL][164] ([i915#2521]) -> [PASS][165]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-glk9/igt@kms_async_flips@[email protected]
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-glk8/igt@kms_async_flips@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][166] ([i915#79]) -> [PASS][167]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-glk1/igt@kms_flip@[email protected]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-glk7/igt@kms_flip@[email protected]
* igt@kms_flip@2x-plain-flip-fb-recreate@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][168] ([i915#2122]) -> [PASS][169]
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-glk3/igt@kms_flip@[email protected]
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-glk9/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-skl: [DMESG-WARN][170] ([i915#1982]) -> [PASS][171]
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt.html
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][172] ([fdo#109441]) -> [PASS][173] +3 similar issues
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
#### Warnings ####
* igt@gem_pwrite@basic-exhaustion:
- shard-apl: [INCOMPLETE][174] ([i915#7248]) -> [WARN][175] ([i915#2658])
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl1/igt@[email protected]
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl7/igt@[email protected]
- shard-tglb: [INCOMPLETE][176] ([i915#7248]) -> [WARN][177] ([i915#2658])
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-tglb6/igt@[email protected]
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-tglb3/igt@[email protected]
- shard-glk: [INCOMPLETE][178] ([i915#7248]) -> [WARN][179] ([i915#2658])
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-glk3/igt@[email protected]
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-glk9/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [INCOMPLETE][180] ([i915#180] / [i915#1982]) -> [DMESG-WARN][181] ([i915#1982])
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/igt@[email protected]
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl3/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][182] ([i915#2920]) -> [SKIP][183] ([i915#658]) +1 similar issue
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb2/igt@[email protected]
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-iclb6/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][184] ([i915#658]) -> [SKIP][185] ([i915#2920])
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb7/igt@[email protected]
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-iclb: [SKIP][186] ([fdo#111068] / [i915#658]) -> [SKIP][187] ([i915#2920])
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb7/igt@[email protected]
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-apl: ([FAIL][188], [FAIL][189], [FAIL][190], [FAIL][191], [FAIL][192]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][193], [FAIL][194], [FAIL][195]) ([i915#180] / [i915#3002] / [i915#4312])
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/igt@[email protected]
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/igt@[email protected]
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl1/igt@[email protected]
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl8/igt@[email protected]
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/igt@[email protected]
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl1/igt@[email protected]
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl3/igt@[email protected]
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/shard-apl6/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4338]: https://gitlab.freedesktop.org/drm/intel/issues/4338
[i915#4386]: https://gitlab.freedesktop.org/drm/intel/issues/4386
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6943]: https://gitlab.freedesktop.org/drm/intel/issues/6943
[i915#7036]: https://gitlab.freedesktop.org/drm/intel/issues/7036
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12344 -> Patchwork_109899v3
CI-20190529: 20190529
CI_DRM_12344: 36c4da734877fd1d69f0b9601dd7c3fa118d18f6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7044: dbeb6f92720292f8303182a0e649284cea5b11a6 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109899v3: 36c4da734877fd1d69f0b9601dd7c3fa118d18f6 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109899v3/index.html
Alex Williamson
AppliedQuoted 63 lines · On Fri, 4 Nov 2022 15:20:00 +0100 Eric Farman <[email protected]> wrote:
Hi Alex,
Here's the (last?) update to the vfio-ccw lifecycle changes that I've sent recently, and were previously discussed at various points [1][2].
Patches 1-5 rework the behavior of the vfio-ccw driver's private struct. In summary, the mdev pieces are split out of
vfio_ccw_privateand into a newvfio_ccw_parentstruct that will continue to follow today's lifecycle. The remainder (bulk) of the private struct moves to follow the mdev probe/remove pair. There's opportunity for further separation of the things in the private struct, which would simplify some of the vfio-ccw code, but it got too hairy as I started that. Once vfio-ccw is no longer considered unique, those cleanups can happen at our leisure.Patch 6 removes the trickery where vfio-ccw uses
vfio_init_deviceinstead ofvfio_alloc_device, and thus removesvfio_init_devicefrom the outside world.Patch 7 removes
vfio_free_devicefrom vfio-ccw and the other drivers (hello, CC list!), letting it be handled byvfio_device_releasedirectly.I believe this covers everything in this space; let me know if not!
Thanks,
Eric[1] https://lore.kernel.org/kvm/[email protected]/
[2] https://lore.kernel.org/kvm/[email protected]/
v2->v3:
- [MR] Added r-b to remaining patches (Thank you!)
- Patch 1:
[gfx checkpatch] Whitespace
[EF] Removeput_device(&parent->dev)
[MR] Fix error exit when alloc of parent fails
[MR] Check for !private onsch_probeerror path
- Patch 3:
[EF] Fix error exit when alloc of private fails
- Patch 6:
[AW] Added ack (Thank you!)
- Patch 7:
[CH, AK] Added r-b (Thank you!)
[AW] Added ack (Thank you!)
v2: https://lore.kernel.org/kvm/[email protected]/
v1: https://lore.kernel.org/kvm/[email protected]/Eric Farman (7):
vfio/ccw: create a parent struct vfio/ccw: removeprivate->sch
vfio/ccw: move private initialization to callback vfio/ccw: move private to mdev lifecycle vfio/ccw: remove release completion vfio/ccw: replacevfio_init_devicewith _alloc_
vfio: Removevfio_free_devicedrivers/gpu/drm/i915/gvt/kvmgt.c | 1 - drivers/s390/cio/vfio_ccw_chp.c | 5 +- drivers/s390/cio/vfio_ccw_drv.c | 173 +++++++++++--------------- drivers/s390/cio/vfio_ccw_fsm.c | 27 ++-- drivers/s390/cio/vfio_ccw_ops.c | 107 +++++++++++----- drivers/s390/cio/vfio_ccw_private.h | 37 ++++-- drivers/s390/crypto/vfio_ap_ops.c | 6 - drivers/vfio/fsl-mc/vfio_fsl_mc.c | 1 - drivers/vfio/pci/vfio_pci_core.c | 1 -
Quoted 9 lines
drivers/vfio/platform/vfio_amba.c | 1 - drivers/vfio/platform/vfio_platform.c | 1 - drivers/vfio/vfio_main.c | 32 ++--- include/linux/vfio.h | 3 - samples/vfio-mdev/mbochs.c | 1 - samples/vfio-mdev/mdpy.c | 1 - samples/vfio-mdev/mtty.c | 1 - 16 files changed, 196 insertions(+), 202 deletions(-)
Applied to vfio next branch for v6.2. Thanks,
Alex