Skip to contentSkip to conversation

configs/kontron_bl_imx8mm_defconfig: bump U-boot to 2022.10

PATCH Superseded Heiko Thiery 2 participants 7 messages Nov 6, 2022 – Nov 8, 2022 Arm i.MX and Layerscape

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Heiko Thiery

author
#0 lore raw

PATCH 1/1 configs/kontron_bl_imx8mm_defconfig: bump U-boot to 2022.10

Fixes https://gitlab.com/buildroot.org/buildroot/-/jobs/3267233833
Signed-off-by Heiko Thiery <[email protected]>
---
 configs/kontron_bl_imx8mm_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
configs/kontron_bl_imx8mm_defconfig +2 -1
index ff376662e9..240cb52245 100644
@@ -38,7 +38,7 @@ BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES="IMX_BOOT_UART_BASE=0x30880
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10"
 BR2_TARGET_UBOOT_BOARD_DEFCONFIG="kontron-sl-mx8mm"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_PYTHON3=y

@@ -48,6 +48,7 @@ BR2_TARGET_UBOOT_NEEDS_GNUTLS=y
 BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
 BR2_TARGET_UBOOT_NEEDS_ATF_BL31_BIN=y
 BR2_TARGET_UBOOT_NEEDS_IMX_FIRMWARE=y
+BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y
 BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
 BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="flash.bin"
 BR2_TARGET_UBOOT_SPL=y
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
author
#1 lore raw

PATCH 1/1 configs/kontron_smarc_sal28: add BR2_TARGET_UBOOT_NEEDS_OPENSSL

Uboot host tools require openssl. So enable BR2_TARGET_UBOOT_NEEDS_OPENSSL.

Fixes https://gitlab.com/buildroot.org/buildroot/-/jobs/3267233835
Signed-off-by Heiko Thiery <[email protected]>
---
 configs/kontron_smarc_sal28_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/kontron_smarc_sal28_defconfig +1 -0
index 25846c8cbd..f8515f5b76 100644
@@ -27,6 +27,7 @@ BR2_TARGET_UBOOT_BOARD_DEFCONFIG="kontron_sl28"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_PYTHON3=y
 BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y
 BR2_TARGET_UBOOT_NEEDS_GNUTLS=y
 # BR2_TARGET_UBOOT_FORMAT_BIN is not set
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Applied
#2 lore raw

Re: [Buildroot] [PATCH] configs/kontron_smarc_sal28: add BR2_TARGET_UBOOT_NEEDS_OPENSSL

On 2022-11-06 11:20 +0100, Heiko Thiery spake thusly:

Quoted 5 lines

Uboot host tools require openssl. So enable BR2_TARGET_UBOOT_NEEDS_OPENSSL.

Fixes https://gitlab.com/buildroot.org/buildroot/-/jobs/3267233835
Signed-off-by Heiko Thiery <[email protected]>

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 23 lines
---
 configs/kontron_smarc_sal28_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/kontron_smarc_sal28_defconfig +1 -0
index 25846c8cbd..f8515f5b76 100644
@@ -27,6 +27,7 @@ BR2_TARGET_UBOOT_BOARD_DEFCONFIG="kontron_sl28"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_PYTHON3=y
 BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y
 BR2_TARGET_UBOOT_NEEDS_GNUTLS=y
 # BR2_TARGET_UBOOT_FORMAT_BIN is not set
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
author
#3 lore raw

PATCH 1/1 DEVELOPERS: add myself to configs/kontron_smarc_sal28_defconfig

In reply to Heiko Thiery
Signed-off-by Heiko Thiery <[email protected]>
---
 DEVELOPERS | 2 ++
 1 file changed, 2 insertions(+)
DEVELOPERS +2 -0
index 2613624f4b..9bd98da5ef 100644
@@ -1243,8 +1243,10 @@ F:	package/volk/
 
 N:	Heiko Thiery <[email protected]>
 F:	board/kontron/bl-imx8mm/
+F:	board/kontron/smarc-sal28/
 F:	board/kontron/pitx-imx8m/
 F:	configs/kontron_bl_imx8mm_defconfig
+F:	configs/kontron_smarc_sal28_defconfig
 F:	configs/kontron_pitx_imx8m_defconfig
 F:	package/altera-stapl/
 F:	package/ipmitool/
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Applied
#4 lore raw

Re: [Buildroot] [PATCH] DEVELOPERS: add myself to configs/kontron_smarc_sal28_defconfig

Heiko, All,

On 2022-11-06 11:20 +0100, Heiko Thiery spake thusly:

Quoted 1 line
Signed-off-by Heiko Thiery <[email protected]>

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 DEVELOPERS | 2 ++
 1 file changed, 2 insertions(+)
DEVELOPERS +2 -0
index 2613624f4b..9bd98da5ef 100644
@@ -1243,8 +1243,10 @@ F:	package/volk/
 
 N:	Heiko Thiery <[email protected]>
 F:	board/kontron/bl-imx8mm/
+F:	board/kontron/smarc-sal28/
 F:	board/kontron/pitx-imx8m/
 F:	configs/kontron_bl_imx8mm_defconfig
+F:	configs/kontron_smarc_sal28_defconfig
 F:	configs/kontron_pitx_imx8m_defconfig
 F:	package/altera-stapl/
 F:	package/ipmitool/
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#5 lore raw
In reply to Heiko Thiery

Heiko, All,

On 2022-11-06 11:20 +0100, Heiko Thiery spake thusly:

Quoted 12 lines
Fixes https://gitlab.com/buildroot.org/buildroot/-/jobs/3267233833
Signed-off-by Heiko Thiery <[email protected]>
---
 configs/kontron_bl_imx8mm_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
configs/kontron_bl_imx8mm_defconfig +0 -0
index ff376662e9..240cb52245 100644

configs/kontron_bl_imx8mm_defconfig BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES="IMX_BOOT_UART_BASE=0x30880 · line 41

Quoted 5 lines
configs/kontron_bl_imx8mm_defconfig +1 -1
@@ -38,7 +38,7 @@ BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES="IMX_BOOT_UART_BASE=0x30880
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10"

As far as I can see, the linked build failure is about missing -luuid and -lgnutls

I see you added BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y, below, but did you forget to add BR2_TARGET_UBOOT_NEEDS_GNUTLS=y too?

Also, is the version bump really required to fix the build issue? If so, it should be explained in the commit log, plese.

Regards,
Yann E. MORIN.

Quoted 18 lines
configs/kontron_bl_imx8mm_defconfig +1 -0
 BR2_TARGET_UBOOT_BOARD_DEFCONFIG="kontron-sl-mx8mm"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_PYTHON3=y

@@ -48,6 +48,7 @@ BR2_TARGET_UBOOT_NEEDS_GNUTLS=y
 BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
 BR2_TARGET_UBOOT_NEEDS_ATF_BL31_BIN=y
 BR2_TARGET_UBOOT_NEEDS_IMX_FIRMWARE=y
+BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y
 BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
 BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="flash.bin"
 BR2_TARGET_UBOOT_SPL=y
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
author
#6 lore raw

)Hi Yann,

Am Mo., 7. Nov. 2022 um 21:20 Uhr schrieb Yann E. MORIN <[email protected]>:

Quoted 25 lines

Heiko, All,

On 2022-11-06 11:20 +0100, Heiko Thiery spake thusly:

Quoted 12 lines
Fixes https://gitlab.com/buildroot.org/buildroot/-/jobs/3267233833
Signed-off-by Heiko Thiery <[email protected]>
---
 configs/kontron_bl_imx8mm_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
configs/kontron_bl_imx8mm_defconfig +0 -0
index ff376662e9..240cb52245 100644

configs/kontron_bl_imx8mm_defconfig BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES="IMX_BOOT_UART_BASE=0x30880 · line 41

Quoted 5 lines
configs/kontron_bl_imx8mm_defconfig +1 -1
@@ -38,7 +38,7 @@ BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES="IMX_BOOT_UART_BASE=0x30880
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10"

As far as I can see, the linked build failure is about missing -luuid and -lgnutls

Quoted 2 lines

I see you added BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y, below, but did you forget to add BR2_TARGET_UBOOT_NEEDS_GNUTLS=y too?

The BR2_TARGET_UBOOT_NEEDS_GNUTLS is already in the defconfig but was not enough. There were some issues with the build system of u-boot. They were fixed upstream and are now available in the new version.

Quoted 2 lines

Also, is the version bump really required to fix the build issue? If so, it should be explained in the commit log, plese.

In the new U-boot release are some patches that fix the issue with:
a638bd349ea438256daf9c1f323402a137c55e03 (kbuild: add KBUILD_HOSTLDFLAGS to cmd_host-csingle) [1] 31a7688cbe0ed5edf4108a1f7ef4653659610d4b (tools: mkeficapsule: use pkg-config to get -luuid and -lgnutls) [2]

[1] https://source.denx.de/u-boot/u-boot/-/commit/a638bd349ea438256daf9c1f323402a137c55e03
[2] https://source.denx.de/u-boot/u-boot/-/commit/31a7688cbe0ed5edf4108a1f7ef4653659610d4b

I will explain that in the commit log and send a v2 for that.

Signature · 1 line
Heiko
Quoted 25 lines

Regards,
Yann E. MORIN.

Quoted 14 lines
configs/kontron_bl_imx8mm_defconfig +1 -1
 BR2_TARGET_UBOOT_BOARD_DEFCONFIG="kontron-sl-mx8mm"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_PYTHON3=y

@@ -48,6 +48,7 @@ BR2_TARGET_UBOOT_NEEDS_GNUTLS=y
 BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
 BR2_TARGET_UBOOT_NEEDS_ATF_BL31_BIN=y
 BR2_TARGET_UBOOT_NEEDS_IMX_FIRMWARE=y
+BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y
 BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
 BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="flash.bin"
 BR2_TARGET_UBOOT_SPL=y
--

2.20.1

Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

--
.-----------------.--------------------.------------------.--------------------.

Quoted 5 lines
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot