ina3221: Fix shunt sum critical calculation
PATCH 1/1 ina3221: Fix shunt sum critical calculation
The shunt sum critical limit register value should be left shifted by one bit as its LSB-0 is a reserved bit.
Signed-off-by Ninad Malwade <[email protected]>
--- drivers/hwmon/ina3221.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/ina3221.c +2 -2
@@ -228,7 +228,7 @@ static int ina3221_read_value(struct ina3221_data *ina, unsigned int reg,* Shunt Voltage Sum register has 14-bit value with 1-bit shift * Other Shunt Voltage registers have 12 bits with 3-bit shift */ -if (reg ==INA3221_SHUNT_SUM ) +if (reg ==INA3221_SHUNT_SUM || reg ==INA3221_CRIT_SUM ) *val =sign_extend32 (regval >>1 ,14 );else *val =sign_extend32 (regval >>3 ,12 );
@@ -465,7 +465,7 @@ static int ina3221_write_curr(struct device *dev, u32 attr,* SHUNT_SUM: (1 / 40uV) << 1 = 1 / 20uV * SHUNT[1-3]: (1 / 40uV) << 3 = 1 / 5uV */ -if (reg ==INA3221_SHUNT_SUM ) +if (reg ==INA3221_SHUNT_SUM || reg ==INA3221_CRIT_SUM ) regval =DIV_ROUND_CLOSEST (voltage_uv,20 ) &0xfffe ;else regval =DIV_ROUND_CLOSEST (voltage_uv,5 ) &0xfff8 ;
Signature · 1 line
2.17.1
Quoted 7 lines · Ninad Malwade
The shunt sum critical limit register value should be left shifted by one bit as its LSB-0 is a reserved bit.
Signed-off-by Ninad Malwade <[email protected]>--- drivers/hwmon/ina3221.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Looks correct:
Reviewed-by Thierry Reding <[email protected]>
Quoted 5 lines · Ninad Malwade
The shunt sum critical limit register value should be left shifted by one bit as its LSB-0 is a reserved bit.
Signed-off-by Ninad Malwade <[email protected]>Reviewed-by Thierry Reding <[email protected]>
Applied.
Thanks,
Guenter