Alphabetise the test list
PATCH 1/1 Alphabetise the test list
Alphabetical order is commanded by the comment at the top of the list, and also would have helped notice that skip-cqe.c is repeated.
--- test/Makefile | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
test/Makefile +4 -5
@@ -122,8 +122,8 @@ test_srcs := \ poll-cancel-ton.c \ poll-link.c \ poll-many.c \ - poll-mshot-update.c \ poll-mshot-overflow.c \ + poll-mshot-update.c \ poll-ring.c \ poll-v-poll.c \ pollfree.c \
@@ -144,10 +144,12 @@ test_srcs := \ sendmsg_fs_cve.c \ send_recv.c \ send_recvmsg.c \ + send-zerocopy.c \ shared-wq.c \ short-read.c \ shutdown.c \ sigfd-deadlock.c \ + single-issuer.c \ skip-cqe.c \ socket.c \ socket-rw.c \
@@ -168,8 +170,8 @@ test_srcs := \ submit-and-wait.c \ submit-link-fail.c \ submit-reuse.c \ - sync-cancel.c \ symlink.c \ + sync-cancel.c \ teardowns.c \ thread-exit.c \ timeout.c \
@@ -179,9 +181,6 @@ test_srcs := \ unlink.c \ wakeup-hang.c \ xattr.c \ - skip-cqe.c \ - single-issuer.c \ - send-zerocopy.c \ # EOL all_targets :=
base-commit: 754bc068ec482c5338a07dd74b7d3892729bb847
Signature · 1 line
2.30.2
Quoted 4 lines · Dylan Yudaken
Alphabetical order is commanded by the comment at the top of the list, and also would have helped notice that
skip-cqe.cis repeated.Signed-off-by Dylan Yudaken <[email protected]>
Right, I've been trying to keep this list sorted alphabetically, but Pavel doesn't care. Let's make this list sorted again.
Signature · 1 line
Ammar Faizi
Quoted 4 lines · Dylan Yudaken
Alphabetical order is commanded by the comment at the top of the list, and also would have helped notice that
skip-cqe.cis repeated.
Applied, thanks!
[1/1] Alphabetise the test list
commit: 750d34274ae6966fd9ae18f03fc9ffb7b32e1c18
Best regards,
Signature · 1 line
Jens Axboe
Quoted 1 line · Dylan Yudaken
Alphabetical order is commanded by the comment at the top of the list
We could create a make target to detect this kind of thing. A quick script off the top of my head gets pretty close to finding improper order, though not sure how pedantic it needs to be with the dashes '-'.
$ diff -u <(sed -e '/test_srcs :=/,/EOL/!d' test/Makefile | sed '1d;$d' | sed 's/\.c//g') \
<(sed -e '/test_srcs :=/,/EOL/!d' test/Makefile | sed '1d;$d' | sed 's/\.c//g' | sort)dev/fd/62 2022-11-08 10:11:22.041884178 -0800 renamed from dev/fd/63 2022-11-08 10:11:22.040884177 -0800 +3 -3
@@ -69,8 +69,8 @@ msg-ring \ multicqes_drain \ nolibc \ - nop-all-sizes \ nop \ + nop-all-sizes \ openat2 \ open-close \ open-direct-link \
@@ -83,13 +83,13 @@ poll-cancel \ poll-cancel-all \ poll-cancel-ton \ + pollfree \ poll-link \ poll-many \ poll-mshot-overflow \ poll-mshot-update \ poll-ring \ poll-v-poll \ - pollfree \ probe \ read-before-exit \ read-write \
@@ -99,8 +99,8 @@ register-restrictions \ rename \ ringbuf-read \ - ring-leak2 \ ring-leak \ + ring-leak2 \ rsrc_tags \ rw_merge_test \ self \
Quoted 9 lines · Keith Busch
Quoted 1 line · Dylan Yudaken
Alphabetical order is commanded by the comment at the top of the list
We could create a make target to detect this kind of thing. A quick script off the top of my head gets pretty close to finding improper order, though not sure how pedantic it needs to be with the dashes '-'.
$ diff -u <(sed -e '/test_srcs :=/,/EOL/!d' test/Makefile | sed '1d;$d' | sed 's/\.c//g') \ <(sed -e '/test_srcs :=/,/EOL/!d' test/Makefile | sed '1d;$d' | sed 's/\.c//g' | sort)
Good idea, we can also do this checking in our CI.
Signature · 1 line
Ammar Faizi