scsi: lpfc: remove redundant pointer lp
Subsystems (2)
PATCH v2 1/1 scsi: lpfc: remove redundant pointer lp
From: Colin Ian King <[email protected]>
Pointer lp is being initialized and incremented but the result is never read. The pointer is redundant and can be removed.
Once lp is removed, pcmd is not longer used. So removed pcmd as well
---
lp removal by Colin left as is.
I added the pcmd mod on top of it.
--- drivers/scsi/lpfc/lpfc_els.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/scsi/lpfc/lpfc_els.c +0 -5
@@ -9172,15 +9172,10 @@ static int lpfc_els_rcv_farpr(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb, struct lpfc_nodelist *ndlp) { - struct lpfc_dmabuf *pcmd; -uint32_t *lp; uint32_t did; did =get_job_els_rsp64_did (vport->phba, cmdiocb); - pcmd = cmdiocb->cmd_dmabuf; - lp = (uint32_t *)pcmd->virt; - lp++;/* FARP-RSP received from DID <did> */ lpfc_printf_vlog (vport,KERN_INFO ,LOG_ELS ,"0600 FARP-RSP received from DID x%x\n" , did);
Signature · 1 line
2.35.3
Martin K. Petersen
AppliedJames,
Quoted 4 lines
Pointer lp is being initialized and incremented but the result is never read. The pointer is redundant and can be removed.
Once lp is removed, pcmd is not longer used. So removed pcmd as well
Applied to 6.2/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 8 lines · James Smart
From: Colin Ian King <[email protected]>
Pointer lp is being initialized and incremented but the result is never read. The pointer is redundant and can be removed.
Once lp is removed, pcmd is not longer used. So removed pcmd as well
[...]
Applied to 6.2/scsi-queue, thanks!
[1/1] scsi: lpfc: remove redundant pointer lp
https://git.kernel.org/mkp/scsi/c/729c287e9f74
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering