Skip to contentSkip to conversation

arm64: dts: qcom: sc7280-idp: don't modify &ipa twice

PATCH Applied Alex Elder 4 participants 4 messages Nov 8, 2022 – Nov 10, 2022

Subsystems (4)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support Arm/Qualcomm chromebook support
lore
Share & tools
lore

Alex Elder

author
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sc7280-idp: don't modify &ipa twice

In "sc7280-idp.dts", the IPA node is modified after being defined. However that file includes "sc7280-idp.dtsi", which also modifies the IPA node (in the same way). This only needs to be done in "sc7280-idp.dtsi".

Signed-off-by Alex Elder <[email protected]>
---
 arch/arm64/boot/dts/qcom/sc7280-idp.dts | 5 -----
 1 file changed, 5 deletions(-)
arch/arm64/boot/dts/qcom/sc7280-idp.dts +0 -5
index 7559164cdda08..9ddfdfdd354ee 100644
@@ -61,11 +61,6 @@ &bluetooth {
 	vddio-supply = <&vreg_l19b_1p8>;
 };
 
-&ipa {
-	status = "okay";
-	modem-init;
-};
-
 &pmk8350_rtc {
 	status = "okay";
 };
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Alex Elder

In "sc7280-idp.dts", the IPA node is modified after being defined. However that file includes "sc7280-idp.dtsi", which also modifies the IPA node (in the same way). This only needs to be done in "sc7280-idp.dtsi".

Signed-off-by Alex Elder <[email protected]>

---

Reviewed-by Konrad Dybcio <[email protected]>

Konrad

Quoted 19 lines
  arch/arm64/boot/dts/qcom/sc7280-idp.dts | 5 -----
  1 file changed, 5 deletions(-)
arch/arm64/boot/dts/qcom/sc7280-idp.dts +0 -5
index 7559164cdda08..9ddfdfdd354ee 100644
@@ -61,11 +61,6 @@ &bluetooth {
  	vddio-supply = <&vreg_l19b_1p8>;
  };
 
-&ipa {
-	status = "okay";
-	modem-init;
-};
-
  &pmk8350_rtc {
  	status = "okay";
  };
maintainer Applied
#3 lore raw
In reply to Alex Elder
Quoted 6 lines · Alex Elder

In "sc7280-idp.dts", the IPA node is modified after being defined. However that file includes "sc7280-idp.dtsi", which also modifies the IPA node (in the same way). This only needs to be done in "sc7280-idp.dtsi".

Applied, thanks!

[1/1] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice

      commit: d4d4a7c4fd5f1b802ccf329edf11a3ade69b55e0

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>