Skip to contentSkip to conversation

net/mlx5: remove unneeded GENEVE option length assert

PATCH In review Suanming Mou 3 participants 3 messages Nov 9, 2022 Network drivers

lore
Share & tools
lore

Suanming Mou

author
#0 lore raw

PATCH 1/1 net/mlx5: remove unneeded GENEVE option length assert

In order to share flow items translate code, flow items translation of spec and mask was split individually.

In that case, the assert for GENEVE option length with mask becomes invalid, since the length in mask is bitmask. And as memcpy around the assert already checks the GENEVE option length, the assert looks redundant.

This commit removes the unneeded GENEVE option length assert.

Fixes cd4ab742064a ("net/mlx5: split flow item matcher and value translation")
Signed-off-by Suanming Mou <[email protected]>
---
 drivers/net/mlx5/mlx5_flow_dv.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/net/mlx5/mlx5_flow_dv.c +0 -4
index acd7ea8b79..7808a28787 100644
@@ -9616,13 +9616,9 @@ flow_dv_translate_item_geneve_opt(struct rte_eth_dev *dev, void *key,
 		memcpy(&opt_data_key, data,
 			RTE_MIN((uint32_t)(geneve_opt_v->option_len * 4),
 				sizeof(opt_data_key)));
-		MLX5_ASSERT((uint32_t)(geneve_opt_v->option_len * 4) <=
-				sizeof(opt_data_key));
 		memcpy(&opt_data_mask, geneve_opt_m->data,
 			RTE_MIN((uint32_t)(geneve_opt_v->option_len * 4),
 				sizeof(opt_data_mask)));
-		MLX5_ASSERT((uint32_t)(geneve_opt_v->option_len * 4) <=
-				sizeof(opt_data_mask));
 		MLX5_SET(fte_match_set_misc3, misc3_v,
 				geneve_tlv_option_0_data,
 			rte_be_to_cpu_32(opt_data_key & opt_data_mask));
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines

-----Original Message-----
From: Suanming Mou <[email protected]>
Sent: Wednesday, November 9, 2022 3:40
To: Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>
Cc: [email protected]; Raslan Darawsheh <[email protected]>
Subject: [PATCH] net/mlx5: remove unneeded GENEVE option length assert

In order to share flow items translate code, flow items translation of spec and mask was split individually.

In that case, the assert for GENEVE option length with mask becomes invalid, since the length in mask is bitmask. And as memcpy around the assert already checks the GENEVE option length, the assert looks redundant.

Quoted 6 lines

This commit removes the unneeded GENEVE option length assert.

Fixes cd4ab742064a ("net/mlx5: split flow item matcher and value

translation")

Signed-off-by Suanming Mou <[email protected]>
Acked-by Viacheslav Ovsiienko <[email protected]>
#2 lore raw
In reply to Suanming Mou

Hi,

Quoted 15 lines

-----Original Message-----
From: Suanming Mou <[email protected]>
Sent: Wednesday, November 9, 2022 3:40 AM
To: Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>
Cc: [email protected]; Raslan Darawsheh <[email protected]>
Subject: [PATCH] net/mlx5: remove unneeded GENEVE option length assert

In order to share flow items translate code, flow items translation of spec and mask was split individually.

In that case, the assert for GENEVE option length with mask becomes invalid, since the length in mask is bitmask. And as memcpy around the assert already checks the GENEVE option length, the assert looks redundant.

Quoted 6 lines

This commit removes the unneeded GENEVE option length assert.

Fixes cd4ab742064a ("net/mlx5: split flow item matcher and value

translation")

Signed-off-by Suanming Mou <[email protected]>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh