Skip to contentSkip to conversation

fault-inject: Enable stacktrace filter for x86-64

PATCH In review Jakub Sitnicki 2 participants 3 messages Nov 10, 2022 – Nov 14, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fault-inject: Enable stacktrace filter for x86-64

Stacktrace filtering for fault injection has been disabled on x86-64 since 2007 due to the lack of a DWARF unwinder. See commit 6d690dcac92a ("fault
injection: disable stacktrace filter for x86-64").

In 2017, the ORC unwider, an alternative to DWARF unwinder has been added in commit ee9f8fce9964 ("x86/unwind: Add the ORC unwinder").

We can now re-enable the stacktrace filter for x86-64.

---
 lib/Kconfig.debug | 1 -
 1 file changed, 1 deletion(-)
lib/Kconfig.debug +0 -1
index 3fc7abffc7aa..32c5329b0dd9 100644
@@ -1963,7 +1963,6 @@ config FAIL_SUNRPC
 config FAULT_INJECTION_STACKTRACE_FILTER
 	bool "stacktrace filter for fault-injection capabilities"
 	depends on FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT
-	depends on !X86_64
 	select STACKTRACE
 	depends on FRAME_POINTER || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86
 	help
Signature · 1 line
2.38.1
#1 lore raw

2022年11月10日(木) 20:30 Jakub Sitnicki <[email protected]>:

Quoted 9 lines

Stacktrace filtering for fault injection has been disabled on x86-64 since 2007 due to the lack of a DWARF unwinder. See commit 6d690dcac92a ("fault
injection: disable stacktrace filter for x86-64").

In 2017, the ORC unwider, an alternative to DWARF unwinder has been added in commit ee9f8fce9964 ("x86/unwind: Add the ORC unwinder").

We can now re-enable the stacktrace filter for x86-64.

The same change by Wei Yongjun is already in the linux-next via -mm tree.

But thank you for the good explanation.

#2 lore raw
Quoted 6 lines · Akinobu Mita

2022年11月10日(木) 20:30 Jakub Sitnicki <[email protected]>:

Quoted 5 lines

Stacktrace filtering for fault injection has been disabled on x86-64 since 2007 due to the lack of a DWARF unwinder. See commit 6d690dcac92a ("fault
injection: disable stacktrace filter for x86-64").

Quoted 8 lines
Quoted 4 lines

In 2017, the ORC unwider, an alternative to DWARF unwinder has been added in commit ee9f8fce9964 ("x86/unwind: Add the ORC unwinder").

We can now re-enable the stacktrace filter for x86-64.

The same change by Wei Yongjun is already in the linux-next via -mm tree.

But thank you for the good explanation.

Thanks for letting me know. Will check linux-next next time.

Please ignore my patch. Sorry for the noise.