Skip to contentSkip to conversation

common/mlx5: fix DevX register read error severity

PATCH In review Gregory Etelson 3 participants 3 messages Nov 10, 2022

lore
Share & tools
lore

Gregory Etelson

author
#0 lore raw

PATCH 1/1 common/mlx5: fix DevX register read error severity

PMD attempt to read HW UTC counter properties can fail because the feature has no support in port FW or mlx5 kernel module.

In that case PMD still can produce correct time-stamps if it runs on core with nanosecond time resolution.

Fixes b0067860959d ("common/mlx5: update log for DevX general command failure")
Cc [email protected]
Signed-off-by Gregory Etelson <[email protected]>
Acked-by Matan Azrad <[email protected]>
---
 drivers/common/mlx5/mlx5_devx_cmds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/common/mlx5/mlx5_devx_cmds.c +1 -1
index 05b9429c7f..59cebb530f 100644
@@ -111,7 +111,7 @@ mlx5_devx_cmd_register_read(void *ctx, uint16_t reg_id, uint32_t arg,
 					 MLX5_ST_SZ_BYTES(access_register_out) +
 					 sizeof(uint32_t) * dw_cnt);
 	if (rc || MLX5_FW_STATUS(out)) {
-		DEVX_DRV_LOG(ERR, out, "read access", "NIC register", reg_id);
+		DEVX_DRV_LOG(DEBUG, out, "read access", "NIC register", reg_id);
 		return MLX5_DEVX_ERR_RC(rc);
 	}
 	memcpy(data, &out[MLX5_ST_SZ_DW(access_register_out)],
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Gregory Etelson

PMD attempt to read HW UTC counter properties can fail because the feature has no support in port FW or mlx5 kernel module.

In that case PMD still can produce correct time-stamps if it runs on core with nanosecond time resolution.

Fixes b0067860959d ("common/mlx5: update log for DevX general command failure")

No blank line here.

Quoted 2 lines
Cc [email protected]
Reported-by David Marchand <[email protected]>
Quoted 2 lines
Signed-off-by Gregory Etelson <[email protected]>
Acked-by Matan Azrad <[email protected]>

I had tested the same change to pass OVS unit tests.

I did not hit any other error level messages from functions changed in b0067860959d ("common/mlx5: update log for DevX general command failure").
So I guess only changing this one is enough.

Acked-by David Marchand <[email protected]>
Signature · 1 line
David Marchand
#2 lore raw
In reply to Gregory Etelson

Hi,

Quoted 13 lines

-----Original Message-----
From: Gregory Etelson <[email protected]>
Sent: Thursday, November 10, 2022 3:05 PM
To: [email protected]
Cc: Gregory Etelson <[email protected]>; Matan Azrad <[email protected]>; Raslan Darawsheh <[email protected]>; [email protected]; Slava Ovsiienko <[email protected]>
Subject: [PATCH] common/mlx5: fix DevX register read error severity

PMD attempt to read HW UTC counter properties can fail because the feature
has no support in port FW or mlx5 kernel module.

Quoted 8 lines

In that case PMD still can produce correct time-stamps if it runs on core with nanosecond time resolution.

Fixes b0067860959d ("common/mlx5: update log for DevX general command

failure")
removed extra blank line
Cc: [email protected]

added reported-by tag

Quoted 2 lines
Signed-off-by Gregory Etelson <[email protected]>
Acked-by Matan Azrad <[email protected]>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh