scsi: qla2xxx: use strscpy() is more robust and safer
Subsystems (2)
PATCH 1/1 scsi: qla2xxx: use strscpy() is more robust and safer
From: Xu Panda <[email protected]>
The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings.
Reported-by Zeal Robot <[email protected]>
Signed-off-by Xu Panda <[email protected]>
Signed-off-by Yang Yang <[email protected]>
--- drivers/scsi/qla2xxx/qla_init.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/scsi/qla2xxx/qla_init.c +4 -4
@@ -4843,7 +4843,7 @@ qla2x00_set_model_info(scsi_qla_host_t *vha, uint8_t *model, size_t len,if (use_tbl && ha->pdev->subsystem_vendor ==PCI_VENDOR_ID_QLOGIC && index <QLA_MODEL_NAMES ) -strlcpy (ha->model_desc, +strscpy (ha->model_desc, qla2x00_model_name[index *2 +1 ],sizeof (ha->model_desc)); }else {
@@ -4851,14 +4851,14 @@ qla2x00_set_model_info(scsi_qla_host_t *vha, uint8_t *model, size_t len,if (use_tbl && ha->pdev->subsystem_vendor ==PCI_VENDOR_ID_QLOGIC && index <QLA_MODEL_NAMES ) { -strlcpy (ha->model_number, +strscpy (ha->model_number, qla2x00_model_name[index *2 ],sizeof (ha->model_number)); -strlcpy (ha->model_desc, +strscpy (ha->model_desc, qla2x00_model_name[index *2 +1 ],sizeof (ha->model_desc)); }else { -strlcpy (ha->model_number, def, +strscpy (ha->model_number, def,sizeof (ha->model_number)); } }
Signature · 1 line
2.15.2